[v1] drop unallocated_blocks_are_zero

[PATCH 6/8] block/vhdx: drop unallocated_blocks_are_zero

Posted by Vladimir Sementsov-Ogievskiy 5 years, 6 months ago

vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is
always assumed for it. unallocated_blocks_are_zero is useless, drop it.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 block/vhdx.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/vhdx.c b/block/vhdx.c
index aedd782604..45963a3166 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -1164,9 +1164,6 @@ static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
 
     bdi->cluster_size = s->block_size;
 
-    bdi->unallocated_blocks_are_zero =
-        (s->params.data_bits & VHDX_PARAMS_HAS_PARENT) == 0;
-
     return 0;
 }
 
-- 
2.21.0

Re: [PATCH 6/8] block/vhdx: drop unallocated_blocks_are_zero

Posted by Eric Blake 5 years, 6 months ago

On 5/6/20 4:25 AM, Vladimir Sementsov-Ogievskiy wrote:
> vhdx doesn't have .bdrv_co_block_status handler, so DATA|ALLOCATED is
> always assumed for it. unallocated_blocks_are_zero is useless, drop it.
> 

After the analysis I did in patch 1, this is correct.  No behavior change.

Reviewed-by: Eric Blake <eblake@redhat.com>

> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   block/vhdx.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/block/vhdx.c b/block/vhdx.c
> index aedd782604..45963a3166 100644
> --- a/block/vhdx.c
> +++ b/block/vhdx.c
> @@ -1164,9 +1164,6 @@ static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi)
>   
>       bdi->cluster_size = s->block_size;
>   
> -    bdi->unallocated_blocks_are_zero =
> -        (s->params.data_bits & VHDX_PARAMS_HAS_PARENT) == 0;
> -
>       return 0;
>   }
>   
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org