[PATCH v2 00/18] qom: Spring cleaning

Markus Armbruster posted 18 patches 3 years, 12 months ago
Test docker-mingw@fedora passed
Test checkpatch failed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200505152926.18877-1-armbru@redhat.com
Maintainers: Dmitry Fleytman <dmitry.fleytman@gmail.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Alberto Garcia <berto@igalia.com>, Jiri Slaby <jslaby@suse.cz>, Markus Armbruster <armbru@redhat.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>, Halil Pasic <pasic@linux.ibm.com>, Andrzej Zaborowski <balrogg@gmail.com>, Max Reitz <mreitz@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>, Jean-Christophe Dubois <jcd@tribudubois.net>, "Daniel P. Berrangé" <berrange@redhat.com>, Sven Schnelle <svens@stackframe.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Igor Mammedov <imammedo@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Tony Krowiak <akrowiak@linux.ibm.com>, David Hildenbrand <david@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, Jason Wang <jasowang@redhat.com>, Chris Wulff <crwulff@gmail.com>, Eric Auger <eric.auger@redhat.com>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Gerd Hoffmann <kraxel@redhat.com>, John Snow <jsnow@redhat.com>, Alistair Francis <alistair@alistair23.me>, David Gibson <david@gibson.dropbear.id.au>, Beniamino Galvani <b.galvani@gmail.com>, Sergio Lopez <slp@redhat.com>, "Gonglei (Arei)" <arei.gonglei@huawei.com>, Raphael Norwitz <raphael.norwitz@nutanix.com>, Peter Maydell <peter.maydell@linaro.org>, Zhang Chen <chen.zhang@intel.com>, Andrew Jeffery <andrew@aj.id.au>, Greg Kurz <groug@kaod.org>, Li Zhijian <lizhijian@cn.fujitsu.com>, Keith Busch <kbusch@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, BALATON Zoltan <balaton@eik.bme.hu>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Niek Linnenbank <nieklinnenbank@gmail.com>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Cornelia Huck <cohuck@redhat.com>, Pierre Morel <pmorel@linux.ibm.com>, Stefan Weil <sw@weilnetz.de>, Kevin Wolf <kwolf@redhat.com>, Marek Vasut <marex@denx.de>, Paolo Bonzini <pbonzini@redhat.com>, Radoslaw Biernacki <radoslaw.biernacki@linaro.org>, Joel Stanley <joel@jms.id.au>, Paul Durrant <paul@xen.org>, Matthew Rosato <mjrosato@linux.ibm.com>, Corey Minyard <minyard@acm.org>, "Hervé Poussineau" <hpoussin@reactos.org>, Palmer Dabbelt <palmer@dabbelt.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Richard Henderson <rth@twiddle.net>, Laurent Vivier <lvivier@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Amit Shah <amit@kernel.org>, Stefan Hajnoczi <stefanha@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Laszlo Ersek <lersek@redhat.com>, Eric Farman <farman@linux.ibm.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Stefano Stabellini <sstabellini@kernel.org>, Andrey Smirnov <andrew.smirnov@gmail.com>, Anthony Perard <anthony.perard@citrix.com>, "Cédric Le Goater" <clg@kaod.org>, Leif Lindholm <leif@nuviainc.com>, Fam Zheng <fam@euphon.net>, Christian Borntraeger <borntraeger@de.ibm.com>, Subbaraya Sundeep <sundeep.lkml@gmail.com>
hw/9pfs/9p.h                        |   2 +-
hw/s390x/virtio-ccw.h               |   2 +-
hw/sd/sdhci-internal.h              |   2 +-
hw/usb/ccid.h                       |   2 +-
hw/usb/hcd-ehci.h                   |   2 +-
include/hw/acpi/ich9.h              |   2 +-
include/hw/ppc/spapr.h              |   2 +-
include/hw/qdev-core.h              |   6 +-
include/hw/s390x/s390-ccw.h         |   2 +-
include/hw/scsi/scsi.h              |   2 +-
include/hw/usb.h                    |   2 +-
include/hw/xen/xen-block.h          |   2 +-
include/hw/xen/xen-bus.h            |   2 +-
include/qom/object.h                | 163 ++++-----
include/sysemu/sysemu.h             |   2 +-
monitor/monitor-internal.h          |   2 +-
target/ppc/cpu.h                    |   3 +-
target/s390x/cpu_features_def.inc.h |   2 +-
accel/kvm/kvm-all.c                 |   8 +-
accel/tcg/tcg-all.c                 |   7 +-
authz/list.c                        |   5 +-
authz/listfile.c                    |   6 +-
authz/pamacct.c                     |   3 +-
authz/simple.c                      |   3 +-
backends/cryptodev-vhost-user.c     |   3 +-
backends/cryptodev.c                |   2 +-
backends/dbus-vmstate.c             |   6 +-
backends/hostmem-file.c             |  11 +-
backends/hostmem-memfd.c            |  17 +-
backends/hostmem.c                  |  35 +-
backends/rng-egd.c                  |   3 +-
backends/rng-random.c               |   3 +-
backends/rng.c                      |   3 +-
backends/vhost-user.c               |   2 +-
block/throttle-groups.c             |   6 +-
bootdevice.c                        |  10 +-
chardev/char-socket.c               |   4 +-
chardev/char.c                      |   7 +-
crypto/secret.c                     |  18 +-
crypto/tlscreds.c                   |  12 +-
crypto/tlscredsanon.c               |   3 +-
crypto/tlscredspsk.c                |   6 +-
crypto/tlscredsx509.c               |   9 +-
hw/9pfs/9p.c                        |   4 +-
hw/9pfs/virtio-9p-device.c          |   4 +-
hw/acpi/ich9.c                      |  25 +-
hw/acpi/pcihp.c                     |   9 +-
hw/acpi/piix4.c                     |  15 +-
hw/arm/allwinner-a10.c              |   2 +-
hw/arm/allwinner-h3.c               |  12 +-
hw/arm/armv7m.c                     |   2 +-
hw/arm/aspeed.c                     |   4 +-
hw/arm/aspeed_ast2600.c             |  13 +-
hw/arm/aspeed_soc.c                 |  13 +-
hw/arm/bcm2835_peripherals.c        |  28 +-
hw/arm/bcm2836.c                    |  16 +-
hw/arm/cubieboard.c                 |   3 +-
hw/arm/mcimx6ul-evk.c               |   2 +-
hw/arm/mcimx7d-sabre.c              |   2 +-
hw/arm/msf2-soc.c                   |   3 +-
hw/arm/nrf51_soc.c                  |   3 +-
hw/arm/orangepi.c                   |   3 +-
hw/arm/raspi.c                      |   3 +-
hw/arm/sabrelite.c                  |   2 +-
hw/arm/sbsa-ref.c                   |   5 +-
hw/arm/vexpress.c                   |  10 +-
hw/arm/virt.c                       |  39 +--
hw/arm/xilinx_zynq.c                |   2 +-
hw/arm/xlnx-versal-virt.c           |   6 +-
hw/arm/xlnx-versal.c                |   2 +-
hw/arm/xlnx-zcu102.c                |  10 +-
hw/arm/xlnx-zynqmp.c                |   9 +-
hw/audio/intel-hda.c                |   2 +-
hw/audio/marvell_88w8618.c          |   2 +-
hw/audio/pcspk.c                    |   2 +-
hw/block/fdc.c                      |   4 +-
hw/block/nvme.c                     |   2 +-
hw/block/pflash_cfi02.c             |   2 +-
hw/block/vhost-user-blk.c           |   4 +-
hw/block/virtio-blk.c               |   4 +-
hw/block/xen-block.c                |   8 +-
hw/char/serial-pci-multi.c          |   2 +-
hw/char/serial-pci.c                |   2 +-
hw/char/serial.c                    |   2 +-
hw/char/virtio-console.c            |   2 +-
hw/char/virtio-serial-bus.c         |   8 +-
hw/core/bus.c                       |  24 +-
hw/core/cpu.c                       |   2 +-
hw/core/generic-loader.c            |   2 +-
hw/core/machine-qmp-cmds.c          |  16 +-
hw/core/machine.c                   |  87 ++---
hw/core/qdev-clock.c                |   4 +-
hw/core/qdev-properties.c           |  11 +-
hw/core/qdev.c                      |  74 ++--
hw/cpu/core.c                       |   4 +-
hw/display/bochs-display.c          |   3 +-
hw/display/sm501.c                  |   2 +-
hw/display/vga-pci.c                |   4 +-
hw/display/vhost-user-gpu-pci.c     |   3 +-
hw/display/vhost-user-gpu.c         |   2 +-
hw/display/vhost-user-vga.c         |   3 +-
hw/display/virtio-gpu-base.c        |   2 +-
hw/display/xlnx_dp.c                |   7 +-
hw/dma/rc4030.c                     |   2 +-
hw/dma/sparc32_dma.c                |  10 +-
hw/dma/xilinx_axidma.c              |   9 +-
hw/dma/xlnx-zdma.c                  |   7 +-
hw/gpio/aspeed_gpio.c               |   2 +-
hw/hyperv/hyperv.c                  |   2 +-
hw/i386/kvm/apic.c                  |   2 +-
hw/i386/microvm.c                   |  29 +-
hw/i386/pc.c                        |  18 +-
hw/i386/pc_piix.c                   |   2 +-
hw/i386/pc_q35.c                    |   4 +-
hw/i386/pc_sysfw.c                  |   7 +-
hw/i386/x86.c                       |  14 +-
hw/ide/macio.c                      |   2 +-
hw/ide/qdev.c                       |   6 +-
hw/input/vhost-user-input.c         |   2 +-
hw/input/virtio-input-hid.c         |   2 +-
hw/input/virtio-input-host.c        |   2 +-
hw/input/virtio-input.c             |   9 +-
hw/intc/apic.c                      |   2 +-
hw/intc/apic_common.c               |   6 +-
hw/intc/ioapic.c                    |   2 +-
hw/intc/s390_flic.c                 |   4 +-
hw/intc/xics.c                      |   4 +-
hw/intc/xive.c                      |   2 +-
hw/ipack/ipack.c                    |   6 +-
hw/ipmi/ipmi.c                      |   3 +-
hw/isa/isa-superio.c                |  13 +-
hw/isa/lpc_ich9.c                   |   8 +-
hw/mem/nvdimm.c                     |   4 +-
hw/mem/pc-dimm.c                    |   4 +-
hw/microblaze/petalogix_ml605_mmu.c |   6 +-
hw/misc/aspeed_sdmc.c               |   2 +-
hw/misc/edu.c                       |   3 +-
hw/misc/mac_via.c                   |   4 +-
hw/misc/macio/gpio.c                |   2 +-
hw/misc/macio/macio.c               |   4 +-
hw/misc/macio/pmu.c                 |   2 +-
hw/misc/pca9552.c                   |   2 +-
hw/misc/tmp105.c                    |   2 +-
hw/misc/tmp421.c                    |   8 +-
hw/net/cadence_gem.c                |   3 +-
hw/net/can/can_kvaser_pci.c         |   2 +-
hw/net/can/can_mioe3680_pci.c       |   4 +-
hw/net/can/can_pcm3680_pci.c        |   4 +-
hw/net/e1000.c                      |   3 +-
hw/net/e1000e.c                     |   2 +-
hw/net/eepro100.c                   |   2 +-
hw/net/lance.c                      |   2 +-
hw/net/lasi_i82596.c                |   2 +-
hw/net/ne2000-isa.c                 |   2 +-
hw/net/ne2000-pci.c                 |   2 +-
hw/net/pcnet-pci.c                  |   2 +-
hw/net/rtl8139.c                    |   2 +-
hw/net/spapr_llan.c                 |   2 +-
hw/net/sungem.c                     |   2 +-
hw/net/sunhme.c                     |   2 +-
hw/net/tulip.c                      |   2 +-
hw/net/virtio-net.c                 |   6 +-
hw/net/vmxnet3.c                    |   2 +-
hw/net/xilinx_axienet.c             |   9 +-
hw/nios2/10m50_devboard.c           |   3 +-
hw/nvram/fw_cfg.c                   |   4 +-
hw/nvram/mac_nvram.c                |   2 +-
hw/pci-host/grackle.c               |   2 +-
hw/pci-host/i440fx.c                |  12 +-
hw/pci-host/pnv_phb3_msi.c          |   3 +-
hw/pci-host/pnv_phb3_pbcq.c         |   3 +-
hw/pci-host/q35.c                   |  20 +-
hw/pci-host/sabre.c                 |   2 +-
hw/pci-host/uninorth.c              |   8 +-
hw/pci/pci.c                        |  14 +-
hw/pci/pcie.c                       |   2 +-
hw/pci/shpc.c                       |   2 +-
hw/pcmcia/pxa2xx.c                  |   2 +-
hw/ppc/e500.c                       |   8 +-
hw/ppc/mac_newworld.c               |   7 +-
hw/ppc/mac_oldworld.c               |   2 +-
hw/ppc/pnv.c                        |  16 +-
hw/ppc/pnv_bmc.c                    |   5 +-
hw/ppc/pnv_core.c                   |   4 +-
hw/ppc/pnv_psi.c                    |   2 +-
hw/ppc/prep.c                       |   6 +-
hw/ppc/spapr.c                      |  59 ++--
hw/ppc/spapr_caps.c                 |  16 +-
hw/ppc/spapr_cpu_core.c             |   7 +-
hw/ppc/spapr_drc.c                  |  36 +-
hw/ppc/spapr_iommu.c                |   4 +-
hw/ppc/spapr_irq.c                  |   2 +-
hw/ppc/spapr_pci.c                  |  98 ++----
hw/ppc/spapr_rng.c                  |   3 +-
hw/ppc/spapr_rtc.c                  |   2 +-
hw/ppc/spapr_tpm_proxy.c            |   2 +-
hw/riscv/sifive_u.c                 |  15 +-
hw/riscv/virt.c                     |   5 +-
hw/rtc/mc146818rtc.c                |   4 +-
hw/s390x/ap-bridge.c                |   2 +-
hw/s390x/css-bridge.c               |   9 +-
hw/s390x/event-facility.c           |   6 +-
hw/s390x/s390-ccw.c                 |   4 +-
hw/s390x/s390-pci-bus.c             |   4 +-
hw/s390x/s390-skeys.c               |   4 +-
hw/s390x/s390-stattrib.c            |   4 +-
hw/s390x/s390-virtio-ccw.c          |  19 +-
hw/s390x/sclp.c                     |   5 +-
hw/s390x/tod.c                      |   2 +-
hw/s390x/virtio-ccw-balloon.c       |   4 +-
hw/s390x/virtio-ccw-blk.c           |   2 +-
hw/s390x/virtio-ccw-net.c           |   2 +-
hw/s390x/virtio-ccw.c               |   8 +-
hw/scsi/lsi53c895a.c                |   2 +-
hw/scsi/scsi-bus.c                  |  17 +-
hw/scsi/scsi-disk.c                 |   2 +-
hw/scsi/vhost-scsi.c                |   4 +-
hw/scsi/vhost-user-scsi.c           |   4 +-
hw/scsi/virtio-scsi.c               |   2 +-
hw/sd/sdhci-pci.c                   |   2 +-
hw/sd/sdhci.c                       |   6 +-
hw/sparc/sun4m.c                    |   7 +-
hw/sparc64/sun4u.c                  |   2 +-
hw/ssi/xilinx_spips.c               |   3 +-
hw/usb/bus.c                        |  18 +-
hw/usb/ccid-card-emulated.c         |   2 +-
hw/usb/dev-audio.c                  |   2 +-
hw/usb/dev-hid.c                    |   2 +-
hw/usb/dev-hub.c                    |   2 +-
hw/usb/dev-network.c                |   4 +-
hw/usb/dev-smartcard-reader.c       |  11 +-
hw/usb/dev-storage.c                |   2 +-
hw/usb/dev-uas.c                    |   2 +-
hw/usb/dev-wacom.c                  |   2 +-
hw/usb/hcd-ehci-pci.c               |   2 +-
hw/usb/hcd-ehci.c                   |   2 +-
hw/usb/host-libusb.c                |   4 +-
hw/usb/redirect.c                   |   4 +-
hw/vfio/ap.c                        |   2 +-
hw/vfio/ccw.c                       |   6 +-
hw/vfio/pci-quirks.c                |   6 +-
hw/vfio/pci.c                       |   2 +-
hw/virtio/vhost-scsi-pci.c          |   2 +-
hw/virtio/vhost-user-blk-pci.c      |   2 +-
hw/virtio/vhost-user-fs.c           |   2 +-
hw/virtio/vhost-user-input-pci.c    |   3 +-
hw/virtio/vhost-user-scsi-pci.c     |   2 +-
hw/virtio/vhost-vsock.c             |   2 +-
hw/virtio/virtio-balloon-pci.c      |   4 +-
hw/virtio/virtio-balloon.c          |   6 +-
hw/virtio/virtio-blk-pci.c          |   2 +-
hw/virtio/virtio-crypto.c           |   2 +-
hw/virtio/virtio-iommu.c            |   2 +-
hw/virtio/virtio-net-pci.c          |   2 +-
hw/virtio/virtio-pmem.c             |   2 +-
hw/virtio/virtio-rng.c              |   4 +-
hw/virtio/virtio.c                  |  11 +-
hw/watchdog/wdt_diag288.c           |   2 +-
hw/xen/xen-bus.c                    |  12 +-
hw/xen/xen-common.c                 |   5 +-
iothread.c                          |   6 +-
memory.c                            |  14 +-
net/can/can_host.c                  |   3 +-
net/can/can_socketcan.c             |   3 +-
net/colo-compare.c                  |  20 +-
net/dump.c                          |   4 +-
net/filter-buffer.c                 |   2 +-
net/filter-mirror.c                 |  10 +-
net/filter-rewriter.c               |   2 +-
net/filter.c                        |  15 +-
qdev-monitor.c                      |   4 +-
qom/container.c                     |   4 +-
qom/object.c                        | 524 ++++++++++------------------
qom/object_interfaces.c             |   8 +-
scsi/pr-manager-helper.c            |   3 +-
softmmu/vl.c                        |   7 +-
target/arm/cpu.c                    |  11 +-
target/arm/cpu64.c                  |  11 +-
target/arm/kvm.c                    |   4 +-
target/i386/cpu.c                   |  92 +++--
target/i386/sev.c                   |  23 +-
target/ppc/compat.c                 |  14 +-
target/ppc/translate_init.inc.c     |   9 +-
target/s390x/cpu.c                  |   2 +-
target/s390x/cpu_models.c           |  15 +-
tests/check-qom-proplist.c          |  70 ++--
tests/test-qdev-global-props.c      |   4 +-
ui/console.c                        |   7 +-
ui/input-barrier.c                  |  14 +-
ui/input-linux.c                    |   8 +-
290 files changed, 1137 insertions(+), 1648 deletions(-)
[PATCH v2 00/18] qom: Spring cleaning
Posted by Markus Armbruster 3 years, 12 months ago
Includes one actual bug fix for s390x.

v2:
* Rebased, conflicts in PATCH 07+14 resolved
* New "[PATCH v2 04/18] qom: Simplify object_property_get_enum()"
* Old "[PATCH 04/17] qom: Change object_property_get_uint16List() to
  match its doc" replaced by new "[PATCH v2 05/18] qom: Drop convenience method
  object_property_get_uint16List()"
* PATCH 08: commit message improved [David]
* PATCH 18: commit message improved [Eric]

Markus Armbruster (18):
  qom: Clearer reference counting in object_initialize_childv()
  qom: Clean up inconsistent use of gchar * vs. char *
  qom: Drop object_property_del_child()'s unused parameter @errp
  qom: Simplify object_property_get_enum()
  qom: Drop convenience method object_property_get_uint16List()
  qom: Make all the object_property_add_FOO() return the property
  qom: Drop object_property_set_description() parameter @errp
  tests/check-qom-proplist: Improve iterator coverage
  s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes,eaes}-256
  hw/isa/superio: Make the components QOM children
  e1000: Don't run e1000_instance_init() twice
  hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
  qdev: Clean up qdev_connect_gpio_out_named()
  qom: Drop parameter @errp of object_property_add() & friends
  Drop more @errp parameters after previous commit
  qdev: Unrealize must not fail
  spapr_pci: Drop some dead error handling
  qom: Drop @errp parameter of object_property_del()

 hw/9pfs/9p.h                        |   2 +-
 hw/s390x/virtio-ccw.h               |   2 +-
 hw/sd/sdhci-internal.h              |   2 +-
 hw/usb/ccid.h                       |   2 +-
 hw/usb/hcd-ehci.h                   |   2 +-
 include/hw/acpi/ich9.h              |   2 +-
 include/hw/ppc/spapr.h              |   2 +-
 include/hw/qdev-core.h              |   6 +-
 include/hw/s390x/s390-ccw.h         |   2 +-
 include/hw/scsi/scsi.h              |   2 +-
 include/hw/usb.h                    |   2 +-
 include/hw/xen/xen-block.h          |   2 +-
 include/hw/xen/xen-bus.h            |   2 +-
 include/qom/object.h                | 163 ++++-----
 include/sysemu/sysemu.h             |   2 +-
 monitor/monitor-internal.h          |   2 +-
 target/ppc/cpu.h                    |   3 +-
 target/s390x/cpu_features_def.inc.h |   2 +-
 accel/kvm/kvm-all.c                 |   8 +-
 accel/tcg/tcg-all.c                 |   7 +-
 authz/list.c                        |   5 +-
 authz/listfile.c                    |   6 +-
 authz/pamacct.c                     |   3 +-
 authz/simple.c                      |   3 +-
 backends/cryptodev-vhost-user.c     |   3 +-
 backends/cryptodev.c                |   2 +-
 backends/dbus-vmstate.c             |   6 +-
 backends/hostmem-file.c             |  11 +-
 backends/hostmem-memfd.c            |  17 +-
 backends/hostmem.c                  |  35 +-
 backends/rng-egd.c                  |   3 +-
 backends/rng-random.c               |   3 +-
 backends/rng.c                      |   3 +-
 backends/vhost-user.c               |   2 +-
 block/throttle-groups.c             |   6 +-
 bootdevice.c                        |  10 +-
 chardev/char-socket.c               |   4 +-
 chardev/char.c                      |   7 +-
 crypto/secret.c                     |  18 +-
 crypto/tlscreds.c                   |  12 +-
 crypto/tlscredsanon.c               |   3 +-
 crypto/tlscredspsk.c                |   6 +-
 crypto/tlscredsx509.c               |   9 +-
 hw/9pfs/9p.c                        |   4 +-
 hw/9pfs/virtio-9p-device.c          |   4 +-
 hw/acpi/ich9.c                      |  25 +-
 hw/acpi/pcihp.c                     |   9 +-
 hw/acpi/piix4.c                     |  15 +-
 hw/arm/allwinner-a10.c              |   2 +-
 hw/arm/allwinner-h3.c               |  12 +-
 hw/arm/armv7m.c                     |   2 +-
 hw/arm/aspeed.c                     |   4 +-
 hw/arm/aspeed_ast2600.c             |  13 +-
 hw/arm/aspeed_soc.c                 |  13 +-
 hw/arm/bcm2835_peripherals.c        |  28 +-
 hw/arm/bcm2836.c                    |  16 +-
 hw/arm/cubieboard.c                 |   3 +-
 hw/arm/mcimx6ul-evk.c               |   2 +-
 hw/arm/mcimx7d-sabre.c              |   2 +-
 hw/arm/msf2-soc.c                   |   3 +-
 hw/arm/nrf51_soc.c                  |   3 +-
 hw/arm/orangepi.c                   |   3 +-
 hw/arm/raspi.c                      |   3 +-
 hw/arm/sabrelite.c                  |   2 +-
 hw/arm/sbsa-ref.c                   |   5 +-
 hw/arm/vexpress.c                   |  10 +-
 hw/arm/virt.c                       |  39 +--
 hw/arm/xilinx_zynq.c                |   2 +-
 hw/arm/xlnx-versal-virt.c           |   6 +-
 hw/arm/xlnx-versal.c                |   2 +-
 hw/arm/xlnx-zcu102.c                |  10 +-
 hw/arm/xlnx-zynqmp.c                |   9 +-
 hw/audio/intel-hda.c                |   2 +-
 hw/audio/marvell_88w8618.c          |   2 +-
 hw/audio/pcspk.c                    |   2 +-
 hw/block/fdc.c                      |   4 +-
 hw/block/nvme.c                     |   2 +-
 hw/block/pflash_cfi02.c             |   2 +-
 hw/block/vhost-user-blk.c           |   4 +-
 hw/block/virtio-blk.c               |   4 +-
 hw/block/xen-block.c                |   8 +-
 hw/char/serial-pci-multi.c          |   2 +-
 hw/char/serial-pci.c                |   2 +-
 hw/char/serial.c                    |   2 +-
 hw/char/virtio-console.c            |   2 +-
 hw/char/virtio-serial-bus.c         |   8 +-
 hw/core/bus.c                       |  24 +-
 hw/core/cpu.c                       |   2 +-
 hw/core/generic-loader.c            |   2 +-
 hw/core/machine-qmp-cmds.c          |  16 +-
 hw/core/machine.c                   |  87 ++---
 hw/core/qdev-clock.c                |   4 +-
 hw/core/qdev-properties.c           |  11 +-
 hw/core/qdev.c                      |  74 ++--
 hw/cpu/core.c                       |   4 +-
 hw/display/bochs-display.c          |   3 +-
 hw/display/sm501.c                  |   2 +-
 hw/display/vga-pci.c                |   4 +-
 hw/display/vhost-user-gpu-pci.c     |   3 +-
 hw/display/vhost-user-gpu.c         |   2 +-
 hw/display/vhost-user-vga.c         |   3 +-
 hw/display/virtio-gpu-base.c        |   2 +-
 hw/display/xlnx_dp.c                |   7 +-
 hw/dma/rc4030.c                     |   2 +-
 hw/dma/sparc32_dma.c                |  10 +-
 hw/dma/xilinx_axidma.c              |   9 +-
 hw/dma/xlnx-zdma.c                  |   7 +-
 hw/gpio/aspeed_gpio.c               |   2 +-
 hw/hyperv/hyperv.c                  |   2 +-
 hw/i386/kvm/apic.c                  |   2 +-
 hw/i386/microvm.c                   |  29 +-
 hw/i386/pc.c                        |  18 +-
 hw/i386/pc_piix.c                   |   2 +-
 hw/i386/pc_q35.c                    |   4 +-
 hw/i386/pc_sysfw.c                  |   7 +-
 hw/i386/x86.c                       |  14 +-
 hw/ide/macio.c                      |   2 +-
 hw/ide/qdev.c                       |   6 +-
 hw/input/vhost-user-input.c         |   2 +-
 hw/input/virtio-input-hid.c         |   2 +-
 hw/input/virtio-input-host.c        |   2 +-
 hw/input/virtio-input.c             |   9 +-
 hw/intc/apic.c                      |   2 +-
 hw/intc/apic_common.c               |   6 +-
 hw/intc/ioapic.c                    |   2 +-
 hw/intc/s390_flic.c                 |   4 +-
 hw/intc/xics.c                      |   4 +-
 hw/intc/xive.c                      |   2 +-
 hw/ipack/ipack.c                    |   6 +-
 hw/ipmi/ipmi.c                      |   3 +-
 hw/isa/isa-superio.c                |  13 +-
 hw/isa/lpc_ich9.c                   |   8 +-
 hw/mem/nvdimm.c                     |   4 +-
 hw/mem/pc-dimm.c                    |   4 +-
 hw/microblaze/petalogix_ml605_mmu.c |   6 +-
 hw/misc/aspeed_sdmc.c               |   2 +-
 hw/misc/edu.c                       |   3 +-
 hw/misc/mac_via.c                   |   4 +-
 hw/misc/macio/gpio.c                |   2 +-
 hw/misc/macio/macio.c               |   4 +-
 hw/misc/macio/pmu.c                 |   2 +-
 hw/misc/pca9552.c                   |   2 +-
 hw/misc/tmp105.c                    |   2 +-
 hw/misc/tmp421.c                    |   8 +-
 hw/net/cadence_gem.c                |   3 +-
 hw/net/can/can_kvaser_pci.c         |   2 +-
 hw/net/can/can_mioe3680_pci.c       |   4 +-
 hw/net/can/can_pcm3680_pci.c        |   4 +-
 hw/net/e1000.c                      |   3 +-
 hw/net/e1000e.c                     |   2 +-
 hw/net/eepro100.c                   |   2 +-
 hw/net/lance.c                      |   2 +-
 hw/net/lasi_i82596.c                |   2 +-
 hw/net/ne2000-isa.c                 |   2 +-
 hw/net/ne2000-pci.c                 |   2 +-
 hw/net/pcnet-pci.c                  |   2 +-
 hw/net/rtl8139.c                    |   2 +-
 hw/net/spapr_llan.c                 |   2 +-
 hw/net/sungem.c                     |   2 +-
 hw/net/sunhme.c                     |   2 +-
 hw/net/tulip.c                      |   2 +-
 hw/net/virtio-net.c                 |   6 +-
 hw/net/vmxnet3.c                    |   2 +-
 hw/net/xilinx_axienet.c             |   9 +-
 hw/nios2/10m50_devboard.c           |   3 +-
 hw/nvram/fw_cfg.c                   |   4 +-
 hw/nvram/mac_nvram.c                |   2 +-
 hw/pci-host/grackle.c               |   2 +-
 hw/pci-host/i440fx.c                |  12 +-
 hw/pci-host/pnv_phb3_msi.c          |   3 +-
 hw/pci-host/pnv_phb3_pbcq.c         |   3 +-
 hw/pci-host/q35.c                   |  20 +-
 hw/pci-host/sabre.c                 |   2 +-
 hw/pci-host/uninorth.c              |   8 +-
 hw/pci/pci.c                        |  14 +-
 hw/pci/pcie.c                       |   2 +-
 hw/pci/shpc.c                       |   2 +-
 hw/pcmcia/pxa2xx.c                  |   2 +-
 hw/ppc/e500.c                       |   8 +-
 hw/ppc/mac_newworld.c               |   7 +-
 hw/ppc/mac_oldworld.c               |   2 +-
 hw/ppc/pnv.c                        |  16 +-
 hw/ppc/pnv_bmc.c                    |   5 +-
 hw/ppc/pnv_core.c                   |   4 +-
 hw/ppc/pnv_psi.c                    |   2 +-
 hw/ppc/prep.c                       |   6 +-
 hw/ppc/spapr.c                      |  59 ++--
 hw/ppc/spapr_caps.c                 |  16 +-
 hw/ppc/spapr_cpu_core.c             |   7 +-
 hw/ppc/spapr_drc.c                  |  36 +-
 hw/ppc/spapr_iommu.c                |   4 +-
 hw/ppc/spapr_irq.c                  |   2 +-
 hw/ppc/spapr_pci.c                  |  98 ++----
 hw/ppc/spapr_rng.c                  |   3 +-
 hw/ppc/spapr_rtc.c                  |   2 +-
 hw/ppc/spapr_tpm_proxy.c            |   2 +-
 hw/riscv/sifive_u.c                 |  15 +-
 hw/riscv/virt.c                     |   5 +-
 hw/rtc/mc146818rtc.c                |   4 +-
 hw/s390x/ap-bridge.c                |   2 +-
 hw/s390x/css-bridge.c               |   9 +-
 hw/s390x/event-facility.c           |   6 +-
 hw/s390x/s390-ccw.c                 |   4 +-
 hw/s390x/s390-pci-bus.c             |   4 +-
 hw/s390x/s390-skeys.c               |   4 +-
 hw/s390x/s390-stattrib.c            |   4 +-
 hw/s390x/s390-virtio-ccw.c          |  19 +-
 hw/s390x/sclp.c                     |   5 +-
 hw/s390x/tod.c                      |   2 +-
 hw/s390x/virtio-ccw-balloon.c       |   4 +-
 hw/s390x/virtio-ccw-blk.c           |   2 +-
 hw/s390x/virtio-ccw-net.c           |   2 +-
 hw/s390x/virtio-ccw.c               |   8 +-
 hw/scsi/lsi53c895a.c                |   2 +-
 hw/scsi/scsi-bus.c                  |  17 +-
 hw/scsi/scsi-disk.c                 |   2 +-
 hw/scsi/vhost-scsi.c                |   4 +-
 hw/scsi/vhost-user-scsi.c           |   4 +-
 hw/scsi/virtio-scsi.c               |   2 +-
 hw/sd/sdhci-pci.c                   |   2 +-
 hw/sd/sdhci.c                       |   6 +-
 hw/sparc/sun4m.c                    |   7 +-
 hw/sparc64/sun4u.c                  |   2 +-
 hw/ssi/xilinx_spips.c               |   3 +-
 hw/usb/bus.c                        |  18 +-
 hw/usb/ccid-card-emulated.c         |   2 +-
 hw/usb/dev-audio.c                  |   2 +-
 hw/usb/dev-hid.c                    |   2 +-
 hw/usb/dev-hub.c                    |   2 +-
 hw/usb/dev-network.c                |   4 +-
 hw/usb/dev-smartcard-reader.c       |  11 +-
 hw/usb/dev-storage.c                |   2 +-
 hw/usb/dev-uas.c                    |   2 +-
 hw/usb/dev-wacom.c                  |   2 +-
 hw/usb/hcd-ehci-pci.c               |   2 +-
 hw/usb/hcd-ehci.c                   |   2 +-
 hw/usb/host-libusb.c                |   4 +-
 hw/usb/redirect.c                   |   4 +-
 hw/vfio/ap.c                        |   2 +-
 hw/vfio/ccw.c                       |   6 +-
 hw/vfio/pci-quirks.c                |   6 +-
 hw/vfio/pci.c                       |   2 +-
 hw/virtio/vhost-scsi-pci.c          |   2 +-
 hw/virtio/vhost-user-blk-pci.c      |   2 +-
 hw/virtio/vhost-user-fs.c           |   2 +-
 hw/virtio/vhost-user-input-pci.c    |   3 +-
 hw/virtio/vhost-user-scsi-pci.c     |   2 +-
 hw/virtio/vhost-vsock.c             |   2 +-
 hw/virtio/virtio-balloon-pci.c      |   4 +-
 hw/virtio/virtio-balloon.c          |   6 +-
 hw/virtio/virtio-blk-pci.c          |   2 +-
 hw/virtio/virtio-crypto.c           |   2 +-
 hw/virtio/virtio-iommu.c            |   2 +-
 hw/virtio/virtio-net-pci.c          |   2 +-
 hw/virtio/virtio-pmem.c             |   2 +-
 hw/virtio/virtio-rng.c              |   4 +-
 hw/virtio/virtio.c                  |  11 +-
 hw/watchdog/wdt_diag288.c           |   2 +-
 hw/xen/xen-bus.c                    |  12 +-
 hw/xen/xen-common.c                 |   5 +-
 iothread.c                          |   6 +-
 memory.c                            |  14 +-
 net/can/can_host.c                  |   3 +-
 net/can/can_socketcan.c             |   3 +-
 net/colo-compare.c                  |  20 +-
 net/dump.c                          |   4 +-
 net/filter-buffer.c                 |   2 +-
 net/filter-mirror.c                 |  10 +-
 net/filter-rewriter.c               |   2 +-
 net/filter.c                        |  15 +-
 qdev-monitor.c                      |   4 +-
 qom/container.c                     |   4 +-
 qom/object.c                        | 524 ++++++++++------------------
 qom/object_interfaces.c             |   8 +-
 scsi/pr-manager-helper.c            |   3 +-
 softmmu/vl.c                        |   7 +-
 target/arm/cpu.c                    |  11 +-
 target/arm/cpu64.c                  |  11 +-
 target/arm/kvm.c                    |   4 +-
 target/i386/cpu.c                   |  92 +++--
 target/i386/sev.c                   |  23 +-
 target/ppc/compat.c                 |  14 +-
 target/ppc/translate_init.inc.c     |   9 +-
 target/s390x/cpu.c                  |   2 +-
 target/s390x/cpu_models.c           |  15 +-
 tests/check-qom-proplist.c          |  70 ++--
 tests/test-qdev-global-props.c      |   4 +-
 ui/console.c                        |   7 +-
 ui/input-barrier.c                  |  14 +-
 ui/input-linux.c                    |   8 +-
 290 files changed, 1137 insertions(+), 1648 deletions(-)

-- 
2.21.1


Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
beb6c50 qom: Drop @errp parameter of object_property_del()
d0d55e6 spapr_pci: Drop some dead error handling
ec2df94 qdev: Unrealize must not fail
5b8de9e Drop more @errp parameters after previous commit
edf94c6 qom: Drop parameter @errp of object_property_add() & friends
6ff8f7d qdev: Clean up qdev_connect_gpio_out_named()
46da334 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
6a5bc55 e1000: Don't run e1000_instance_init() twice
c4844bd hw/isa/superio: Make the components QOM children
7be19fd s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
d09d20e tests/check-qom-proplist: Improve iterator coverage
548a3c9 qom: Drop object_property_set_description() parameter @errp
ac198ff qom: Make all the object_property_add_FOO() return the property
66c5d26 qom: Drop convenience method object_property_get_uint16List()
4853b5b qom: Simplify object_property_get_enum()
4f9c21f qom: Drop object_property_del_child()'s unused parameter @errp
b9913e2 qom: Clean up inconsistent use of gchar * vs. char *
050e01e qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 050e01e9c03d (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit b9913e2e09ab (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit 4f9c21f8e769 (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit 4853b5ba881d (qom: Simplify object_property_get_enum())
5/18 Checking commit 66c5d264f12d (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit ac198ffe9e7a (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit 548a3c97f4bf (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit d09d20e67177 (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit 7be19fd93345 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit c4844bd223f1 (hw/isa/superio: Make the components QOM children)
11/18 Checking commit 6a5bc55a6703 (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit 46da33429c8f (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit 6ff8f7d6be67 (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit edf94c680754 (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit 5b8de9ee567a (Drop more @errp parameters after previous commit)
16/18 Checking commit ec2df94015ef (qdev: Unrealize must not fail)
17/18 Checking commit d0d55e6ba917 (spapr_pci: Drop some dead error handling)
18/18 Checking commit beb6c509cd49 (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
6d65beb qom: Drop @errp parameter of object_property_del()
458cedb spapr_pci: Drop some dead error handling
7ffb546 qdev: Unrealize must not fail
bfab387 Drop more @errp parameters after previous commit
093140a qom: Drop parameter @errp of object_property_add() & friends
7802bbe qdev: Clean up qdev_connect_gpio_out_named()
674837c hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
0c51050 e1000: Don't run e1000_instance_init() twice
0b08b0f hw/isa/superio: Make the components QOM children
ba292c0 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
059650f tests/check-qom-proplist: Improve iterator coverage
54d70f2 qom: Drop object_property_set_description() parameter @errp
e4c477d qom: Make all the object_property_add_FOO() return the property
40d45ef qom: Drop convenience method object_property_get_uint16List()
544020b qom: Simplify object_property_get_enum()
c3b9c57 qom: Drop object_property_del_child()'s unused parameter @errp
2d06cf9 qom: Clean up inconsistent use of gchar * vs. char *
452b735 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 452b735640b3 (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit 2d06cf9fbb63 (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit c3b9c571abbb (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit 544020b6690d (qom: Simplify object_property_get_enum())
5/18 Checking commit 40d45efa4a1f (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit e4c477d06477 (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit 54d70f2a2aa2 (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit 059650f6eb73 (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit ba292c0d650a (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit 0b08b0fd9725 (hw/isa/superio: Make the components QOM children)
11/18 Checking commit 0c51050ca568 (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit 674837c074d8 (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit 7802bbefdfb9 (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit 093140aa2723 (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit bfab387eb1fe (Drop more @errp parameters after previous commit)
16/18 Checking commit 7ffb54686f74 (qdev: Unrealize must not fail)
17/18 Checking commit 458cedbe9c6e (spapr_pci: Drop some dead error handling)
18/18 Checking commit 6d65beb23534 (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0bfeda6 qom: Drop @errp parameter of object_property_del()
fce53a6 spapr_pci: Drop some dead error handling
bf4fa1d qdev: Unrealize must not fail
c984f35 Drop more @errp parameters after previous commit
3217176 qom: Drop parameter @errp of object_property_add() & friends
e43f7cf qdev: Clean up qdev_connect_gpio_out_named()
25ed6da hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
2b01f96 e1000: Don't run e1000_instance_init() twice
0859a4a hw/isa/superio: Make the components QOM children
0ad9369 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
a7bcd4a tests/check-qom-proplist: Improve iterator coverage
a89bf38 qom: Drop object_property_set_description() parameter @errp
2c9507b qom: Make all the object_property_add_FOO() return the property
caeed6f qom: Drop convenience method object_property_get_uint16List()
670a5b1 qom: Simplify object_property_get_enum()
4e0ef1e qom: Drop object_property_del_child()'s unused parameter @errp
3305770 qom: Clean up inconsistent use of gchar * vs. char *
237690a qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 237690a0fd11 (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit 33057701be2e (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit 4e0ef1e4e32d (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit 670a5b17a0f5 (qom: Simplify object_property_get_enum())
5/18 Checking commit caeed6fde79c (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit 2c9507b8735b (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit a89bf3817999 (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit a7bcd4a69d42 (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit 0ad93695c816 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit 0859a4ae84dc (hw/isa/superio: Make the components QOM children)
11/18 Checking commit 2b01f963380b (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit 25ed6da2c511 (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit e43f7cf1877d (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit 321717690e42 (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit c984f35ccd32 (Drop more @errp parameters after previous commit)
16/18 Checking commit bf4fa1d40108 (qdev: Unrealize must not fail)
17/18 Checking commit fce53a6de430 (spapr_pci: Drop some dead error handling)
18/18 Checking commit 0bfeda6594be (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200505230941.3984108-1-alistair.francis@wdc.com -> patchew/20200505230941.3984108-1-alistair.francis@wdc.com
Switched to a new branch 'test'
258378d qom: Drop @errp parameter of object_property_del()
ae7803d spapr_pci: Drop some dead error handling
3867341 qdev: Unrealize must not fail
27ab964 Drop more @errp parameters after previous commit
051ab01 qom: Drop parameter @errp of object_property_add() & friends
d9987b4 qdev: Clean up qdev_connect_gpio_out_named()
4ac9492 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
576bcc1 e1000: Don't run e1000_instance_init() twice
1e343fb hw/isa/superio: Make the components QOM children
2546372 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
9feee4e tests/check-qom-proplist: Improve iterator coverage
e3f4e24 qom: Drop object_property_set_description() parameter @errp
2235c72 qom: Make all the object_property_add_FOO() return the property
4a961f6 qom: Drop convenience method object_property_get_uint16List()
a4ffec8 qom: Simplify object_property_get_enum()
30ca898 qom: Drop object_property_del_child()'s unused parameter @errp
77d819a qom: Clean up inconsistent use of gchar * vs. char *
96209f3 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 96209f39f167 (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit 77d819acbc03 (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit 30ca898bb7dc (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit a4ffec863b8d (qom: Simplify object_property_get_enum())
5/18 Checking commit 4a961f67af22 (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit 2235c72d45a6 (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit e3f4e24ddb2e (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit 9feee4e3da40 (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit 2546372e6e85 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit 1e343fbe99af (hw/isa/superio: Make the components QOM children)
11/18 Checking commit 576bcc126dca (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit 4ac949293617 (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit d9987b49f373 (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit 051ab01ed5fe (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit 27ab9642f5b9 (Drop more @errp parameters after previous commit)
16/18 Checking commit 386734149793 (qdev: Unrealize must not fail)
17/18 Checking commit ae7803d737f4 (spapr_pci: Drop some dead error handling)
18/18 Checking commit 258378dd975d (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
b6bd21f qom: Drop @errp parameter of object_property_del()
f308ad4 spapr_pci: Drop some dead error handling
fdb5400 qdev: Unrealize must not fail
7345bac Drop more @errp parameters after previous commit
2f039db qom: Drop parameter @errp of object_property_add() & friends
08871f2 qdev: Clean up qdev_connect_gpio_out_named()
def7ba0 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
6fd6ae5 e1000: Don't run e1000_instance_init() twice
ff6a512 hw/isa/superio: Make the components QOM children
93b2971 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
4e28c88 tests/check-qom-proplist: Improve iterator coverage
bd33afa qom: Drop object_property_set_description() parameter @errp
b6330ad qom: Make all the object_property_add_FOO() return the property
86270ef qom: Drop convenience method object_property_get_uint16List()
3293742 qom: Simplify object_property_get_enum()
1b625f3 qom: Drop object_property_del_child()'s unused parameter @errp
3fd6f46 qom: Clean up inconsistent use of gchar * vs. char *
37691e1 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 37691e1e2c1b (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit 3fd6f465109b (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit 1b625f3ddbbc (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit 32937422d926 (qom: Simplify object_property_get_enum())
5/18 Checking commit 86270ef5b2fa (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit b6330ada2d04 (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit bd33afaebb53 (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit 4e28c881db4c (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit 93b29716cdce (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit ff6a5120e7ea (hw/isa/superio: Make the components QOM children)
11/18 Checking commit 6fd6ae533248 (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit def7ba03a1af (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit 08871f240b3a (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit 2f039db377b2 (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit 7345bac74b29 (Drop more @errp parameters after previous commit)
16/18 Checking commit fdb540093c5d (qdev: Unrealize must not fail)
17/18 Checking commit f308ad47bac3 (spapr_pci: Drop some dead error handling)
18/18 Checking commit b6bd21f2445d (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by no-reply@patchew.org 3 years, 12 months ago
Patchew URL: https://patchew.org/QEMU/20200505152926.18877-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200505152926.18877-1-armbru@redhat.com
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200505174520.CD62A3A021D@moya.office.hostfission.com -> patchew/20200505174520.CD62A3A021D@moya.office.hostfission.com
Switched to a new branch 'test'
4cba1a0 qom: Drop @errp parameter of object_property_del()
d8b7296 spapr_pci: Drop some dead error handling
f3700d4 qdev: Unrealize must not fail
f39f651 Drop more @errp parameters after previous commit
93d8e99 qom: Drop parameter @errp of object_property_add() & friends
6a392b4 qdev: Clean up qdev_connect_gpio_out_named()
6f7f8c4 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
da916a5 e1000: Don't run e1000_instance_init() twice
f2cc352 hw/isa/superio: Make the components QOM children
98ac27d s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
b88e1ea tests/check-qom-proplist: Improve iterator coverage
065d2f5 qom: Drop object_property_set_description() parameter @errp
eb48860 qom: Make all the object_property_add_FOO() return the property
9647d4a qom: Drop convenience method object_property_get_uint16List()
4f21ae5 qom: Simplify object_property_get_enum()
8bf7167 qom: Drop object_property_del_child()'s unused parameter @errp
c86c469 qom: Clean up inconsistent use of gchar * vs. char *
24a691d qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 24a691def353 (qom: Clearer reference counting in object_initialize_childv())
2/18 Checking commit c86c4696bff7 (qom: Clean up inconsistent use of gchar * vs. char *)
3/18 Checking commit 8bf71679bce1 (qom: Drop object_property_del_child()'s unused parameter @errp)
4/18 Checking commit 4f21ae5ae5ed (qom: Simplify object_property_get_enum())
5/18 Checking commit 9647d4ae16b7 (qom: Drop convenience method object_property_get_uint16List())
6/18 Checking commit eb48860a3c26 (qom: Make all the object_property_add_FOO() return the property)
7/18 Checking commit 065d2f55d1d4 (qom: Drop object_property_set_description() parameter @errp)
8/18 Checking commit b88e1ea4bc39 (tests/check-qom-proplist: Improve iterator coverage)
9/18 Checking commit 98ac27d47088 (s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit f2cc352a601b (hw/isa/superio: Make the components QOM children)
11/18 Checking commit da916a5c390b (e1000: Don't run e1000_instance_init() twice)
12/18 Checking commit 6f7f8c446ca6 (hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory)
13/18 Checking commit 6a392b4df970 (qdev: Clean up qdev_connect_gpio_out_named())
14/18 Checking commit 93d8e9905c38 (qom: Drop parameter @errp of object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit f39f6513b7a2 (Drop more @errp parameters after previous commit)
16/18 Checking commit f3700d44eab1 (qdev: Unrealize must not fail)
17/18 Checking commit d8b7296cf934 (spapr_pci: Drop some dead error handling)
18/18 Checking commit 4cba1a0de99a (qom: Drop @errp parameter of object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200505152926.18877-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by Markus Armbruster 3 years, 12 months ago
Paolo, would you like me to do the pull request myself?


Re: [PATCH v2 00/18] qom: Spring cleaning
Posted by Markus Armbruster 3 years, 11 months ago
Markus Armbruster <armbru@redhat.com> writes:

> Paolo, would you like me to do the pull request myself?

I take that as a "yes" :)

I'll throw in Philippe's "[PATCH v3 0/3] various: Remove unnecessary
casts".  Simple and amply reviewed.