hw/i386/vmport: Drop superfluous parenthesis around function typedef

[PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef

Philippe Mathieu-Daudé posted 1 patch 5 years, 6 months ago

Download mbox

Test docker-mingw@fedora passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200505142836.16903-1-philmd@redhat.com

Maintainers: "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>

hw/i386/vmport.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef

Posted by Philippe Mathieu-Daudé 5 years, 6 months ago

Drop superfluous parenthesis around VMPortReadFunc typedef
(added in d67f679d99, missed to remove when moved in e595112985).

Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/i386/vmport.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
index 47eda7a22b..a6624e3045 100644
--- a/hw/i386/vmport.h
+++ b/hw/i386/vmport.h
@@ -27,7 +27,7 @@
 
 #define TYPE_VMPORT "vmport"
 
-typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
+typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
 
 void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
 
-- 
2.21.3

Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

On 5/5/20 4:28 PM, Philippe Mathieu-Daudé wrote:
> Drop superfluous parenthesis around VMPortReadFunc typedef
> (added in d67f679d99, missed to remove when moved in e595112985).
> 
> Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  hw/i386/vmport.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
> index 47eda7a22b..a6624e3045 100644
> --- a/hw/i386/vmport.h
> +++ b/hw/i386/vmport.h
> @@ -27,7 +27,7 @@
>  
>  #define TYPE_VMPORT "vmport"
>  
> -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
> +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
>  
>  void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
>  
> 

ping?

Re: [PATCH] hw/i386/vmport: Drop superfluous parenthesis around function typedef

Posted by Eduardo Habkost 5 years, 3 months ago

On Wed, Jun 03, 2020 at 07:04:26AM +0200, Philippe Mathieu-DaudÃ© wrote:
> On 5/5/20 4:28 PM, Philippe Mathieu-DaudÃ© wrote:
> > Drop superfluous parenthesis around VMPortReadFunc typedef
> > (added in d67f679d99, missed to remove when moved in e595112985).
> > 
> > Suggested-by: Richard Henderson <richard.henderson@linaro.org>
> > Signed-off-by: Philippe Mathieu-DaudÃ© <philmd@redhat.com>
> > ---
> >  hw/i386/vmport.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/hw/i386/vmport.h b/hw/i386/vmport.h
> > index 47eda7a22b..a6624e3045 100644
> > --- a/hw/i386/vmport.h
> > +++ b/hw/i386/vmport.h
> > @@ -27,7 +27,7 @@
> >  
> >  #define TYPE_VMPORT "vmport"
> >  
> > -typedef uint32_t (VMPortReadFunc)(void *opaque, uint32_t address);
> > +typedef uint32_t VMPortReadFunc(void *opaque, uint32_t address);
> >  
> >  void vmport_register(unsigned char command, VMPortReadFunc *func, void *opaque);
> >  
> > 
> 
> ping?

Queued for 5.2.  Sorry for missing it.

-- 
Eduardo