target/arm: Remove access_el3_aa32ns_aa64any()

[PATCH v3 0/1] target/arm: Remove access_el3_aa32ns_aa64any()

Edgar E. Iglesias posted 1 patch 5 years, 6 months ago

Download series mbox

Test docker-mingw@fedora failed

Test checkpatch failed

Test asan failed

Test docker-quick@centos7 failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200505141729.31930-1-edgar.iglesias@gmail.com

Maintainers: Peter Maydell <peter.maydell@linaro.org>

target/arm/helper.c | 30 +++++++-----------------------
1 file changed, 7 insertions(+), 23 deletions(-)

Expand all Fold all

[PATCH v3 0/1] target/arm: Remove access_el3_aa32ns_aa64any()

Posted by Edgar E. Iglesias 5 years, 6 months ago

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Hi,

Laurent reported hitting the assert in access_el3_aa32ns()
when accessing 32-bit versions of some of the virtualization
regs when EL3 is 64-bit.

I think we got this wrong back then and it seems to me like
we should merge access_el3_aa32ns and access_el3_aa32ns_aa64_any()
and always call the merged function to handle both aa32-only cases
and mixed aa32/aa64.

Cheers,
Edgar

ChangeLog:

v2 -> v3:
* Update commit message and cover letter to reflect that
  access_el3_aa32ns_aa64any is now being removed

v1 -> v2:
* Keep access_el3_aa32ns in favor of access_el3_aa32ns_aa64any
* Simplify description of access_el3_aa32ns
* Tweak secure aa32-el3 check in access_el3_aa32ns as suggested by Peter


Edgar E. Iglesias (1):
  target/arm: Drop access_el3_aa32ns_aa64any()

 target/arm/helper.c | 30 +++++++-----------------------
 1 file changed, 7 insertions(+), 23 deletions(-)

-- 
2.20.1

Re: [PATCH v3 0/1] target/arm: Remove access_el3_aa32ns_aa64any()

Posted by Peter Maydell 5 years, 6 months ago

On Tue, 5 May 2020 at 15:17, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Hi,
>
> Laurent reported hitting the assert in access_el3_aa32ns()
> when accessing 32-bit versions of some of the virtualization
> regs when EL3 is 64-bit.
>
> I think we got this wrong back then and it seems to me like
> we should merge access_el3_aa32ns and access_el3_aa32ns_aa64_any()
> and always call the merged function to handle both aa32-only cases
> and mixed aa32/aa64.



Applied to target-arm.next, thanks.

-- PMM