checkpatch: fix handling of acpi expected files

[PATCH 0/2] checkpatch: fix handling of acpi expected files

Michael S. Tsirkin posted 2 patches 4 years ago

Download series mbox

Test docker-mingw@fedora failed

Test asan failed

Test checkpatch failed

Test docker-quick@centos7 failed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200504115848.34410-1-mst@redhat.com

scripts/checkpatch.pl | 33 ++++++++++++++++++---------------
1 file changed, 18 insertions(+), 15 deletions(-)

Expand all Fold all

[PATCH 0/2] checkpatch: fix handling of acpi expected files

Posted by Michael S. Tsirkin 4 years ago

Fix a couple of bugs that surfaced.

Michael S. Tsirkin (2):
  checkpatch: fix acpi check with multiple file name
  checkpatch: ignore allowed diff list

 scripts/checkpatch.pl | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)

-- 
MST

Re: [PATCH 0/2] checkpatch: fix handling of acpi expected files

Posted by no-reply@patchew.org 4 years ago

Patchew URL: https://patchew.org/QEMU/20200504115848.34410-1-mst@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200504115848.34410-1-mst@redhat.com
Subject: [PATCH 0/2] checkpatch: fix handling of acpi expected files
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
0f382d2 checkpatch: ignore allowed diff list
ba77a3e checkpatch: fix acpi check with multiple file name

=== OUTPUT BEGIN ===
1/2 Checking commit ba77a3ef0c54 (checkpatch: fix acpi check with multiple file name)
ERROR: line over 90 characters
#74: FILE: scripts/checkpatch.pl:1459:
+                       checkfilename($realfile, \$acpi_testexpected, \$acpi_nontestexpected);

ERROR: line over 90 characters
#79: FILE: scripts/checkpatch.pl:1463:
+                       checkfilename($realfile, \$acpi_testexpected, \$acpi_nontestexpected);

total: 2 errors, 0 warnings, 58 lines checked

Patch 1/2 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/2 Checking commit 0f382d20ef00 (checkpatch: ignore allowed diff list)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200504115848.34410-1-mst@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com