[PATCH] hw/ide/ahci: Log lost IRQs

Philippe Mathieu-Daudé posted 1 patch 4 years ago
Test docker-mingw@fedora passed
Test checkpatch passed
Test asan passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200504094858.5975-1-f4bug@amsat.org
hw/ide/ahci.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] hw/ide/ahci: Log lost IRQs
Posted by Philippe Mathieu-Daudé 4 years ago
One might find interesting to look at AHCI IRQs.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/ide/ahci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 13d91e109a..fc82cbd5f1 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
 
 static void ahci_irq_set(void *opaque, int n, int level)
 {
+    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
 }
 
 static const IDEDMAOps ahci_dma_ops = {
-- 
2.21.3


Re: [PATCH] hw/ide/ahci: Log lost IRQs
Posted by Philippe Mathieu-Daudé 3 years, 11 months ago
ping?

On 5/4/20 11:48 AM, Philippe Mathieu-Daudé wrote:
> One might find interesting to look at AHCI IRQs.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   hw/ide/ahci.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 13d91e109a..fc82cbd5f1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
>   
>   static void ahci_irq_set(void *opaque, int n, int level)
>   {
> +    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
>   }
>   
>   static const IDEDMAOps ahci_dma_ops = {
> 

Re: [PATCH] hw/ide/ahci: Log lost IRQs
Posted by John Snow 3 years, 11 months ago

On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> One might find interesting to look at AHCI IRQs.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  hw/ide/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 13d91e109a..fc82cbd5f1 100644
> --- a/hw/ide/ahci.c
> +++ b/hw/ide/ahci.c
> @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
>  
>  static void ahci_irq_set(void *opaque, int n, int level)
>  {
> +    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
>  }
>  
>  static const IDEDMAOps ahci_dma_ops = {
> 

Reviewed-by: John Snow <jsnow@redhat.com>

Sorry, just drowning in backlog. Thanks for the ping on IRC.

Acked-by: John Snow <jsnow@redhat.com>

^ Feel free to take through trivial tree.

--js


Re: [PATCH] hw/ide/ahci: Log lost IRQs
Posted by Kevin Wolf 3 years, 11 months ago
Am 14.05.2020 um 22:20 hat John Snow geschrieben:
> 
> 
> On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> > One might find interesting to look at AHCI IRQs.
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  hw/ide/ahci.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> > index 13d91e109a..fc82cbd5f1 100644
> > --- a/hw/ide/ahci.c
> > +++ b/hw/ide/ahci.c
> > @@ -1509,6 +1509,7 @@ static void ahci_cmd_done(IDEDMA *dma)
> >  
> >  static void ahci_irq_set(void *opaque, int n, int level)
> >  {
> > +    qemu_log_mask(LOG_UNIMP, "ahci: IRQ#%d level:%d\n", n, level);
> >  }
> >  
> >  static const IDEDMAOps ahci_dma_ops = {
> > 
> 
> Reviewed-by: John Snow <jsnow@redhat.com>
> 
> Sorry, just drowning in backlog. Thanks for the ping on IRC.
> 
> Acked-by: John Snow <jsnow@redhat.com>
> 
> ^ Feel free to take through trivial tree.

I'll take it through the block tree then.

Kevin