1. Patchew
  2. QEMU
  3. [PATCH v2 0/3] scripts: More Python fixes
  4. View patch

[PATCH v2 1/3] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section

Philippe Mathieu-Daudé posted 3 patches 5 years, 6 months ago
There is a newer version of this series
[PATCH v2 1/3] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago 
Keep an eye on these "same same, but different" files.

Acked-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 8cbc1fac2b..7a7f2b9c31 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2083,6 +2083,7 @@ R: Philippe Mathieu-Daudé <philmd@redhat.com>
 S: Maintained
 F: gdbstub*
 F: gdb-xml/
+F: scripts/qemugdb/
 
 Memory API
 M: Paolo Bonzini <pbonzini@redhat.com>
-- 
2.21.1
Re: [PATCH v2 1/3] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section
Posted by Kevin Wolf 5 years, 6 months ago 
Am 30.04.2020 um 08:57 hat Philippe Mathieu-Daudé geschrieben:
> Keep an eye on these "same same, but different" files.
> 
> Acked-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8cbc1fac2b..7a7f2b9c31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2083,6 +2083,7 @@ R: Philippe Mathieu-Daudé <philmd@redhat.com>
>  S: Maintained
>  F: gdbstub*
>  F: gdb-xml/
> +F: scripts/qemugdb/

Wouldn't it make sense to add scripts/qemu-gdb.py as well?

Kevin
Re: [PATCH v2 1/3] MAINTAINERS: Cover the GDB Python scripts in the gdbstub section
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago 
On 4/30/20 9:59 AM, Kevin Wolf wrote:
> Am 30.04.2020 um 08:57 hat Philippe Mathieu-Daudé geschrieben:
>> Keep an eye on these "same same, but different" files.
>>
>> Acked-by: Alex Bennée <alex.bennee@linaro.org>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>>   MAINTAINERS | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index 8cbc1fac2b..7a7f2b9c31 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -2083,6 +2083,7 @@ R: Philippe Mathieu-Daudé <philmd@redhat.com>
>>   S: Maintained
>>   F: gdbstub*
>>   F: gdb-xml/
>> +F: scripts/qemugdb/
> 
> Wouldn't it make sense to add scripts/qemu-gdb.py as well?

I agree scripts/qemu-gdb.py with scripts/qemugdb/*py, but now looking at 
the files closely I don't think they belong to the gdbstub section (GDB 
protocol, with no knowledge of Python), and rather deserve a new section 
(GDB Python scripts, with no knowledge of GDB protocol).

I am discarding this patch.

Regards,

Phil.

> 
> Kevin
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.