More truncate improvements

[PATCH 4/9] rbd: Support BDRV_REQ_ZERO_WRITE for truncate

Eric Blake posted 9 patches 5 years, 9 months ago

Download mbox

Maintainers: Peter Lieven <pl@kamp.de>, "Denis V. Lunev" <den@openvz.org>, Stefan Weil <sw@weilnetz.de>, Jason Dillaman <dillaman@redhat.com>, Max Reitz <mreitz@redhat.com>, Jeff Cody <codyprime@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Liu Yuan <namei.unix@gmail.com>, "Richard W.M. Jones" <rjones@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Expand all Fold all

[PATCH 4/9] rbd: Support BDRV_REQ_ZERO_WRITE for truncate

Posted by Eric Blake 5 years, 9 months ago

Our .bdrv_has_zero_init_truncate always returns 1 because rbd always
0-fills; we can use that same knowledge to implement
BDRV_REQ_ZERO_WRITE by ignoring it.

Signed-off-by: Eric Blake <eblake@redhat.com>
---
 block/rbd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/block/rbd.c b/block/rbd.c
index f2d52091c702..331c45adb2b2 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -817,6 +817,9 @@ static int qemu_rbd_open(BlockDriverState *bs, QDict *options, int flags,
         }
     }

+    /* When extending regular files, we get zeros from the OS */
+    bs->supported_truncate_flags = BDRV_REQ_ZERO_WRITE;
+
     r = 0;
     goto out;

-- 
2.26.2