[v1] qapi: Spring cleaning

[PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract

Posted by Markus Armbruster 5 years, 9 months ago

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/qapi/visitor.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index 7f63e4c381..c5d0ce9184 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -345,9 +345,9 @@ void visit_end_struct(Visitor *v, void **obj);
  * input visitors set *@list to NULL.
  *
  * After visit_start_list() succeeds, the caller may visit its members
- * one after the other.  A real visit (where @obj is non-NULL) uses
+ * one after the other.  A real visit (where @list is non-NULL) uses
  * visit_next_list() for traversing the linked list, while a virtual
- * visit (where @obj is NULL) uses other means.  For each list
+ * visit (where @list is NULL) uses other means.  For each list
  * element, call the appropriate visit_type_FOO() with name set to
  * NULL and obj set to the address of the value member of the list
  * element.  Finally, visit_end_list() needs to be called with the
-- 
2.21.1

Re: [PATCH 03/13] qapi: Fix typo in visit_start_list()'s contract

Posted by Eric Blake 5 years, 9 months ago

On 4/23/20 11:00 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   include/qapi/visitor.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Too much copy-and-paste in the original ;)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
> index 7f63e4c381..c5d0ce9184 100644
> --- a/include/qapi/visitor.h
> +++ b/include/qapi/visitor.h
> @@ -345,9 +345,9 @@ void visit_end_struct(Visitor *v, void **obj);
>    * input visitors set *@list to NULL.
>    *
>    * After visit_start_list() succeeds, the caller may visit its members
> - * one after the other.  A real visit (where @obj is non-NULL) uses
> + * one after the other.  A real visit (where @list is non-NULL) uses
>    * visit_next_list() for traversing the linked list, while a virtual
> - * visit (where @obj is NULL) uses other means.  For each list
> + * visit (where @list is NULL) uses other means.  For each list
>    * element, call the appropriate visit_type_FOO() with name set to
>    * NULL and obj set to the address of the value member of the list
>    * element.  Finally, visit_end_list() needs to be called with the
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org