[PATCH v2 0/4] smbus: SPD fixes

Markus Armbruster posted 4 patches 4 years ago
Test docker-quick@centos7 passed
Test docker-mingw@fedora passed
Test checkpatch failed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200422134815.1584-1-armbru@redhat.com
Maintainers: David Gibson <david@gibson.dropbear.id.au>, Corey Minyard <cminyard@mvista.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, BALATON Zoltan <balaton@eik.bme.hu>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
include/hw/i2c/smbus_eeprom.h |  2 +-
hw/i2c/smbus_eeprom.c         | 32 +++++---------------------------
hw/mips/mips_fulong2e.c       | 10 ++--------
hw/ppc/ppc4xx_devs.c          |  8 ++++----
hw/ppc/sam460ex.c             | 13 ++++---------
5 files changed, 16 insertions(+), 49 deletions(-)
[PATCH v2 0/4] smbus: SPD fixes
Posted by Markus Armbruster 4 years ago
v2:
* PATCH 1: Do not revert commit 08fd99179a's silent change of memory
  type [Zoltan]
* PATCH 3: Improve error message some more [Philippe]

Markus Armbruster (4):
  sam460ex: Suppress useless warning on -m 32 and -m 64
  smbus: Fix spd_data_generate() error API violation
  bamboo, sam460ex: Tidy up error message for unsupported RAM size
  smbus: Fix spd_data_generate() for number of banks > 2

 include/hw/i2c/smbus_eeprom.h |  2 +-
 hw/i2c/smbus_eeprom.c         | 32 +++++---------------------------
 hw/mips/mips_fulong2e.c       | 10 ++--------
 hw/ppc/ppc4xx_devs.c          |  8 ++++----
 hw/ppc/sam460ex.c             | 13 ++++---------
 5 files changed, 16 insertions(+), 49 deletions(-)

-- 
2.21.1


Re: [PATCH v2 0/4] smbus: SPD fixes
Posted by no-reply@patchew.org 4 years ago
Patchew URL: https://patchew.org/QEMU/20200422134815.1584-1-armbru@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH v2 0/4] smbus: SPD fixes
Message-id: 20200422134815.1584-1-armbru@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   7769c23..ee573f5  master     -> master
 - [tag update]      patchew/20200421122236.24867-1-f4bug@amsat.org -> patchew/20200421122236.24867-1-f4bug@amsat.org
 - [tag update]      patchew/20200422011722.13287-1-richard.henderson@linaro.org -> patchew/20200422011722.13287-1-richard.henderson@linaro.org
 - [tag update]      patchew/20200422100211.30614-1-kraxel@redhat.com -> patchew/20200422100211.30614-1-kraxel@redhat.com
 - [tag update]      patchew/20200422124501.28015-1-peter.maydell@linaro.org -> patchew/20200422124501.28015-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200422171305.10923-1-jonathan.derrick@intel.com -> patchew/20200422171305.10923-1-jonathan.derrick@intel.com
 * [new tag]         patchew/20200422172351.26583-1-pbonzini@redhat.com -> patchew/20200422172351.26583-1-pbonzini@redhat.com
Switched to a new branch 'test'
d2614d2 smbus: Fix spd_data_generate() for number of banks > 2
1156589 bamboo, sam460ex: Tidy up error message for unsupported RAM size
fcdd256 smbus: Fix spd_data_generate() error API violation
4de6998 sam460ex: Suppress useless warning on -m 32 and -m 64

=== OUTPUT BEGIN ===
1/4 Checking commit 4de6998f69d4 (sam460ex: Suppress useless warning on -m 32 and -m 64)
2/4 Checking commit fcdd25692f49 (smbus: Fix spd_data_generate() error API violation)
3/4 Checking commit 1156589650a7 (bamboo, sam460ex: Tidy up error message for unsupported RAM size)
ERROR: unnecessary whitespace before a quoted newline
#37: FILE: hw/ppc/ppc4xx_devs.c:723:
+        error_printf("Possible valid RAM size: %" PRIi64 " MiB \n",

total: 1 errors, 0 warnings, 15 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit d2614d2e379d (smbus: Fix spd_data_generate() for number of banks > 2)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200422134815.1584-1-armbru@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH v2 0/4] smbus: SPD fixes
Posted by Markus Armbruster 4 years ago
Queued.