[v2] fetch the alignment of device dax

[PATCH v2 0/3] fetch the alignment of device dax

Jingqi Liu posted 3 patches 4 years ago

Diff against v3
Download series mbox

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200415033538.43329-1-jingqi.liu@intel.com

Maintainers: Richard Henderson <rth@twiddle.net>, Xiao Guangrong <xiaoguangrong.eric@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

There is a newer version of this series

configure       | 30 +++++++++++++++++++++++++++
docs/nvdimm.txt |  9 +++++++++
exec.c          | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
3 files changed, 92 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2 0/3] fetch the alignment of device dax

Posted by Jingqi Liu 4 years ago

This series adds libdaxctl support and fetchs the alignment of
device dax through libdaxctl [1] APIs.

QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mapping
address to the page size (getpagesize(2)) by default. However, some
types of backends may require an alignment different than the page
size. The 'align' option is provided to memory-backend-file to allow
users to specify the proper alignment.

For device dax (e.g., /dev/dax0.0), the 'align' option needs to
match the alignment requirement of the device dax, which can be fetched
through the libdaxctl APIs.

[1] Libdaxctl is a part of ndctl project.
The project's repository is: https://github.com/pmem/ndctl

Changelog:
  v2: Per Paolo and Dan suggestions, fetch the alignment of device dax
      through libdaxctl APIs.

  v1: The initial version.
      Fetch the alignment through "/sys/dev/char/%d:%d/device/align".

Jingqi Liu (3):
  exec: fetch the alignment of Linux devdax pmem character device nodes
  docs/nvdimm: add description of alignment requirement of device dax
  configure: add libdaxctl support

 configure       | 30 +++++++++++++++++++++++++++
 docs/nvdimm.txt |  9 +++++++++
 exec.c          | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 92 insertions(+), 1 deletion(-)

-- 
2.17.1

Re: [PATCH v2 0/3] fetch the alignment of device dax

Posted by Liu, Jingqi 4 years ago

Ping for comments.

Hi Paolo, Dan, Joao,
Any comments for this series.

Thanks,
Jingqi

On 4/15/2020 11:35 AM, Liu, Jingqi wrote:
> This series adds libdaxctl support and fetchs the alignment of
> device dax through libdaxctl [1] APIs.
>
> QEMU uses mmap(2) to maps vNVDIMM backends and aligns the mapping
> address to the page size (getpagesize(2)) by default. However, some
> types of backends may require an alignment different than the page
> size. The 'align' option is provided to memory-backend-file to allow
> users to specify the proper alignment.
>
> For device dax (e.g., /dev/dax0.0), the 'align' option needs to
> match the alignment requirement of the device dax, which can be fetched
> through the libdaxctl APIs.
>
> [1] Libdaxctl is a part of ndctl project.
> The project's repository is: https://github.com/pmem/ndctl
>
> Changelog:
>    v2: Per Paolo and Dan suggestions, fetch the alignment of device dax
>        through libdaxctl APIs.
>
>    v1: The initial version.
>        Fetch the alignment through "/sys/dev/char/%d:%d/device/align".
>
> Jingqi Liu (3):
>    exec: fetch the alignment of Linux devdax pmem character device nodes
>    docs/nvdimm: add description of alignment requirement of device dax
>    configure: add libdaxctl support
>
>   configure       | 30 +++++++++++++++++++++++++++
>   docs/nvdimm.txt |  9 +++++++++
>   exec.c          | 54 ++++++++++++++++++++++++++++++++++++++++++++++++-
>   3 files changed, 92 insertions(+), 1 deletion(-)
>