module: increase dirs array size by one

[PATCH] module: increase dirs array size by one

Bruce Rogers posted 1 patch 4 years, 1 month ago

Download mbox

Test docker-mingw@fedora passed

Test FreeBSD passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200411010746.472295-1-brogers@suse.com

util/module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] module: increase dirs array size by one

Posted by Bruce Rogers 4 years, 1 month ago

With the module upgrades code change, the statically sized dirs array
can now overflow. Increase it's size by one, according to the new
maximum possible usage.

Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
 util/module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/util/module.c b/util/module.c
index 5f7896870a..e48d9aacc0 100644
--- a/util/module.c
+++ b/util/module.c
@@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
     char *version_dir;
 #endif
     const char *search_dir;
-    char *dirs[4];
+    char *dirs[5];
     char *module_name;
     int i = 0, n_dirs = 0;
     int ret;
-- 
2.26.0

Re: [PATCH] module: increase dirs array size by one

Posted by Paolo Bonzini 4 years, 1 month ago

On 11/04/20 03:07, Bruce Rogers wrote:
> With the module upgrades code change, the statically sized dirs array
> can now overflow. Increase it's size by one, according to the new
> maximum possible usage.
> 
> Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir")
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  util/module.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/util/module.c b/util/module.c
> index 5f7896870a..e48d9aacc0 100644
> --- a/util/module.c
> +++ b/util/module.c
> @@ -177,7 +177,7 @@ bool module_load_one(const char *prefix, const char *lib_name)
>      char *version_dir;
>  #endif
>      const char *search_dir;
> -    char *dirs[4];
> +    char *dirs[5];
>      char *module_name;
>      int i = 0, n_dirs = 0;
>      int ret;
> 

Queued, thanks.

Paolo