1
A collection of bug fixes for rc2...
1
This one's almost all docs fixes.
2
2
3
The following changes since commit 146aa0f104bb3bf88e43c4082a0bfc4bbda4fbd8:
3
thanks
4
-- PMM
4
5
5
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-04-03 15:30:11 +0100)
6
The following changes since commit ba54a7e6b86884e43bed2d2f5a79c719059652a8:
7
8
Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into staging (2024-11-26 14:06:40 +0000)
6
9
7
are available in the Git repository at:
10
are available in the Git repository at:
8
11
9
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20200406
12
https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20241126
10
13
11
for you to fetch changes up to 8893790966d9c964557ad01be4a68ef50696ace8:
14
for you to fetch changes up to d8790ead55a2ef1e65332ebec63ae3c5db598942:
12
15
13
dma/xlnx-zdma: Reorg to fix CUR_DSCR (2020-04-06 10:59:56 +0100)
16
docs/system/arm/aspeed: add missing model supermicrox11spi-bmc (2024-11-26 16:22:38 +0000)
14
17
15
----------------------------------------------------------------
18
----------------------------------------------------------------
16
target-arm queue:
19
target-arm queue:
17
* don't expose "ieee_half" via gdbstub (prevents gdb crashes or errors
20
* target/arm/tcg/cpu32.c: swap ATCM and BTCM register names
18
with older GDB versions)
21
* docs/system/arm: Fix broken links and missing feature names
19
* hw/arm/collie: Put StrongARMState* into a CollieMachineState struct
20
* PSTATE.PAN should not clear exec bits
21
* hw/gpio/aspeed_gpio.c: Don't directly include assert.h
22
(fixes compilation on some Windows build scenarios)
23
* dump: Fix writing of ELF section
24
* dma/xlnx-zdma: various bug fixes
25
* target/arm/helperc. delete obsolete TODO comment
26
22
27
----------------------------------------------------------------
23
----------------------------------------------------------------
28
Alex Bennée (1):
24
Michael Tokarev (1):
29
target/arm: don't expose "ieee_half" via gdbstub
25
target/arm/tcg/cpu32.c: swap ATCM and BTCM register names
30
26
31
Edgar E. Iglesias (5):
27
Pierrick Bouvier (8):
32
dma/xlnx-zdma: Remove comment
28
docs/system/arm/emulation: mention armv9
33
dma/xlnx-zdma: Populate DBG0.CMN_BUF_FREE
29
docs/system/arm/emulation: fix typo in feature name
34
dma/xlnx-zdma: Clear DMA_DONE when halting
30
docs/system/arm/emulation: add FEAT_SSBS2
35
dma/xlnx-zdma: Advance the descriptor address when stopping
31
target/arm/tcg/: fix typo in FEAT name
36
dma/xlnx-zdma: Reorg to fix CUR_DSCR
32
docs/system/arm/: add FEAT_MTE_ASYNC
33
docs/system/arm/: add FEAT_DoubleLock
34
docs/system/arm/fby35: update link to product page
35
docs/system/arm/aspeed: add missing model supermicrox11spi-bmc
37
36
38
Peter Maydell (5):
37
docs/system/arm/aspeed.rst | 7 ++++---
39
hw/arm/collie: Put StrongARMState* into a CollieMachineState struct
38
docs/system/arm/emulation.rst | 11 +++++++----
40
target/arm: PSTATE.PAN should not clear exec bits
39
docs/system/arm/fby35.rst | 2 +-
41
target/arm: Remove obsolete TODO note from get_phys_addr_lpae()
40
target/arm/tcg/cpu32.c | 6 +++---
42
hw/gpio/aspeed_gpio.c: Don't directly include assert.h
41
4 files changed, 15 insertions(+), 11 deletions(-)
43
dump: Fix writing of ELF section
44
45
dump/dump.c | 2 +-
46
hw/arm/collie.c | 33 +++++++++++++++++++++++++-----
47
hw/dma/xlnx-zdma.c | 56 ++++++++++++++++++++++++++-------------------------
48
hw/gpio/aspeed_gpio.c | 2 --
49
target/arm/gdbstub.c | 7 ++++++-
50
target/arm/helper.c | 13 +++++-------
51
6 files changed, 69 insertions(+), 44 deletions(-)
52
diff view generated by jsdifflib
1
Remove a direct include of assert.h -- this is already
1
From: Michael Tokarev <mjt@tls.msk.ru>
2
provided by qemu/osdep.h, and it breaks our rule that the
3
first include must always be osdep.h.
4
2
5
In particular we must get the assert() macro via osdep.h
3
According to Cortex-R5 r1p2 manual, register with opcode2=0 is
6
to avoid compile failures on mingw (see the comment in
4
BTCM and with opcode2=1 is ATCM, - exactly the opposite from how
7
osdep.h where we redefine assert() for that platform).
5
qemu labels them. Just swap the labels to avoid confusion, -
6
both registers are implemented as always-zero.
8
7
8
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
9
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
10
Message-id: 20241121171602.3273252-1-mjt@tls.msk.ru
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
11
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
11
Reviewed-by: Cédric Le Goater <clg@kaod.org>
12
Message-id: 20200403124712.24826-1-peter.maydell@linaro.org
13
---
12
---
14
hw/gpio/aspeed_gpio.c | 2 --
13
target/arm/tcg/cpu32.c | 4 ++--
15
1 file changed, 2 deletions(-)
14
1 file changed, 2 insertions(+), 2 deletions(-)
16
15
17
diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c
16
diff --git a/target/arm/tcg/cpu32.c b/target/arm/tcg/cpu32.c
18
index XXXXXXX..XXXXXXX 100644
17
index XXXXXXX..XXXXXXX 100644
19
--- a/hw/gpio/aspeed_gpio.c
18
--- a/target/arm/tcg/cpu32.c
20
+++ b/hw/gpio/aspeed_gpio.c
19
+++ b/target/arm/tcg/cpu32.c
21
@@ -XXX,XX +XXX,XX @@
20
@@ -XXX,XX +XXX,XX @@ static void cortex_a15_initfn(Object *obj)
22
* SPDX-License-Identifier: GPL-2.0-or-later
21
23
*/
22
static const ARMCPRegInfo cortexr5_cp_reginfo[] = {
24
23
/* Dummy the TCM region regs for the moment */
25
-#include <assert.h>
24
- { .name = "ATCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 0,
26
-
25
+ { .name = "BTCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 0,
27
#include "qemu/osdep.h"
26
.access = PL1_RW, .type = ARM_CP_CONST },
28
#include "qemu/host-utils.h"
27
- { .name = "BTCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 1,
29
#include "qemu/log.h"
28
+ { .name = "ATCM", .cp = 15, .opc1 = 0, .crn = 9, .crm = 1, .opc2 = 1,
29
.access = PL1_RW, .type = ARM_CP_CONST },
30
{ .name = "DCACHE_INVAL", .cp = 15, .opc1 = 0, .crn = 15, .crm = 5,
31
.opc2 = 0, .access = PL1_W, .type = ARM_CP_NOP },
30
--
32
--
31
2.20.1
33
2.34.1
32
33
diff view generated by jsdifflib
1
An old comment in get_phys_addr_lpae() claims that the code does not
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
support the different format TCR for VTCR_EL2. This used to be true
3
but it is not true now (in particular the aa64_va_parameters() and
4
aa32_va_parameters() functions correctly handle the different
5
register format by checking whether the mmu_idx is Stage2).
6
Remove the out of date parts of the comment.
7
2
3
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
4
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
5
Message-id: 20241122225049.1617774-2-pierrick.bouvier@linaro.org
8
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
9
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
10
Message-id: 20200331143407.3186-1-peter.maydell@linaro.org
11
---
7
---
12
target/arm/helper.c | 7 +------
8
docs/system/arm/emulation.rst | 6 +++---
13
1 file changed, 1 insertion(+), 6 deletions(-)
9
1 file changed, 3 insertions(+), 3 deletions(-)
14
10
15
diff --git a/target/arm/helper.c b/target/arm/helper.c
11
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
16
index XXXXXXX..XXXXXXX 100644
12
index XXXXXXX..XXXXXXX 100644
17
--- a/target/arm/helper.c
13
--- a/docs/system/arm/emulation.rst
18
+++ b/target/arm/helper.c
14
+++ b/docs/system/arm/emulation.rst
19
@@ -XXX,XX +XXX,XX @@ static bool get_phys_addr_lpae(CPUARMState *env, target_ulong address,
15
@@ -XXX,XX +XXX,XX @@
20
bool aarch64 = arm_el_is_aa64(env, el);
16
A-profile CPU architecture support
21
bool guarded = false;
17
==================================
22
18
23
- /* TODO:
19
-QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7 and
24
- * This code does not handle the different format TCR for VTCR_EL2.
20
-Armv8 versions of the A-profile architecture. It also has support for
25
- * This code also does not support shareability levels.
21
+QEMU's TCG emulation includes support for the Armv5, Armv6, Armv7,
26
- * Attribute and permission bit handling should also be checked when adding
22
+Armv8 and Armv9 versions of the A-profile architecture. It also has support for
27
- * support for those page table walks.
23
the following architecture extensions:
28
- */
24
29
+ /* TODO: This code does not support shareability levels. */
25
- FEAT_AA32BF16 (AArch32 BFloat16 instructions)
30
if (aarch64) {
26
@@ -XXX,XX +XXX,XX @@ the following architecture extensions:
31
param = aa64_va_parameters(env, address, mmu_idx,
27
- FEAT_XNX (Translation table stage 2 Unprivileged Execute-never)
32
access_type != MMU_INST_FETCH);
28
29
For information on the specifics of these extensions, please refer
30
-to the `Armv8-A Arm Architecture Reference Manual
31
+to the `Arm Architecture Reference Manual for A-profile architecture
32
<https://developer.arm.com/documentation/ddi0487/latest>`_.
33
34
When a specific named CPU is being emulated, only those features which
33
--
35
--
34
2.20.1
36
2.34.1
35
36
diff view generated by jsdifflib
1
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
Reorganize the descriptor handling so that CUR_DSCR always
3
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
4
points to the next descriptor to be processed.
4
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
5
5
Message-id: 20241122225049.1617774-3-pierrick.bouvier@linaro.org
6
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
7
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
8
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
9
Message-id: 20200402134721.27863-6-edgar.iglesias@gmail.com
10
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
11
---
7
---
12
hw/dma/xlnx-zdma.c | 47 ++++++++++++++++++++++------------------------
8
docs/system/arm/emulation.rst | 2 +-
13
1 file changed, 22 insertions(+), 25 deletions(-)
9
1 file changed, 1 insertion(+), 1 deletion(-)
14
10
15
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
11
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
16
index XXXXXXX..XXXXXXX 100644
12
index XXXXXXX..XXXXXXX 100644
17
--- a/hw/dma/xlnx-zdma.c
13
--- a/docs/system/arm/emulation.rst
18
+++ b/hw/dma/xlnx-zdma.c
14
+++ b/docs/system/arm/emulation.rst
19
@@ -XXX,XX +XXX,XX @@ static void zdma_load_src_descriptor(XlnxZDMA *s)
15
@@ -XXX,XX +XXX,XX @@ the following architecture extensions:
20
}
16
- FEAT_LSE2 (Large System Extensions v2)
21
}
17
- FEAT_LVA (Large Virtual Address space)
22
18
- FEAT_MixedEnd (Mixed-endian support)
23
+static void zdma_update_descr_addr(XlnxZDMA *s, bool type,
19
-- FEAT_MixdEndEL0 (Mixed-endian support at EL0)
24
+ unsigned int basereg)
20
+- FEAT_MixedEndEL0 (Mixed-endian support at EL0)
25
+{
21
- FEAT_MOPS (Standardization of memory operations)
26
+ uint64_t addr, next;
22
- FEAT_MTE (Memory Tagging Extension)
27
+
23
- FEAT_MTE2 (Memory Tagging Extension)
28
+ if (type == DTYPE_LINEAR) {
29
+ addr = zdma_get_regaddr64(s, basereg);
30
+ next = addr + sizeof(s->dsc_dst);
31
+ } else {
32
+ addr = zdma_get_regaddr64(s, basereg);
33
+ addr += sizeof(s->dsc_dst);
34
+ address_space_read(s->dma_as, addr, s->attr, (void *) &next, 8);
35
+ }
36
+
37
+ zdma_put_regaddr64(s, basereg, next);
38
+}
39
+
40
static void zdma_load_dst_descriptor(XlnxZDMA *s)
41
{
42
uint64_t dst_addr;
43
unsigned int ptype = ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_TYPE);
44
+ bool dst_type;
45
46
if (ptype == PT_REG) {
47
memcpy(&s->dsc_dst, &s->regs[R_ZDMA_CH_DST_DSCR_WORD0],
48
@@ -XXX,XX +XXX,XX @@ static void zdma_load_dst_descriptor(XlnxZDMA *s)
49
if (!zdma_load_descriptor(s, dst_addr, &s->dsc_dst)) {
50
ARRAY_FIELD_DP32(s->regs, ZDMA_CH_ISR, AXI_RD_DST_DSCR, true);
51
}
52
-}
53
54
-static uint64_t zdma_update_descr_addr(XlnxZDMA *s, bool type,
55
- unsigned int basereg)
56
-{
57
- uint64_t addr, next;
58
-
59
- if (type == DTYPE_LINEAR) {
60
- next = zdma_get_regaddr64(s, basereg);
61
- next += sizeof(s->dsc_dst);
62
- zdma_put_regaddr64(s, basereg, next);
63
- } else {
64
- addr = zdma_get_regaddr64(s, basereg);
65
- addr += sizeof(s->dsc_dst);
66
- address_space_read(s->dma_as, addr, s->attr, &next, 8);
67
- zdma_put_regaddr64(s, basereg, next);
68
- }
69
- return next;
70
+ /* Advance the descriptor pointer. */
71
+ dst_type = FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD3, TYPE);
72
+ zdma_update_descr_addr(s, dst_type, R_ZDMA_CH_DST_CUR_DSCR_LSB);
73
}
74
75
static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
76
@@ -XXX,XX +XXX,XX @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len)
77
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
78
SIZE);
79
if (dst_size == 0 && ptype == PT_MEM) {
80
- uint64_t next;
81
- bool dst_type = FIELD_EX32(s->dsc_dst.words[3],
82
- ZDMA_CH_DST_DSCR_WORD3,
83
- TYPE);
84
-
85
- next = zdma_update_descr_addr(s, dst_type,
86
- R_ZDMA_CH_DST_CUR_DSCR_LSB);
87
- zdma_load_descriptor(s, next, &s->dsc_dst);
88
+ zdma_load_dst_descriptor(s);
89
dst_size = FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD2,
90
SIZE);
91
}
92
--
24
--
93
2.20.1
25
2.34.1
94
95
diff view generated by jsdifflib
1
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
Advance the descriptor address when stopping the channel.
3
We implemented this at the same times as FEAT_SSBS, but forgot
4
to list it in the documentation.
4
5
5
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
6
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
6
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
7
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
7
Acked-by: Alistair Francis <alistair.francis@wdc.com>
8
Message-id: 20241122225049.1617774-4-pierrick.bouvier@linaro.org
8
Message-id: 20200402134721.27863-5-edgar.iglesias@gmail.com
9
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
10
[PMM: improve commit message]
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
11
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
12
---
11
hw/dma/xlnx-zdma.c | 1 -
13
docs/system/arm/emulation.rst | 1 +
12
1 file changed, 1 deletion(-)
14
1 file changed, 1 insertion(+)
13
15
14
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
16
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
15
index XXXXXXX..XXXXXXX 100644
17
index XXXXXXX..XXXXXXX 100644
16
--- a/hw/dma/xlnx-zdma.c
18
--- a/docs/system/arm/emulation.rst
17
+++ b/hw/dma/xlnx-zdma.c
19
+++ b/docs/system/arm/emulation.rst
18
@@ -XXX,XX +XXX,XX @@ static void zdma_process_descr(XlnxZDMA *s)
20
@@ -XXX,XX +XXX,XX @@ the following architecture extensions:
19
if (ptype == PT_REG || src_cmd == CMD_STOP) {
21
- FEAT_SVE2 (Scalable Vector Extension version 2)
20
ARRAY_FIELD_DP32(s->regs, ZDMA_CH_CTRL2, EN, 0);
22
- FEAT_SPECRES (Speculation restriction instructions)
21
zdma_set_state(s, DISABLED);
23
- FEAT_SSBS (Speculative Store Bypass Safe)
22
- return;
24
+- FEAT_SSBS2 (MRS and MSR instructions for SSBS version 2)
23
}
25
- FEAT_TGran16K (Support for 16KB memory translation granule size at stage 1)
24
26
- FEAT_TGran4K (Support for 4KB memory translation granule size at stage 1)
25
if (src_cmd == CMD_HALT) {
27
- FEAT_TGran64K (Support for 64KB memory translation granule size at stage 1)
26
--
28
--
27
2.20.1
29
2.34.1
28
29
diff view generated by jsdifflib
1
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
Populate DBG0.CMN_BUF_FREE so that SW can see some free space.
3
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
4
4
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
5
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
5
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
6
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
6
Message-id: 20241122225049.1617774-5-pierrick.bouvier@linaro.org
7
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
8
Message-id: 20200402134721.27863-3-edgar.iglesias@gmail.com
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
7
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
8
---
11
hw/dma/xlnx-zdma.c | 6 ++++++
9
target/arm/tcg/cpu32.c | 2 +-
12
1 file changed, 6 insertions(+)
10
1 file changed, 1 insertion(+), 1 deletion(-)
13
11
14
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
12
diff --git a/target/arm/tcg/cpu32.c b/target/arm/tcg/cpu32.c
15
index XXXXXXX..XXXXXXX 100644
13
index XXXXXXX..XXXXXXX 100644
16
--- a/hw/dma/xlnx-zdma.c
14
--- a/target/arm/tcg/cpu32.c
17
+++ b/hw/dma/xlnx-zdma.c
15
+++ b/target/arm/tcg/cpu32.c
18
@@ -XXX,XX +XXX,XX @@ static RegisterAccessInfo zdma_regs_info[] = {
16
@@ -XXX,XX +XXX,XX @@ void aa32_max_features(ARMCPU *cpu)
19
},{ .name = "ZDMA_CH_DBG0", .addr = A_ZDMA_CH_DBG0,
17
cpu->isar.id_mmfr5 = t;
20
.rsvd = 0xfffffe00,
18
21
.ro = 0x1ff,
19
t = cpu->isar.id_pfr0;
22
+
20
- t = FIELD_DP32(t, ID_PFR0, CSV2, 2); /* FEAT_CVS2 */
23
+ /*
21
+ t = FIELD_DP32(t, ID_PFR0, CSV2, 2); /* FEAT_CSV2 */
24
+ * There's SW out there that will check the debug regs for free space.
22
t = FIELD_DP32(t, ID_PFR0, DIT, 1); /* FEAT_DIT */
25
+ * Claim that we always have 0x100 free.
23
t = FIELD_DP32(t, ID_PFR0, RAS, 1); /* FEAT_RAS */
26
+ */
24
cpu->isar.id_pfr0 = t;
27
+ .reset = 0x100
28
},{ .name = "ZDMA_CH_DBG1", .addr = A_ZDMA_CH_DBG1,
29
.rsvd = 0xfffffe00,
30
.ro = 0x1ff,
31
--
25
--
32
2.20.1
26
2.34.1
33
27
34
28
diff view generated by jsdifflib
1
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
Clear DMA_DONE when halting the DMA channel.
3
We already implement FEAT_MTE_ASYNC; we just forgot to list it
4
in the documentation.
4
5
5
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
6
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
6
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
7
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
7
Acked-by: Alistair Francis <alistair.francis@wdc.com>
8
Message-id: 20241122225049.1617774-6-pierrick.bouvier@linaro.org
8
Message-id: 20200402134721.27863-4-edgar.iglesias@gmail.com
9
[PMM: expand commit message]
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
11
---
11
hw/dma/xlnx-zdma.c | 1 +
12
docs/system/arm/emulation.rst | 1 +
12
1 file changed, 1 insertion(+)
13
1 file changed, 1 insertion(+)
13
14
14
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
15
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
15
index XXXXXXX..XXXXXXX 100644
16
index XXXXXXX..XXXXXXX 100644
16
--- a/hw/dma/xlnx-zdma.c
17
--- a/docs/system/arm/emulation.rst
17
+++ b/hw/dma/xlnx-zdma.c
18
+++ b/docs/system/arm/emulation.rst
18
@@ -XXX,XX +XXX,XX @@ static void zdma_process_descr(XlnxZDMA *s)
19
@@ -XXX,XX +XXX,XX @@ the following architecture extensions:
19
if (src_cmd == CMD_HALT) {
20
- FEAT_MTE2 (Memory Tagging Extension)
20
zdma_set_state(s, PAUSED);
21
- FEAT_MTE3 (MTE Asymmetric Fault Handling)
21
ARRAY_FIELD_DP32(s->regs, ZDMA_CH_ISR, DMA_PAUSE, 1);
22
- FEAT_MTE_ASYM_FAULT (Memory tagging asymmetric faults)
22
+ ARRAY_FIELD_DP32(s->regs, ZDMA_CH_ISR, DMA_DONE, false);
23
+- FEAT_MTE_ASYNC (Asynchronous reporting of Tag Check Fault)
23
zdma_ch_imr_update_irq(s);
24
- FEAT_NMI (Non-maskable Interrupt)
24
return;
25
- FEAT_NV (Nested Virtualization)
25
}
26
- FEAT_NV2 (Enhanced nested virtualization support)
26
--
27
--
27
2.20.1
28
2.34.1
28
29
diff view generated by jsdifflib
1
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
Remove comment.
3
We already implement FEAT_DoubleLock (see commit f94a6df5dd6a7) when
4
the ID registers call for it. This feature is actually one that must
5
*not* be implemented in v9.0, but since our documentation lists
6
everything we can emulate, we should include FEAT_DoubleLock in the
7
list.
4
8
5
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
9
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
6
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
10
Message-id: 20241122225049.1617774-7-pierrick.bouvier@linaro.org
7
Reviewed-by: Francisco Iglesias <frasse.iglesias@gmail.com>
11
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
8
Message-id: 20200402134721.27863-2-edgar.iglesias@gmail.com
12
[PMM: expand commit message]
9
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
13
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
10
---
14
---
11
hw/dma/xlnx-zdma.c | 1 -
15
docs/system/arm/emulation.rst | 1 +
12
1 file changed, 1 deletion(-)
16
1 file changed, 1 insertion(+)
13
17
14
diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c
18
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
15
index XXXXXXX..XXXXXXX 100644
19
index XXXXXXX..XXXXXXX 100644
16
--- a/hw/dma/xlnx-zdma.c
20
--- a/docs/system/arm/emulation.rst
17
+++ b/hw/dma/xlnx-zdma.c
21
+++ b/docs/system/arm/emulation.rst
18
@@ -XXX,XX +XXX,XX @@ static void zdma_process_descr(XlnxZDMA *s)
22
@@ -XXX,XX +XXX,XX @@ the following architecture extensions:
19
zdma_src_done(s);
23
- FEAT_CSV3 (Cache speculation variant 3)
20
}
24
- FEAT_DGH (Data gathering hint)
21
25
- FEAT_DIT (Data Independent Timing instructions)
22
- /* Load next descriptor. */
26
+- FEAT_DoubleLock (Double Lock)
23
if (ptype == PT_REG || src_cmd == CMD_STOP) {
27
- FEAT_DPB (DC CVAP instruction)
24
ARRAY_FIELD_DP32(s->regs, ZDMA_CH_CTRL2, EN, 0);
28
- FEAT_DPB2 (DC CVADP instruction)
25
zdma_set_state(s, DISABLED);
29
- FEAT_Debugv8p1 (Debug with VHE)
26
--
30
--
27
2.20.1
31
2.34.1
28
29
diff view generated by jsdifflib
1
In write_elf_section() we set the 'shdr' pointer to point to local
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
structures shdr32 or shdr64, which we fill in to be written out to
3
the ELF dump. Unfortunately the address we pass to fd_write_vmcore()
4
has a spurious '&' operator, so instead of writing out the section
5
header we write out the literal pointer value followed by whatever is
6
on the stack after the 'shdr' local variable.
7
2
8
Pass the correct address into fd_write_vmcore().
3
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
9
4
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
10
Spotted by Coverity: CID 1421970.
5
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
11
6
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
12
Cc: qemu-stable@nongnu.org
7
Message-id: 20241122225049.1617774-8-pierrick.bouvier@linaro.org
13
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
14
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
15
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
16
Message-id: 20200324173630.12221-1-peter.maydell@linaro.org
17
---
9
---
18
dump/dump.c | 2 +-
10
docs/system/arm/fby35.rst | 2 +-
19
1 file changed, 1 insertion(+), 1 deletion(-)
11
1 file changed, 1 insertion(+), 1 deletion(-)
20
12
21
diff --git a/dump/dump.c b/dump/dump.c
13
diff --git a/docs/system/arm/fby35.rst b/docs/system/arm/fby35.rst
22
index XXXXXXX..XXXXXXX 100644
14
index XXXXXXX..XXXXXXX 100644
23
--- a/dump/dump.c
15
--- a/docs/system/arm/fby35.rst
24
+++ b/dump/dump.c
16
+++ b/docs/system/arm/fby35.rst
25
@@ -XXX,XX +XXX,XX @@ static void write_elf_section(DumpState *s, int type, Error **errp)
17
@@ -XXX,XX +XXX,XX @@ include various compute accelerators (video, inferencing, etc). At the moment,
26
shdr = &shdr64;
18
only the first server slot's BIC is included.
27
}
19
28
20
Yosemite v3.5 is itself a sled which fits into a 40U chassis, and 3 sleds
29
- ret = fd_write_vmcore(&shdr, shdr_size, s);
21
-can be fit into a chassis. See `here <https://www.opencompute.org/products/423/wiwynn-yosemite-v3-server>`__
30
+ ret = fd_write_vmcore(shdr, shdr_size, s);
22
+can be fit into a chassis. See `here <https://www.opencompute.org/products-chiplets/237/wiwynn-yosemite-v3-server>`__
31
if (ret < 0) {
23
for an example.
32
error_setg_errno(errp, -ret,
24
33
"dump: failed to write section header table");
25
In this generation, the BMC is an AST2600 and each BIC is an AST1030. The BMC
34
--
26
--
35
2.20.1
27
2.34.1
36
28
37
29
diff view generated by jsdifflib
1
From: Alex Bennée <alex.bennee@linaro.org>
1
From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
2
2
3
While support for parsing ieee_half in the XML description was added
3
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
4
to gdb in 2019 (a6d0f249) there is no easy way for the gdbstub to know
4
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
5
if the gdb end will understand it. Disable it for now and allow older
5
Message-id: 20241122225049.1617774-13-pierrick.bouvier@linaro.org
6
gdbs to successfully connect to the default -cpu max SVE enabled
7
QEMUs.
8
9
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
10
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
11
Message-id: 20200402143913.24005-1-alex.bennee@linaro.org
12
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
6
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
13
---
7
---
14
target/arm/gdbstub.c | 7 ++++++-
8
docs/system/arm/aspeed.rst | 7 ++++---
15
1 file changed, 6 insertions(+), 1 deletion(-)
9
1 file changed, 4 insertions(+), 3 deletions(-)
16
10
17
diff --git a/target/arm/gdbstub.c b/target/arm/gdbstub.c
11
diff --git a/docs/system/arm/aspeed.rst b/docs/system/arm/aspeed.rst
18
index XXXXXXX..XXXXXXX 100644
12
index XXXXXXX..XXXXXXX 100644
19
--- a/target/arm/gdbstub.c
13
--- a/docs/system/arm/aspeed.rst
20
+++ b/target/arm/gdbstub.c
14
+++ b/docs/system/arm/aspeed.rst
21
@@ -XXX,XX +XXX,XX @@ static const struct TypeSize vec_lanes[] = {
15
@@ -XXX,XX +XXX,XX @@
22
/* 16 bit */
16
-Aspeed family boards (``ast2500-evb``, ``ast2600-evb``, ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``, ``fby35-bmc``, ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``, ``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``, ``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``, ``supermicrox11-bmc``, ``tiogapass-bmc``, ``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
23
{ "uint16", 16, 'h', 'u' },
17
-========================================================================================================================================================================================================================================================================================================================================================================================================
24
{ "int16", 16, 'h', 's' },
18
+Aspeed family boards (``ast2500-evb``, ``ast2600-evb``, ``ast2700-evb``, ``bletchley-bmc``, ``fuji-bmc``, ``fby35-bmc``, ``fp5280g2-bmc``, ``g220a-bmc``, ``palmetto-bmc``, ``qcom-dc-scm-v1-bmc``, ``qcom-firework-bmc``, ``quanta-q71l-bmc``, ``rainier-bmc``, ``romulus-bmc``, ``sonorapass-bmc``, ``supermicrox11-bmc``, ``supermicrox11spi-bmc``, ``tiogapass-bmc``, ``tacoma-bmc``, ``witherspoon-bmc``, ``yosemitev2-bmc``)
25
- { "ieee_half", 16, 'h', 'f' },
19
+==================================================================================================================================================================================================================================================================================================================================================================================================================================
26
+ /*
20
27
+ * TODO: currently there is no reliable way of telling
21
The QEMU Aspeed machines model BMCs of various OpenPOWER systems and
28
+ * if the remote gdb actually understands ieee_half so
22
Aspeed evaluation boards. They are based on different releases of the
29
+ * we don't expose it in the target description for now.
23
@@ -XXX,XX +XXX,XX @@ AST2400 SoC based machines :
30
+ * { "ieee_half", 16, 'h', 'f' },
24
31
+ */
25
- ``palmetto-bmc`` OpenPOWER Palmetto POWER8 BMC
32
/* bytes */
26
- ``quanta-q71l-bmc`` OpenBMC Quanta BMC
33
{ "uint8", 8, 'b', 'u' },
27
-- ``supermicrox11-bmc`` Supermicro X11 BMC
34
{ "int8", 8, 'b', 's' },
28
+- ``supermicrox11-bmc`` Supermicro X11 BMC (ARM926EJ-S)
29
+- ``supermicrox11spi-bmc`` Supermicro X11 SPI BMC (ARM1176)
30
31
AST2500 SoC based machines :
32
35
--
33
--
36
2.20.1
34
2.34.1
37
38
diff view generated by jsdifflib
Deleted patch
1
Coverity complains that the collie_init() function leaks the memory
2
allocated in sa1110_init(). This is true but not significant since
3
the function is called only once on machine init and the memory must
4
remain in existence until QEMU exits anyway.
5
1
6
Still, we can avoid the technical memory leak by keeping the pointer
7
to the StrongARMState inside the machine state struct. Switch from
8
the simple DEFINE_MACHINE() style to defining a subclass of
9
TYPE_MACHINE which extends the MachineState struct, and keep the
10
pointer there.
11
12
Fixes: CID 1421921
13
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
14
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
15
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
16
Message-id: 20200326204919.22006-1-peter.maydell@linaro.org
17
---
18
hw/arm/collie.c | 33 ++++++++++++++++++++++++++++-----
19
1 file changed, 28 insertions(+), 5 deletions(-)
20
21
diff --git a/hw/arm/collie.c b/hw/arm/collie.c
22
index XXXXXXX..XXXXXXX 100644
23
--- a/hw/arm/collie.c
24
+++ b/hw/arm/collie.c
25
@@ -XXX,XX +XXX,XX @@
26
#include "exec/address-spaces.h"
27
#include "cpu.h"
28
29
+typedef struct {
30
+ MachineState parent;
31
+
32
+ StrongARMState *sa1110;
33
+} CollieMachineState;
34
+
35
+#define TYPE_COLLIE_MACHINE MACHINE_TYPE_NAME("collie")
36
+#define COLLIE_MACHINE(obj) \
37
+ OBJECT_CHECK(CollieMachineState, obj, TYPE_COLLIE_MACHINE)
38
+
39
static struct arm_boot_info collie_binfo = {
40
.loader_start = SA_SDCS0,
41
.ram_size = 0x20000000,
42
@@ -XXX,XX +XXX,XX @@ static struct arm_boot_info collie_binfo = {
43
44
static void collie_init(MachineState *machine)
45
{
46
- StrongARMState *s;
47
DriveInfo *dinfo;
48
MachineClass *mc = MACHINE_GET_CLASS(machine);
49
+ CollieMachineState *cms = COLLIE_MACHINE(machine);
50
51
if (machine->ram_size != mc->default_ram_size) {
52
char *sz = size_to_str(mc->default_ram_size);
53
@@ -XXX,XX +XXX,XX @@ static void collie_init(MachineState *machine)
54
exit(EXIT_FAILURE);
55
}
56
57
- s = sa1110_init(machine->cpu_type);
58
+ cms->sa1110 = sa1110_init(machine->cpu_type);
59
60
memory_region_add_subregion(get_system_memory(), SA_SDCS0, machine->ram);
61
62
@@ -XXX,XX +XXX,XX @@ static void collie_init(MachineState *machine)
63
sysbus_create_simple("scoop", 0x40800000, NULL);
64
65
collie_binfo.board_id = 0x208;
66
- arm_load_kernel(s->cpu, machine, &collie_binfo);
67
+ arm_load_kernel(cms->sa1110->cpu, machine, &collie_binfo);
68
}
69
70
-static void collie_machine_init(MachineClass *mc)
71
+static void collie_machine_class_init(ObjectClass *oc, void *data)
72
{
73
+ MachineClass *mc = MACHINE_CLASS(oc);
74
+
75
mc->desc = "Sharp SL-5500 (Collie) PDA (SA-1110)";
76
mc->init = collie_init;
77
mc->ignore_memory_transaction_failures = true;
78
@@ -XXX,XX +XXX,XX @@ static void collie_machine_init(MachineClass *mc)
79
mc->default_ram_id = "strongarm.sdram";
80
}
81
82
-DEFINE_MACHINE("collie", collie_machine_init)
83
+static const TypeInfo collie_machine_typeinfo = {
84
+ .name = TYPE_COLLIE_MACHINE,
85
+ .parent = TYPE_MACHINE,
86
+ .class_init = collie_machine_class_init,
87
+ .instance_size = sizeof(CollieMachineState),
88
+};
89
+
90
+static void collie_machine_register_types(void)
91
+{
92
+ type_register_static(&collie_machine_typeinfo);
93
+}
94
+type_init(collie_machine_register_types);
95
--
96
2.20.1
97
98
diff view generated by jsdifflib
Deleted patch
1
Our implementation of the PSTATE.PAN bit incorrectly cleared all
2
access permission bits for privileged access to memory which is
3
user-accessible. It should only affect the privileged read and write
4
permissions; execute permission is dealt with via XN/PXN instead.
5
1
6
Fixes: 81636b70c226dc27d7ebc8d
7
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
8
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
9
Message-id: 20200330170651.20901-1-peter.maydell@linaro.org
10
---
11
target/arm/helper.c | 6 ++++--
12
1 file changed, 4 insertions(+), 2 deletions(-)
13
14
diff --git a/target/arm/helper.c b/target/arm/helper.c
15
index XXXXXXX..XXXXXXX 100644
16
--- a/target/arm/helper.c
17
+++ b/target/arm/helper.c
18
@@ -XXX,XX +XXX,XX @@ static int get_S1prot(CPUARMState *env, ARMMMUIdx mmu_idx, bool is_aa64,
19
prot_rw = user_rw;
20
} else {
21
if (user_rw && regime_is_pan(env, mmu_idx)) {
22
- return 0;
23
+ /* PAN forbids data accesses but doesn't affect insn fetch */
24
+ prot_rw = 0;
25
+ } else {
26
+ prot_rw = simple_ap_to_rw_prot_is_user(ap, false);
27
}
28
- prot_rw = simple_ap_to_rw_prot_is_user(ap, false);
29
}
30
31
if (ns && arm_is_secure(env) && (env->cp15.scr_el3 & SCR_SIF)) {
32
--
33
2.20.1
34
35
diff view generated by jsdifflib