[PATCH v2] qobject: json-streamer: Change bracket_count to brace_count

Simran Singhal posted 1 patch 5 years, 7 months ago
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200402171940.GA21781@simran-Inspiron-5558
Maintainers: Markus Armbruster <armbru@redhat.com>
There is a newer version of this series
qobject/json-streamer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] qobject: json-streamer: Change bracket_count to brace_count
Posted by Simran Singhal 5 years, 7 months ago
Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0"
to fix the typo.

Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
---
Changes in v2:
        -No need to remove the duplicate occurence of "parser->bracket_count >= 0"
	but actually it is a typo and one occurence should be "parser->brace_count >= 0".

 qobject/json-streamer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qobject/json-streamer.c b/qobject/json-streamer.c
index 47dd7ea576..b93d97b995 100644
--- a/qobject/json-streamer.c
+++ b/qobject/json-streamer.c
@@ -85,7 +85,7 @@ void json_message_process_token(JSONLexer *lexer, GString *input,
     g_queue_push_tail(&parser->tokens, token);
 
     if ((parser->brace_count > 0 || parser->bracket_count > 0)
-        && parser->bracket_count >= 0 && parser->bracket_count >= 0) {
+        && parser->brace_count >= 0 && parser->bracket_count >= 0) {
         return;
     }
 
-- 
2.17.1


Re: [PATCH v2] qobject: json-streamer: Change bracket_count to brace_count
Posted by Eric Blake 5 years, 7 months ago
On 4/2/20 12:19 PM, Simran Singhal wrote:
> Change the "parser->bracket_count >= 0" to "parser->brace_count >= 0"
> to fix the typo.
> 
> Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>

Please add:

Fixes: 8d3265b3

at which point you can also add:

Reviewed-by: Eric Blake <eblake@redhat.com>

> ---
> Changes in v2:
>          -No need to remove the duplicate occurence of "parser->bracket_count >= 0"
> 	but actually it is a typo and one occurence should be "parser->brace_count >= 0".

occurrence (but at least this typo won't make it into git)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org