[PATCH] nvme: Print 'cqid' for nvme_del_cq

Minwoo Im posted 1 patch 2 weeks ago
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200324140646.8274-1-minwoo.im.dev@gmail.com
Maintainers: Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
hw/block/trace-events | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] nvme: Print 'cqid' for nvme_del_cq

Posted by Minwoo Im 2 weeks ago
The given argument for this trace should be cqid, not sqid.

Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
---
 hw/block/trace-events | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/block/trace-events b/hw/block/trace-events
index f78939fa9da1..bf6d11b58b85 100644
--- a/hw/block/trace-events
+++ b/hw/block/trace-events
@@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
 nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
 nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
 nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
-nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
+nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
 nvme_identify_ctrl(void) "identify controller"
 nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
 nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
-- 
2.17.1


Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq

Posted by Kevin Wolf 1 week ago
Am 24.03.2020 um 15:06 hat Minwoo Im geschrieben:
> The given argument for this trace should be cqid, not sqid.
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>

Thanks, applied to the block branch.

Kevin


Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq

Posted by Stefano Garzarella 1 week ago
On Tue, Mar 24, 2020 at 11:06:46PM +0900, Minwoo Im wrote:
> The given argument for this trace should be cqid, not sqid.
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>  hw/block/trace-events | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

> 
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index f78939fa9da1..bf6d11b58b85 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
>  nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
>  nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
>  nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
> -nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
> +nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
>  nvme_identify_ctrl(void) "identify controller"
>  nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
>  nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
> -- 
> 2.17.1
> 
> 


Re: [PATCH] nvme: Print 'cqid' for nvme_del_cq

Posted by Philippe Mathieu-Daudé 2 weeks ago
On 3/24/20 3:06 PM, Minwoo Im wrote:
> The given argument for this trace should be cqid, not sqid.
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>   hw/block/trace-events | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/block/trace-events b/hw/block/trace-events
> index f78939fa9da1..bf6d11b58b85 100644
> --- a/hw/block/trace-events
> +++ b/hw/block/trace-events
> @@ -37,7 +37,7 @@ nvme_rw(const char *verb, uint32_t blk_count, uint64_t byte_count, uint64_t lba)
>   nvme_create_sq(uint64_t addr, uint16_t sqid, uint16_t cqid, uint16_t qsize, uint16_t qflags) "create submission queue, addr=0x%"PRIx64", sqid=%"PRIu16", cqid=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16""
>   nvme_create_cq(uint64_t addr, uint16_t cqid, uint16_t vector, uint16_t size, uint16_t qflags, int ien) "create completion queue, addr=0x%"PRIx64", cqid=%"PRIu16", vector=%"PRIu16", qsize=%"PRIu16", qflags=%"PRIu16", ien=%d"
>   nvme_del_sq(uint16_t qid) "deleting submission queue sqid=%"PRIu16""
> -nvme_del_cq(uint16_t cqid) "deleted completion queue, sqid=%"PRIu16""
> +nvme_del_cq(uint16_t cqid) "deleted completion queue, cqid=%"PRIu16""
>   nvme_identify_ctrl(void) "identify controller"
>   nvme_identify_ns(uint16_t ns) "identify namespace, nsid=%"PRIu16""
>   nvme_identify_nslist(uint16_t ns) "identify namespace list, nsid=%"PRIu16""
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>