[v4] redundant code: Fix warnings reported by Clang static code analyzer

[PATCH v4 0/3] redundant code: Fix warnings reported by Clang static code analyzer

Chen Qun posted 3 patches 4 years ago

Diff against v1 v2 v3 v3 v5
Download series mbox

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200324082235.27980-1-kuhn.chenqun@huawei.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Andrzej Zaborowski <balrogg@gmail.com>, Fam Zheng <fam@euphon.net>

There is a newer version of this series

hw/display/blizzard.c     | 1 -
hw/scsi/esp-pci.c         | 1 +
hw/timer/exynos4210_mct.c | 4 ----
3 files changed, 1 insertion(+), 5 deletions(-)

Expand all Fold all

[PATCH v4 0/3] redundant code: Fix warnings reported by Clang static code analyzer

Posted by Chen Qun 4 years ago

v1->v2:
- Patch1: Add John Snow review comment.
- Patch9: Move the 'dst_type' declaration to while() statement.
- Patch12: Add Philippe Mathieu-Daudé review comment.
- Patch13: Move the 'set' declaration to the for() statement.

v2->v3:
- Patch1: Add Kevin Wolf review comment.
- Patch2: Keep the 'flags' then use it(Base on Kevin's comments).
- Patch3: Add Kevin Wolf review comment.
- Patch9: Add Francisco Iglesias and Alistair Francis review comment.
- Patch10: Juan Quintela has added it to the queue and delete it.
- Patch12->Patch11: Add Philippe Mathieu-Daudé review comment.
- Patch13->Patch12: Add Philippe Mathieu-Daudé review comment.

v3->v4:
- Deleted the patches that have been merged in the v3.
- Modify "scsi/esp-pci" Patch, use g_assert with variable size.

Chen Qun (3):
  scsi/esp-pci: Remove redundant statement in esp_pci_io_write()
  display/blizzard: Remove redundant statement in
    blizzard_draw_line16_32()
  timer/exynos4210_mct: Remove redundant statement in
    exynos4210_mct_write()

 hw/display/blizzard.c     | 1 -
 hw/scsi/esp-pci.c         | 1 +
 hw/timer/exynos4210_mct.c | 4 ----
 3 files changed, 1 insertion(+), 5 deletions(-)

-- 
2.23.0