[v2] Slirp patches

[PULL v2 0/1] Slirp patches

Posted by Marc-André Lureau 4 years, 1 month ago

The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7:

  Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' into staging (2020-03-19 10:18:07 +0000)

are available in the Git repository at:

  https://github.com/elmarco/qemu.git tags/slirp-pull-request

for you to fetch changes up to aa63573a84c92b14c23f557fcc93a12b1a93c187:

  slirp: update submodule to v4.2.0+ (2020-03-20 16:50:12 +0100)

----------------------------------------------------------------

----------------------------------------------------------------

Marc-André Lureau (1):
  slirp: update submodule to v4.2.0+

 slirp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.25.0.rc2.1.g09a9a1a997

Re: [PULL v2 0/1] Slirp patches

Posted by no-reply@patchew.org 4 years, 1 month ago

Patchew URL: https://patchew.org/QEMU/20200320155106.549514-1-marcandre.lureau@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL v2 0/1] Slirp patches
Message-id: 20200320155106.549514-1-marcandre.lureau@redhat.com
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
ca00178 slirp: update submodule to v4.2.0+

=== OUTPUT BEGIN ===
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 2 lines checked

Commit ca0017831606 (slirp: update submodule to v4.2.0+) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200320155106.549514-1-marcandre.lureau@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [PULL v2 0/1] Slirp patches

Posted by Peter Maydell 4 years, 1 month ago

On Fri, 20 Mar 2020 at 15:51, Marc-André Lureau
<marcandre.lureau@redhat.com> wrote:
>
> The following changes since commit f57587c7d47b35b2d9b31def3a74d81bdb5475d7:
>
>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2020-03-17' into staging (2020-03-19 10:18:07 +0000)
>
> are available in the Git repository at:
>
>   https://github.com/elmarco/qemu.git tags/slirp-pull-request
>
> for you to fetch changes up to aa63573a84c92b14c23f557fcc93a12b1a93c187:
>
>   slirp: update submodule to v4.2.0+ (2020-03-20 16:50:12 +0100)
>
> ----------------------------------------------------------------
>
> ----------------------------------------------------------------
>
> Marc-André Lureau (1):
>   slirp: update submodule to v4.2.0+
>
>  slirp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi; this fails to build on most platforms (though it works on
the BSDs, oddly):

/home/ubuntu/qemu/slirp/src/version.c: In function ‘slirp_version_string’:
/home/ubuntu/qemu/slirp/src/version.c:7:12: error:
‘SLIRP_VERSION_STRING’ undeclared (first use in this function); did
you mean ‘LIBSLIRP_VERSION_H_’?
     return SLIRP_VERSION_STRING;
            ^~~~~~~~~~~~~~~~~~~~
            LIBSLIRP_VERSION_H_
/home/ubuntu/qemu/slirp/src/version.c:7:12: note: each undeclared
identifier is reported only once for each function it appears in
/home/ubuntu/qemu/slirp/src/version.c:8:1: error: control reaches end
of non-void function [-Werror=return-type]
 }
 ^
cc1: all warnings being treated as errors
Makefile:45: recipe for target
'/home/ubuntu/qemu/build/all/slirp/src/version.o' failed


thanks
-- PMM