[v4] add new options to set smbios type 4 fields

[PATCH v4 0/2] add new options to set smbios type 4 fields

Posted by Heyi Guo 5 years, 8 months ago

Common VM users sometimes care about CPU speed, so we add two new
options to allow VM vendors to present CPU speed to their users.
Normally these information can be fetched from host smbios.

v3 -> v4:
- Fix the default value when not specifying "-smbios type=4" option;
  it would be 0 instead of 2000 in previous versions
- Use uint64_t type to check value overflow
- Add test case to check smbios type 4 CPU speed

Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>

Heyi Guo (2):
  hw/smbios: add options for type 4 max-speed and current-speed
  tests/bios-tables-test: add smbios cpu speed test

 hw/smbios/smbios.c             | 36 +++++++++++++++++++++++++----
 qemu-options.hx                |  3 ++-
 tests/qtest/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+), 5 deletions(-)

-- 
2.19.1

Re: [PATCH v4 0/2] add new options to set smbios type 4 fields

Posted by Igor Mammedov 5 years, 7 months ago

On Wed, 18 Mar 2020 14:48:18 +0800
Heyi Guo <guoheyi@huawei.com> wrote:

> Common VM users sometimes care about CPU speed, so we add two new
> options to allow VM vendors to present CPU speed to their users.
> Normally these information can be fetched from host smbios.

it's probably too late for this series due to soft-freeze,
pls repost once 5.0 is released

> 
> v3 -> v4:
> - Fix the default value when not specifying "-smbios type=4" option;
>   it would be 0 instead of 2000 in previous versions
> - Use uint64_t type to check value overflow
> - Add test case to check smbios type 4 CPU speed
> 
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Igor Mammedov <imammedo@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Laurent Vivier <lvivier@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> 
> Heyi Guo (2):
>   hw/smbios: add options for type 4 max-speed and current-speed
>   tests/bios-tables-test: add smbios cpu speed test
> 
>  hw/smbios/smbios.c             | 36 +++++++++++++++++++++++++----
>  qemu-options.hx                |  3 ++-
>  tests/qtest/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++
>  3 files changed, 76 insertions(+), 5 deletions(-)
>

Re: [PATCH v4 0/2] add new options to set smbios type 4 fields

Posted by Heyi Guo 5 years, 7 months ago

On 2020/3/19 22:46, Igor Mammedov wrote:
> On Wed, 18 Mar 2020 14:48:18 +0800
> Heyi Guo <guoheyi@huawei.com> wrote:
>
>> Common VM users sometimes care about CPU speed, so we add two new
>> options to allow VM vendors to present CPU speed to their users.
>> Normally these information can be fetched from host smbios.
> it's probably too late for this series due to soft-freeze,
> pls repost once 5.0 is released

Ah, I didn't pay enough attention to the merge window.

When will the soft-freeze be ended? Will it be announced in the mailing 
list?

Thanks,

Heyi

>
>> v3 -> v4:
>> - Fix the default value when not specifying "-smbios type=4" option;
>>    it would be 0 instead of 2000 in previous versions
>> - Use uint64_t type to check value overflow
>> - Add test case to check smbios type 4 CPU speed
>>
>> Cc: "Michael S. Tsirkin" <mst@redhat.com>
>> Cc: Igor Mammedov <imammedo@redhat.com>
>> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
>> Cc: Thomas Huth <thuth@redhat.com>
>> Cc: Laurent Vivier <lvivier@redhat.com>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>>
>> Heyi Guo (2):
>>    hw/smbios: add options for type 4 max-speed and current-speed
>>    tests/bios-tables-test: add smbios cpu speed test
>>
>>   hw/smbios/smbios.c             | 36 +++++++++++++++++++++++++----
>>   qemu-options.hx                |  3 ++-
>>   tests/qtest/bios-tables-test.c | 42 ++++++++++++++++++++++++++++++++++
>>   3 files changed, 76 insertions(+), 5 deletions(-)
>>
>
> .

Re: [PATCH v4 0/2] add new options to set smbios type 4 fields

Posted by Paolo Bonzini 5 years, 7 months ago

On 20/03/20 02:29, Heyi Guo wrote:
> 
> On 2020/3/19 22:46, Igor Mammedov wrote:
>> On Wed, 18 Mar 2020 14:48:18 +0800
>> Heyi Guo <guoheyi@huawei.com> wrote:
>>
>>> Common VM users sometimes care about CPU speed, so we add two new
>>> options to allow VM vendors to present CPU speed to their users.
>>> Normally these information can be fetched from host smbios.
>> it's probably too late for this series due to soft-freeze,
>> pls repost once 5.0 is released
> 
> Ah, I didn't pay enough attention to the merge window.
> 
> When will the soft-freeze be ended? Will it be announced in the mailing
> list?

You can repost about one month from now.  Thanks!

Paolo