Patchew URL: https://patchew.org/QEMU/20200316172155.971-1-alex.bennee@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v1 00/28 for 5.0] testing and gdbstub
Message-id: 20200316172155.971-1-alex.bennee@linaro.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
e0524af gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdb
e656163 gdbstub: do not split gdb_monitor_write payload
df8fd6f gdbstub: change GDBState.last_packet to GByteArray
95b6603 tests/tcg/aarch64: add test-sve-ioctl guest-debug test
c851ffe tests/tcg/aarch64: add SVE iotcl test
adc04ec tests/tcg/aarch64: add a gdbstub testcase for SVE registers
9601aa2 tests/guest-debug: add a simple test runner
7a2de8f configure: allow user to specify what gdb to use
d72d9b9 tests/tcg/aarch64: userspace system register test
d976fc7 target/arm: don't bother with id_aa64pfr0_read for USER_ONLY
493033c target/arm: generate xml description of our SVE registers
814a89b target/arm: default SVE length to 64 bytes for linux-user
b9f7216 target/arm: explicitly encode regnum in our XML
22d0e66 target/arm: prepare for multiple dynamic XMLs
63558ba gdbstub: extend GByteArray to read register helpers
f9304f8 target/i386: use gdb_get_reg helpers
adc03bd target/m68k: use gdb_get_reg helpers
e699c51 target/arm: use gdb_get_reg helpers
a14c7b1 gdbstub: add helper for 128 bit registers
19705a5 gdbstub: move mem_buf to GDBState and use GByteArray
6363732 gdbstub: move str_buf to GDBState and use GString
8a37f68 gdbstub: stop passing GDBState * around and use global
4c9afc0 gdbstub: make GDBState static and have common init function
8fe1b7d travis.yml: Set G_MESSAGES_DEBUG do report GLib errors
4bb9eee tests/docker: Update VirGL to v0.8.0
a416989 tests/docker: Remove obsolete VirGL --with-glx configure option
3da6470 tests/docker: Update VirGL git repository URL
efb4377 tests/docker: Install tools to cross-debug and build Linux kernels
=== OUTPUT BEGIN ===
1/28 Checking commit efb4377dce97 (tests/docker: Install tools to cross-debug and build Linux kernels)
2/28 Checking commit 3da64700cb80 (tests/docker: Update VirGL git repository URL)
3/28 Checking commit a4169891e970 (tests/docker: Remove obsolete VirGL --with-glx configure option)
4/28 Checking commit 4bb9eee827e6 (tests/docker: Update VirGL to v0.8.0)
5/28 Checking commit 8fe1b7d3f9a2 (travis.yml: Set G_MESSAGES_DEBUG do report GLib errors)
6/28 Checking commit 4c9afc0c7180 (gdbstub: make GDBState static and have common init function)
ERROR: braces {} are necessary for all arms of this statement
#128: FILE: gdbstub.c:2743:
+ if (!gdbserver_state.init)
[...]
ERROR: suspect code indent for conditional statements (2, 6)
#178: FILE: gdbstub.c:2962:
+ if (!gdbserver_state.init) {
return;
ERROR: suspect code indent for conditional statements (2, 6)
#183: FILE: gdbstub.c:2966:
+ if (gdbserver_fd < 0 || gdbserver_state.fd < 0) {
return;
total: 3 errors, 0 warnings, 384 lines checked
Patch 6/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/28 Checking commit 8a37f68bbf8a (gdbstub: stop passing GDBState * around and use global)
WARNING: line over 80 characters
#756: FILE: gdbstub.c:1762:
+ if (target_memory_rw_debug(gdbserver_state.g_cpu, gdb_ctx->params[0].val_ull,
WARNING: line over 80 characters
#784: FILE: gdbstub.c:1785:
+ if (target_memory_rw_debug(gdbserver_state.g_cpu, gdb_ctx->params[0].val_ull,
WARNING: line over 80 characters
#1011: FILE: gdbstub.c:2022:
+ gdbserver_state.query_cpu = gdb_next_attached_cpu(gdbserver_state.query_cpu);
ERROR: line over 90 characters
#1372: FILE: gdbstub.c:2817:
+ put_buffer((uint8_t *)gdbserver_state.last_packet, gdbserver_state.last_packet_len);
ERROR: space required before the open parenthesis '('
#1390: FILE: gdbstub.c:2836:
+ switch(gdbserver_state.state) {
ERROR: line over 90 characters
#1422: FILE: gdbstub.c:2859:
+ } else if (gdbserver_state.line_buf_index >= sizeof(gdbserver_state.line_buf) - 1) {
ERROR: line over 90 characters
#1440: FILE: gdbstub.c:2872:
+ } else if (gdbserver_state.line_buf_index >= sizeof(gdbserver_state.line_buf) - 1) {
WARNING: line over 80 characters
#1450: FILE: gdbstub.c:2878:
+ gdbserver_state.line_buf[gdbserver_state.line_buf_index++] = ch ^ 0x20;
ERROR: line over 90 characters
#1466: FILE: gdbstub.c:2895:
+ if (gdbserver_state.line_buf_index + repeat >= sizeof(gdbserver_state.line_buf) - 1) {
WARNING: line over 80 characters
#1484: FILE: gdbstub.c:2905:
+ memset(gdbserver_state.line_buf + gdbserver_state.line_buf_index,
ERROR: line over 90 characters
#1485: FILE: gdbstub.c:2906:
+ gdbserver_state.line_buf[gdbserver_state.line_buf_index - 1], repeat);
WARNING: line over 80 characters
#1520: FILE: gdbstub.c:2933:
+ if (gdbserver_state.line_csum != (gdbserver_state.line_sum & 0xff)) {
ERROR: line over 90 characters
#1521: FILE: gdbstub.c:2934:
+ trace_gdbstub_err_checksum_incorrect(gdbserver_state.line_sum, gdbserver_state.line_csum);
WARNING: line over 80 characters
#1534: FILE: gdbstub.c:2943:
+ gdbserver_state.state = gdb_handle_packet(gdbserver_state.line_buf);
ERROR: line over 90 characters
#1649: FILE: gdbstub.c:3305:
+ qsort(gdbserver_state.processes, gdbserver_state.process_num, sizeof(gdbserver_state.processes[0]), pid_order);
total: 8 errors, 7 warnings, 1553 lines checked
Patch 7/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/28 Checking commit 6363732dc5c8 (gdbstub: move str_buf to GDBState and use GString)
WARNING: line over 80 characters
#150: FILE: gdbstub.c:1794:
+ memtohex(gdbserver_state.str_buf, gdb_ctx->mem_buf, gdb_ctx->params[1].val_ull);
WARNING: line over 80 characters
#323: FILE: gdbstub.c:2107:
+ g_string_printf(gdbserver_state.str_buf, "PacketSize=%x", MAX_PACKET_LENGTH);
total: 0 errors, 2 warnings, 422 lines checked
Patch 8/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/28 Checking commit 19705a523de4 (gdbstub: move mem_buf to GDBState and use GByteArray)
10/28 Checking commit a14c7b1ee74c (gdbstub: add helper for 128 bit registers)
11/28 Checking commit e699c51289c7 (target/arm: use gdb_get_reg helpers)
ERROR: space required after that ',' (ctx:VxV)
#45: FILE: target/arm/helper.c:119:
+ return gdb_get_reg32(buf,vfp_get_fpcr(env));
^
total: 1 errors, 0 warnings, 28 lines checked
Patch 11/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/28 Checking commit adc03bd59ded (target/m68k: use gdb_get_reg helpers)
13/28 Checking commit f9304f8e2d1e (target/i386: use gdb_get_reg helpers)
ERROR: space prohibited after that '*' (ctx:BxW)
#62: FILE: target/i386/gdbstub.c:290:
+ fp->low = le64_to_cpu(* (uint64_t *) mem_buf);
^
ERROR: space prohibited after that '*' (ctx:BxW)
#63: FILE: target/i386/gdbstub.c:291:
+ fp->high = le16_to_cpu(* (uint16_t *) (mem_buf + 8));
^
total: 2 errors, 0 warnings, 47 lines checked
Patch 13/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/28 Checking commit 63558bae2227 (gdbstub: extend GByteArray to read register helpers)
ERROR: "foo * bar" should be "foo *bar"
#198: FILE: include/exec/gdbstub.h:136:
+static inline uint8_t * gdb_get_reg_ptr(GByteArray *buf, int len)
total: 1 errors, 0 warnings, 918 lines checked
Patch 14/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/28 Checking commit 22d0e66f578e (target/arm: prepare for multiple dynamic XMLs)
ERROR: line over 90 characters
#128: FILE: target/arm/gdbstub.c:159:
+ cpu->dyn_sysreg_xml.data.cpregs.keys = g_new(uint32_t, g_hash_table_size(cpu->cp_regs));
total: 1 errors, 0 warnings, 136 lines checked
Patch 15/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/28 Checking commit b9f72163ab90 (target/arm: explicitly encode regnum in our XML)
17/28 Checking commit 814a89b3a60c (target/arm: default SVE length to 64 bytes for linux-user)
18/28 Checking commit 493033cef70a (target/arm: generate xml description of our SVE registers)
WARNING: line over 80 characters
#108: FILE: target/arm/gdbstub.c:233:
+ g_string_append_printf(s, "<field name=\"%c\" type=\"vq%d%c%c\"/>",
WARNING: line over 80 characters
#329: FILE: target/arm/helper.c:8074:
+ arm_gen_dynamic_svereg_xml(cs, cs->gdb_num_regs),
total: 0 errors, 2 warnings, 316 lines checked
Patch 18/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/28 Checking commit d976fc7378bf (target/arm: don't bother with id_aa64pfr0_read for USER_ONLY)
20/28 Checking commit d72d9b9a4f21 (tests/tcg/aarch64: userspace system register test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
new file mode 100644
ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:115:
+ get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
^
ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:115:
+ get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
^
ERROR: space required after that ',' (ctx:VxV)
#152: FILE: tests/tcg/aarch64/sysregs.c:115:
+ get_cpu_reg_check_mask(id_aa64isar0_el1, _m(00ff,ffff,f0ff,fff0));
^
ERROR: space required after that ',' (ctx:VxV)
#153: FILE: tests/tcg/aarch64/sysregs.c:116:
+ get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#153: FILE: tests/tcg/aarch64/sysregs.c:116:
+ get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#153: FILE: tests/tcg/aarch64/sysregs.c:116:
+ get_cpu_reg_check_mask(id_aa64isar1_el1, _m(0000,00f0,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#155: FILE: tests/tcg/aarch64/sysregs.c:118:
+ get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
^
ERROR: space required after that ',' (ctx:VxV)
#155: FILE: tests/tcg/aarch64/sysregs.c:118:
+ get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
^
ERROR: space required after that ',' (ctx:VxV)
#155: FILE: tests/tcg/aarch64/sysregs.c:118:
+ get_cpu_reg_check_mask(id_aa64mmfr0_el1, _m(0000,0000,ff00,0000));
^
ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:121:
+ get_cpu_reg_check_mask(id_aa64pfr0_el1, _m(000f,000f,00ff,0011));
^
ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:121:
+ get_cpu_reg_check_mask(id_aa64pfr0_el1, _m(000f,000f,00ff,0011));
^
ERROR: space required after that ',' (ctx:VxV)
#158: FILE: tests/tcg/aarch64/sysregs.c:121:
+ get_cpu_reg_check_mask(id_aa64pfr0_el1, _m(000f,000f,00ff,0011));
^
ERROR: space required after that ',' (ctx:VxV)
#159: FILE: tests/tcg/aarch64/sysregs.c:122:
+ get_cpu_reg_check_mask(id_aa64pfr1_el1, _m(0000,0000,0000,00f0));
^
ERROR: space required after that ',' (ctx:VxV)
#159: FILE: tests/tcg/aarch64/sysregs.c:122:
+ get_cpu_reg_check_mask(id_aa64pfr1_el1, _m(0000,0000,0000,00f0));
^
ERROR: space required after that ',' (ctx:VxV)
#159: FILE: tests/tcg/aarch64/sysregs.c:122:
+ get_cpu_reg_check_mask(id_aa64pfr1_el1, _m(0000,0000,0000,00f0));
^
ERROR: space required after that ',' (ctx:VxV)
#161: FILE: tests/tcg/aarch64/sysregs.c:124:
+ get_cpu_reg_check_mask(id_aa64dfr0_el1, _m(0000,0000,0000,0006));
^
ERROR: space required after that ',' (ctx:VxV)
#161: FILE: tests/tcg/aarch64/sysregs.c:124:
+ get_cpu_reg_check_mask(id_aa64dfr0_el1, _m(0000,0000,0000,0006));
^
ERROR: space required after that ',' (ctx:VxV)
#161: FILE: tests/tcg/aarch64/sysregs.c:124:
+ get_cpu_reg_check_mask(id_aa64dfr0_el1, _m(0000,0000,0000,0006));
^
ERROR: space required after that ',' (ctx:VxV)
#168: FILE: tests/tcg/aarch64/sysregs.c:131:
+ get_cpu_reg_check_mask(midr_el1, _m(0000,0000,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#168: FILE: tests/tcg/aarch64/sysregs.c:131:
+ get_cpu_reg_check_mask(midr_el1, _m(0000,0000,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#168: FILE: tests/tcg/aarch64/sysregs.c:131:
+ get_cpu_reg_check_mask(midr_el1, _m(0000,0000,ffff,ffff));
^
ERROR: space required after that ',' (ctx:VxV)
#170: FILE: tests/tcg/aarch64/sysregs.c:133:
+ get_cpu_reg_check_mask(mpidr_el1, _m(0000,0000,8000,0000));
^
ERROR: space required after that ',' (ctx:VxV)
#170: FILE: tests/tcg/aarch64/sysregs.c:133:
+ get_cpu_reg_check_mask(mpidr_el1, _m(0000,0000,8000,0000));
^
ERROR: space required after that ',' (ctx:VxV)
#170: FILE: tests/tcg/aarch64/sysregs.c:133:
+ get_cpu_reg_check_mask(mpidr_el1, _m(0000,0000,8000,0000));
^
total: 24 errors, 1 warnings, 182 lines checked
Patch 20/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/28 Checking commit 7a2de8fb5f2d (configure: allow user to specify what gdb to use)
22/28 Checking commit 9601aa27ce94 (tests/guest-debug: add a simple test runner)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100755
ERROR: line over 90 characters
#73: FILE: tests/guest-debug/run-test.py:53:
+ gdb_cmd = "%s %s -ex 'target remote localhost:1234' -x %s" % (args.gdb, args.binary, args.test)
total: 1 errors, 1 warnings, 57 lines checked
Patch 22/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/28 Checking commit adc04ecd2aec (tests/tcg/aarch64: add a gdbstub testcase for SVE registers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644
total: 0 errors, 1 warnings, 109 lines checked
Patch 23/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
24/28 Checking commit c851ffe4b294 (tests/tcg/aarch64: add SVE iotcl test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644
total: 0 errors, 1 warnings, 80 lines checked
Patch 24/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/28 Checking commit 95b6603a4ba2 (tests/tcg/aarch64: add test-sve-ioctl guest-debug test)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45:
new file mode 100644
total: 0 errors, 1 warnings, 106 lines checked
Patch 25/28 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/28 Checking commit df8fd6fdbd42 (gdbstub: change GDBState.last_packet to GByteArray)
27/28 Checking commit e656163622cb (gdbstub: do not split gdb_monitor_write payload)
28/28 Checking commit e0524af2bb5a (gdbstub: Fix single-step issue by confirming 'vContSupported+' feature to gdb)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200316172155.971-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com