The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506:

  qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +0000)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request

for you to fetch changes up to 63e05b3db1e5f0560ae579050c53d1ee36ed5aca:

  linux-user, openrisc: sync syscall numbers with kernel v5.5 (2020-03-16 14:20:07 +0100)

----------------------------------------------------------------
update syscall numbers to linux 5.5 (with scripts)
add futex_time64/clock_gettime64/clock_settime64
add AT_EXECFN
Emulate x86_64 vsyscalls

----------------------------------------------------------------

Alistair Francis (4):
  linux-user: Protect more syscalls
  linux-user/syscall: Add support for clock_gettime64/clock_settime64
  linux-user: Support futex_time64
  linux-user/riscv: Update the syscall_nr's to the 5.5 kernel

Laurent Vivier (26):
  linux-user: fix socket() strace
  linux-user: introduce parameters to generate syscall_nr.h
  linux-user, alpha: add syscall table generation support
  linux-user, hppa: add syscall table generation support
  linux-user, m68k: add syscall table generation support
  linux-user, xtensa: add syscall table generation support
  linux-user, sh4: add syscall table generation support
  linux-user, microblaze: add syscall table generation support
  linux-user, arm: add syscall table generation support
  linux-user, ppc: add syscall table generation support
  linux-user, s390x: remove syscall definitions for !TARGET_S390X
  linux-user, s390x: add syscall table generation support
  linux-user, sparc, sparc64: add syscall table generation support
  linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
  linux-user, i386: add syscall table generation support
  linux-user, x86_64: add syscall table generation support
  linux-user, mips: add syscall table generation support
  linux-user, mips64: add syscall table generation support
  linux-user, scripts: add a script to update syscall.tbl
  linux-user: update syscall.tbl from linux 0bf999f9c5e7
  linux-user,mips: move content of mips_syscall_args
  linux-user,mips: update syscall-args-o32.c.inc
  scripts: add a script to generate syscall_nr.h
  linux-user, aarch64: sync syscall numbers with kernel v5.5
  linux-user, nios2: sync syscall numbers with kernel v5.5
  linux-user, openrisc: sync syscall numbers with kernel v5.5

Lirong Yuan (2):
  linux-user: Add AT_EXECFN auxval
  linux-user: Update TASK_UNMAPPED_BASE for aarch64

Richard Henderson (5):
  target/i386: Renumber EXCP_SYSCALL
  linux-user/i386: Split out gen_signal
  linux-user/i386: Emulate x86_64 vsyscalls
  linux-user: Add x86_64 vsyscall page to /proc/self/maps
  linux-user: Flush out implementation of gettimeofday

Tobias Koch (1):
  linux-user: do prlimit selectively

 MAINTAINERS                            |   3 +
 Makefile.target                        |   3 +-
 configure                              |  35 ++
 linux-user/Makefile.objs               |  19 +-
 linux-user/aarch64/syscall_nr.h        |  34 +-
 linux-user/alpha/Makefile.objs         |   5 +
 linux-user/alpha/syscall.tbl           | 479 ++++++++++++++++
 linux-user/alpha/syscall_nr.h          | 492 -----------------
 linux-user/alpha/syscallhdr.sh         |  32 ++
 linux-user/arm/Makefile.objs           |   8 +
 linux-user/arm/syscall.tbl             | 453 +++++++++++++++
 linux-user/arm/syscall_nr.h            | 447 ---------------
 linux-user/arm/syscallhdr.sh           |  31 ++
 linux-user/elfload.c                   |   3 +-
 linux-user/hppa/Makefile.objs          |   5 +
 linux-user/hppa/syscall.tbl            | 437 +++++++++++++++
 linux-user/hppa/syscall_nr.h           | 358 ------------
 linux-user/hppa/syscallhdr.sh          |  32 ++
 linux-user/i386/Makefile.objs          |   5 +
 linux-user/i386/cpu_loop.c             | 201 +++++--
 linux-user/i386/syscall_32.tbl         | 444 +++++++++++++++
 linux-user/i386/syscall_nr.h           | 387 -------------
 linux-user/i386/syscallhdr.sh          |  28 +
 linux-user/i386/target_cpu.h           |   4 +-
 linux-user/m68k/Makefile.objs          |   5 +
 linux-user/m68k/syscall.tbl            | 439 +++++++++++++++
 linux-user/m68k/syscall_nr.h           | 434 ---------------
 linux-user/m68k/syscallhdr.sh          |  32 ++
 linux-user/microblaze/Makefile.objs    |   5 +
 linux-user/microblaze/syscall.tbl      | 445 +++++++++++++++
 linux-user/microblaze/syscall_nr.h     | 442 ---------------
 linux-user/microblaze/syscallhdr.sh    |  32 ++
 linux-user/mips/Makefile.objs          |   5 +
 linux-user/mips/cpu_loop.c             | 440 +--------------
 linux-user/mips/syscall-args-o32.c.inc | 436 +++++++++++++++
 linux-user/mips/syscall_nr.h           | 425 ---------------
 linux-user/mips/syscall_o32.tbl        | 427 +++++++++++++++
 linux-user/mips/syscallhdr.sh          |  36 ++
 linux-user/mips64/Makefile.objs        |  12 +
 linux-user/mips64/syscall_n32.tbl      | 378 +++++++++++++
 linux-user/mips64/syscall_n64.tbl      | 354 ++++++++++++
 linux-user/mips64/syscall_nr.h         | 725 -------------------------
 linux-user/mips64/syscallhdr.sh        |  33 ++
 linux-user/mmap.c                      |   4 +
 linux-user/nios2/syscall_nr.h          | 650 +++++++++++-----------
 linux-user/openrisc/syscall_nr.h       | 309 +++--------
 linux-user/ppc/Makefile.objs           |   6 +
 linux-user/ppc/signal.c                |   2 +-
 linux-user/ppc/syscall.tbl             | 521 ++++++++++++++++++
 linux-user/ppc/syscall_nr.h            | 402 --------------
 linux-user/ppc/syscallhdr.sh           |  34 ++
 linux-user/riscv/syscall32_nr.h        | 295 ++++++++++
 linux-user/riscv/syscall64_nr.h        | 301 ++++++++++
 linux-user/riscv/syscall_nr.h          | 294 +---------
 linux-user/s390x/Makefile.objs         |   5 +
 linux-user/s390x/syscall.tbl           | 442 +++++++++++++++
 linux-user/s390x/syscall_nr.h          | 398 --------------
 linux-user/s390x/syscallhdr.sh         |  32 ++
 linux-user/sh4/Makefile.objs           |   5 +
 linux-user/sh4/syscall.tbl             | 442 +++++++++++++++
 linux-user/sh4/syscall_nr.h            | 441 ---------------
 linux-user/sh4/syscallhdr.sh           |  32 ++
 linux-user/sparc/Makefile.objs         |   5 +
 linux-user/sparc/syscall.tbl           | 485 +++++++++++++++++
 linux-user/sparc/syscall_nr.h          | 363 -------------
 linux-user/sparc/syscallhdr.sh         |  32 ++
 linux-user/sparc64/Makefile.objs       |   5 +
 linux-user/sparc64/syscall.tbl         | 485 +++++++++++++++++
 linux-user/sparc64/syscall_nr.h        | 366 -------------
 linux-user/sparc64/syscallhdr.sh       |  32 ++
 linux-user/strace.c                    |  10 +-
 linux-user/syscall.c                   | 314 ++++++++++-
 linux-user/x86_64/Makefile.objs        |   5 +
 linux-user/x86_64/syscall_64.tbl       | 404 ++++++++++++++
 linux-user/x86_64/syscall_nr.h         | 356 ------------
 linux-user/x86_64/syscallhdr.sh        |  28 +
 linux-user/xtensa/Makefile.objs        |   5 +
 linux-user/xtensa/syscall.tbl          | 410 ++++++++++++++
 linux-user/xtensa/syscall_nr.h         | 469 ----------------
 linux-user/xtensa/syscallhdr.sh        |  32 ++
 scripts/gensyscalls.sh                 | 102 ++++
 scripts/update-mips-syscall-args.sh    |  57 ++
 scripts/update-syscalltbl.sh           |  49 ++
 target/i386/cpu.h                      |  12 +-
 target/i386/translate.c                |  14 +-
 85 files changed, 9791 insertions(+), 7914 deletions(-)
 create mode 100644 linux-user/alpha/Makefile.objs
 create mode 100644 linux-user/alpha/syscall.tbl
 delete mode 100644 linux-user/alpha/syscall_nr.h
 create mode 100644 linux-user/alpha/syscallhdr.sh
 create mode 100644 linux-user/arm/Makefile.objs
 create mode 100644 linux-user/arm/syscall.tbl
 delete mode 100644 linux-user/arm/syscall_nr.h
 create mode 100644 linux-user/arm/syscallhdr.sh
 create mode 100644 linux-user/hppa/Makefile.objs
 create mode 100644 linux-user/hppa/syscall.tbl
 delete mode 100644 linux-user/hppa/syscall_nr.h
 create mode 100644 linux-user/hppa/syscallhdr.sh
 create mode 100644 linux-user/i386/Makefile.objs
 create mode 100644 linux-user/i386/syscall_32.tbl
 delete mode 100644 linux-user/i386/syscall_nr.h
 create mode 100644 linux-user/i386/syscallhdr.sh
 create mode 100644 linux-user/m68k/Makefile.objs
 create mode 100644 linux-user/m68k/syscall.tbl
 delete mode 100644 linux-user/m68k/syscall_nr.h
 create mode 100644 linux-user/m68k/syscallhdr.sh
 create mode 100644 linux-user/microblaze/Makefile.objs
 create mode 100644 linux-user/microblaze/syscall.tbl
 delete mode 100644 linux-user/microblaze/syscall_nr.h
 create mode 100644 linux-user/microblaze/syscallhdr.sh
 create mode 100644 linux-user/mips/Makefile.objs
 create mode 100644 linux-user/mips/syscall-args-o32.c.inc
 delete mode 100644 linux-user/mips/syscall_nr.h
 create mode 100644 linux-user/mips/syscall_o32.tbl
 create mode 100644 linux-user/mips/syscallhdr.sh
 create mode 100644 linux-user/mips64/Makefile.objs
 create mode 100644 linux-user/mips64/syscall_n32.tbl
 create mode 100644 linux-user/mips64/syscall_n64.tbl
 delete mode 100644 linux-user/mips64/syscall_nr.h
 create mode 100644 linux-user/mips64/syscallhdr.sh
 create mode 100644 linux-user/ppc/Makefile.objs
 create mode 100644 linux-user/ppc/syscall.tbl
 delete mode 100644 linux-user/ppc/syscall_nr.h
 create mode 100644 linux-user/ppc/syscallhdr.sh
 create mode 100644 linux-user/riscv/syscall32_nr.h
 create mode 100644 linux-user/riscv/syscall64_nr.h
 create mode 100644 linux-user/s390x/Makefile.objs
 create mode 100644 linux-user/s390x/syscall.tbl
 delete mode 100644 linux-user/s390x/syscall_nr.h
 create mode 100755 linux-user/s390x/syscallhdr.sh
 create mode 100644 linux-user/sh4/Makefile.objs
 create mode 100644 linux-user/sh4/syscall.tbl
 delete mode 100644 linux-user/sh4/syscall_nr.h
 create mode 100644 linux-user/sh4/syscallhdr.sh
 create mode 100644 linux-user/sparc/Makefile.objs
 create mode 100644 linux-user/sparc/syscall.tbl
 delete mode 100644 linux-user/sparc/syscall_nr.h
 create mode 100644 linux-user/sparc/syscallhdr.sh
 create mode 100644 linux-user/sparc64/Makefile.objs
 create mode 100644 linux-user/sparc64/syscall.tbl
 delete mode 100644 linux-user/sparc64/syscall_nr.h
 create mode 100644 linux-user/sparc64/syscallhdr.sh
 create mode 100644 linux-user/x86_64/Makefile.objs
 create mode 100644 linux-user/x86_64/syscall_64.tbl
 delete mode 100644 linux-user/x86_64/syscall_nr.h
 create mode 100644 linux-user/x86_64/syscallhdr.sh
 create mode 100644 linux-user/xtensa/Makefile.objs
 create mode 100644 linux-user/xtensa/syscall.tbl
 delete mode 100644 linux-user/xtensa/syscall_nr.h
 create mode 100644 linux-user/xtensa/syscallhdr.sh
 create mode 100755 scripts/gensyscalls.sh
 create mode 100755 scripts/update-mips-syscall-args.sh
 create mode 100755 scripts/update-syscalltbl.sh

-- 
2.24.1

On Mon, 16 Mar 2020 at 17:43, Laurent Vivier <laurent@vivier.eu> wrote:
>
> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506:
>
>   qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +0000)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>
> for you to fetch changes up to 63e05b3db1e5f0560ae579050c53d1ee36ed5aca:
>
>   linux-user, openrisc: sync syscall numbers with kernel v5.5 (2020-03-16 14:20:07 +0100)
>
> ----------------------------------------------------------------
> update syscall numbers to linux 5.5 (with scripts)
> add futex_time64/clock_gettime64/clock_settime64
> add AT_EXECFN
> Emulate x86_64 vsyscalls

Compile failure, aarch32:

/home/peter.maydell/qemu/linux-user/syscall.c: In function 'do_sys_futex':
/home/peter.maydell/qemu/linux-user/syscall.c:6946:16: error: implicit
declaration of function 'sys_futex_time64'; did you mean
'safe_futex_time64'? [-Werror=implicit-function-declaration]
         return sys_futex_time64(uaddr, op, val, timeout, uaddr2, val3);
                ^~~~~~~~~~~~~~~~
                safe_futex_time64


Compile failure, x86-64 with clang:

/home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:1291:24:
error: unused function 'copy_to_user_timezone'
[-Werror,-Wunused-function]
static inline abi_long copy_to_user_timezone(abi_ulong target_tz_addr,
                       ^
1 error generated.
/home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
'linux-user/syscall.o' failed


thanks
-- PMM

Le 16/03/2020 à 20:17, Peter Maydell a écrit :
> On Mon, 16 Mar 2020 at 17:43, Laurent Vivier <laurent@vivier.eu> wrote:
>>
>> The following changes since commit 373c7068dd610e97f0b551b5a6d0a27cd6da4506:
>>
>>   qemu.nsi: Install Sphinx documentation (2020-03-09 16:45:00 +0000)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>
>> for you to fetch changes up to 63e05b3db1e5f0560ae579050c53d1ee36ed5aca:
>>
>>   linux-user, openrisc: sync syscall numbers with kernel v5.5 (2020-03-16 14:20:07 +0100)
>>
>> ----------------------------------------------------------------
>> update syscall numbers to linux 5.5 (with scripts)
>> add futex_time64/clock_gettime64/clock_settime64
>> add AT_EXECFN
>> Emulate x86_64 vsyscalls
> 
> Compile failure, aarch32:
> 
> /home/peter.maydell/qemu/linux-user/syscall.c: In function 'do_sys_futex':
> /home/peter.maydell/qemu/linux-user/syscall.c:6946:16: error: implicit
> declaration of function 'sys_futex_time64'; did you mean
> 'safe_futex_time64'? [-Werror=implicit-function-declaration]
>          return sys_futex_time64(uaddr, op, val, timeout, uaddr2, val3);
>                 ^~~~~~~~~~~~~~~~
>                 safe_futex_time64
> 
> 
> Compile failure, x86-64 with clang:
> 
> /home/petmay01/linaro/qemu-for-merges/linux-user/syscall.c:1291:24:
> error: unused function 'copy_to_user_timezone'
> [-Werror,-Wunused-function]
> static inline abi_long copy_to_user_timezone(abi_ulong target_tz_addr,
>                        ^
> 1 error generated.
> /home/petmay01/linaro/qemu-for-merges/rules.mak:69: recipe for target
> 'linux-user/syscall.o' failed

Thank you.

I remove it from the list and re-send the pull request.

Laurent

Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: 20200316161550.336150-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
fee33bd linux-user, openrisc: sync syscall numbers with kernel v5.5
fd2f311 linux-user, nios2: sync syscall numbers with kernel v5.5
6a5d29c linux-user, aarch64: sync syscall numbers with kernel v5.5
0f61c49 scripts: add a script to generate syscall_nr.h
ba74d13 linux-user,mips: update syscall-args-o32.c.inc
6093ee8 linux-user,mips: move content of mips_syscall_args
329d3cf linux-user: update syscall.tbl from linux 0bf999f9c5e7
fdd68d1 linux-user, scripts: add a script to update syscall.tbl
39929e8 linux-user, mips64: add syscall table generation support
cd6dd35 linux-user, mips: add syscall table generation support
890ff9d linux-user, x86_64: add syscall table generation support
353fb76 linux-user, i386: add syscall table generation support
9db49be linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
9da00a8 linux-user, sparc, sparc64: add syscall table generation support
e7dfa49 linux-user, s390x: add syscall table generation support
07108d6 linux-user, s390x: remove syscall definitions for !TARGET_S390X
0a1acf7 linux-user, ppc: add syscall table generation support
48126a9 linux-user, arm: add syscall table generation support
13a5cdd linux-user, microblaze: add syscall table generation support
ea958ad linux-user, sh4: add syscall table generation support
2599c73 linux-user, xtensa: add syscall table generation support
9764b87 linux-user, m68k: add syscall table generation support
52d7b45 linux-user, hppa: add syscall table generation support
baeb698 linux-user, alpha: add syscall table generation support
b3d6a3d linux-user: introduce parameters to generate syscall_nr.h
c4be834 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
e9992a7 linux-user: Support futex_time64
022b88e linux-user/syscall: Add support for clock_gettime64/clock_settime64
0bf2c2d linux-user: Protect more syscalls
fc4fcbe linux-user: Update TASK_UNMAPPED_BASE for aarch64
0e97ba7 linux-user: fix socket() strace
99fda14 linux-user: do prlimit selectively
8eb735a linux-user: Add AT_EXECFN auxval
571a225 linux-user: Flush out implementation of gettimeofday
092c4cc linux-user: Add x86_64 vsyscall page to /proc/self/maps
d1a6687 linux-user/i386: Emulate x86_64 vsyscalls
169e4fb linux-user/i386: Split out gen_signal
dfc6a82 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit dfc6a82f8f0a (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit 169e4fb16716 (linux-user/i386: Split out gen_signal)
3/38 Checking commit d1a668759f5b (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 092c4ccea82d (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
5/38 Checking commit 571a225e5502 (linux-user: Flush out implementation of gettimeofday)
6/38 Checking commit 8eb735a75f6a (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit 99fda143c672 (linux-user: do prlimit selectively)
8/38 Checking commit 0e97ba7c8e8e (linux-user: fix socket() strace)
9/38 Checking commit fc4fcbe8aae4 (linux-user: Update TASK_UNMAPPED_BASE for aarch64)
10/38 Checking commit 0bf2c2d4158a (linux-user: Protect more syscalls)
11/38 Checking commit 022b88e1c6bd (linux-user/syscall: Add support for clock_gettime64/clock_settime64)
12/38 Checking commit e9992a7e4a00 (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit c4be83414339 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit b3d6a3dcfe70 (linux-user: introduce parameters to generate syscall_nr.h)
15/38 Checking commit baeb698b9306 (linux-user, alpha: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit 52d7b45efd03 (linux-user, hppa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit 9764b87461da (linux-user, m68k: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit 2599c73b5bdb (linux-user, xtensa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit ea958add11f3 (linux-user, sh4: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 13a5cddfae33 (linux-user, microblaze: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 48126a917e3d (linux-user, arm: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 0a1acf77ecde (linux-user, ppc: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit 07108d6e6087 (linux-user, s390x: remove syscall definitions for !TARGET_S390X)
24/38 Checking commit e7dfa49f0460 (linux-user, s390x: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit 9da00a843cbf (linux-user, sparc, sparc64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 9db49bea0808 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl)
27/38 Checking commit 353fb76ec26f (linux-user, i386: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 890ff9d1b11d (linux-user, x86_64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit cd6dd35e397a (linux-user, mips: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 39929e8aeb2c (linux-user, mips64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit fdd68d1d7569 (linux-user, scripts: add a script to update syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit 329d3cf038c3 (linux-user: update syscall.tbl from linux 0bf999f9c5e7)
33/38 Checking commit 6093ee87e3ba (linux-user,mips: move content of mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit ba74d13404a4 (linux-user,mips: update syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit 0f61c4904ada (scripts: add a script to generate syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit 6a5d29c054a4 (linux-user, aarch64: sync syscall numbers with kernel v5.5)
37/38 Checking commit fd2f311991d3 (linux-user, nios2: sync syscall numbers with kernel v5.5)
38/38 Checking commit fee33bdd3665 (linux-user, openrisc: sync syscall numbers with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200316161550.336150-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: 20200316161550.336150-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200316161550.336150-1-laurent@vivier.eu -> patchew/20200316161550.336150-1-laurent@vivier.eu
Switched to a new branch 'test'
1bc4578 linux-user, openrisc: sync syscall numbers with kernel v5.5
275bdae linux-user, nios2: sync syscall numbers with kernel v5.5
d7f7755 linux-user, aarch64: sync syscall numbers with kernel v5.5
d274711 scripts: add a script to generate syscall_nr.h
b3e9680 linux-user,mips: update syscall-args-o32.c.inc
e26a1be linux-user,mips: move content of mips_syscall_args
e1cac57 linux-user: update syscall.tbl from linux 0bf999f9c5e7
3a51017 linux-user, scripts: add a script to update syscall.tbl
2c2876d linux-user, mips64: add syscall table generation support
20353f9 linux-user, mips: add syscall table generation support
2760210 linux-user, x86_64: add syscall table generation support
c280817 linux-user, i386: add syscall table generation support
1458029 linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
9478b8e linux-user, sparc, sparc64: add syscall table generation support
1553992 linux-user, s390x: add syscall table generation support
fbd36b7 linux-user, s390x: remove syscall definitions for !TARGET_S390X
3c686ee linux-user, ppc: add syscall table generation support
76525c6 linux-user, arm: add syscall table generation support
9402b9f linux-user, microblaze: add syscall table generation support
97fee9a linux-user, sh4: add syscall table generation support
ef7c323 linux-user, xtensa: add syscall table generation support
a1150d5 linux-user, m68k: add syscall table generation support
ceb7559 linux-user, hppa: add syscall table generation support
b7160c7 linux-user, alpha: add syscall table generation support
7900d95 linux-user: introduce parameters to generate syscall_nr.h
02ba121 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
19eb9e3 linux-user: Support futex_time64
b9b6629 linux-user/syscall: Add support for clock_gettime64/clock_settime64
4ebab6c linux-user: Protect more syscalls
baa0e71 linux-user: Update TASK_UNMAPPED_BASE for aarch64
4fcfda0 linux-user: fix socket() strace
13110bd linux-user: do prlimit selectively
a99c994 linux-user: Add AT_EXECFN auxval
b006c5c linux-user: Flush out implementation of gettimeofday
6bdd12d linux-user: Add x86_64 vsyscall page to /proc/self/maps
e65d100 linux-user/i386: Emulate x86_64 vsyscalls
e90a705 linux-user/i386: Split out gen_signal
8703c17 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit 8703c1770f3e (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit e90a7057d9fa (linux-user/i386: Split out gen_signal)
3/38 Checking commit e65d100c17e5 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 6bdd12d66dcb (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
5/38 Checking commit b006c5c97f9e (linux-user: Flush out implementation of gettimeofday)
6/38 Checking commit a99c994a9a7a (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit 13110bd183ea (linux-user: do prlimit selectively)
8/38 Checking commit 4fcfda0cbd8a (linux-user: fix socket() strace)
9/38 Checking commit baa0e71093cc (linux-user: Update TASK_UNMAPPED_BASE for aarch64)
10/38 Checking commit 4ebab6c489e6 (linux-user: Protect more syscalls)
11/38 Checking commit b9b6629bd329 (linux-user/syscall: Add support for clock_gettime64/clock_settime64)
12/38 Checking commit 19eb9e3d100b (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit 02ba121e2143 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit 7900d95851ba (linux-user: introduce parameters to generate syscall_nr.h)
15/38 Checking commit b7160c722d10 (linux-user, alpha: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit ceb755998c50 (linux-user, hppa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit a1150d5fc852 (linux-user, m68k: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit ef7c32304b9d (linux-user, xtensa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit 97fee9aed4cb (linux-user, sh4: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 9402b9fe0c51 (linux-user, microblaze: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 76525c62474d (linux-user, arm: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 3c686ee30c6c (linux-user, ppc: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit fbd36b79f0f2 (linux-user, s390x: remove syscall definitions for !TARGET_S390X)
24/38 Checking commit 1553992d2738 (linux-user, s390x: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit 9478b8eda12b (linux-user, sparc, sparc64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 14580297fe50 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl)
27/38 Checking commit c280817ad0a8 (linux-user, i386: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 2760210c4f0b (linux-user, x86_64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit 20353f9a4a27 (linux-user, mips: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 2c2876d5c79f (linux-user, mips64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit 3a51017c7c7b (linux-user, scripts: add a script to update syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit e1cac57a0539 (linux-user: update syscall.tbl from linux 0bf999f9c5e7)
33/38 Checking commit e26a1beca0f9 (linux-user,mips: move content of mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit b3e96808bbe7 (linux-user,mips: update syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit d2747119be6a (scripts: add a script to generate syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit d7f77556e91c (linux-user, aarch64: sync syscall numbers with kernel v5.5)
37/38 Checking commit 275bdae45e8c (linux-user, nios2: sync syscall numbers with kernel v5.5)
38/38 Checking commit 1bc45787f51d (linux-user, openrisc: sync syscall numbers with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200316161550.336150-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: 20200316161550.336150-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e0e5c4d41 linux-user, openrisc: sync syscall numbers with kernel v5.5
2910e84 linux-user, nios2: sync syscall numbers with kernel v5.5
8c86b7e linux-user, aarch64: sync syscall numbers with kernel v5.5
6e455d8 scripts: add a script to generate syscall_nr.h
0e2de33 linux-user,mips: update syscall-args-o32.c.inc
d4f3bcb linux-user,mips: move content of mips_syscall_args
480aff5 linux-user: update syscall.tbl from linux 0bf999f9c5e7
3fc8443 linux-user, scripts: add a script to update syscall.tbl
0948216 linux-user, mips64: add syscall table generation support
b9ae2f7 linux-user, mips: add syscall table generation support
a047c7e linux-user, x86_64: add syscall table generation support
9585b9f linux-user, i386: add syscall table generation support
95211fc linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
f1b32e0 linux-user, sparc, sparc64: add syscall table generation support
54f036b linux-user, s390x: add syscall table generation support
6a847de linux-user, s390x: remove syscall definitions for !TARGET_S390X
9e0df32 linux-user, ppc: add syscall table generation support
ed29cb5 linux-user, arm: add syscall table generation support
50fd494 linux-user, microblaze: add syscall table generation support
bfe6334 linux-user, sh4: add syscall table generation support
976cf65 linux-user, xtensa: add syscall table generation support
e541b96 linux-user, m68k: add syscall table generation support
192f551 linux-user, hppa: add syscall table generation support
feeb587 linux-user, alpha: add syscall table generation support
9eab8db0 linux-user: introduce parameters to generate syscall_nr.h
c360ebe linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
dd8dcb9 linux-user: Support futex_time64
b3a71ee linux-user/syscall: Add support for clock_gettime64/clock_settime64
e16637d linux-user: Protect more syscalls
8c0e24b linux-user: Update TASK_UNMAPPED_BASE for aarch64
8076da7 linux-user: fix socket() strace
a8ead8b linux-user: do prlimit selectively
53c5852 linux-user: Add AT_EXECFN auxval
8071d57 linux-user: Flush out implementation of gettimeofday
79ab97a linux-user: Add x86_64 vsyscall page to /proc/self/maps
1623ac6 linux-user/i386: Emulate x86_64 vsyscalls
0c9b392 linux-user/i386: Split out gen_signal
6b005bd target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit 6b005bde41b2 (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit 0c9b3925c43e (linux-user/i386: Split out gen_signal)
3/38 Checking commit 1623ac6f2365 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 79ab97a59627 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
5/38 Checking commit 8071d573d622 (linux-user: Flush out implementation of gettimeofday)
6/38 Checking commit 53c58520ac4a (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit a8ead8b1c548 (linux-user: do prlimit selectively)
8/38 Checking commit 8076da785c55 (linux-user: fix socket() strace)
9/38 Checking commit 8c0e24b13310 (linux-user: Update TASK_UNMAPPED_BASE for aarch64)
10/38 Checking commit e16637d2e34d (linux-user: Protect more syscalls)
11/38 Checking commit b3a71ee542ba (linux-user/syscall: Add support for clock_gettime64/clock_settime64)
12/38 Checking commit dd8dcb9f6218 (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit c360ebe7de7c (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit 9eab8db04760 (linux-user: introduce parameters to generate syscall_nr.h)
15/38 Checking commit feeb58754c64 (linux-user, alpha: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit 192f5517224c (linux-user, hppa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit e541b963923a (linux-user, m68k: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit 976cf651bda4 (linux-user, xtensa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit bfe633493e3f (linux-user, sh4: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 50fd494f1955 (linux-user, microblaze: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit ed29cb5bbefd (linux-user, arm: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 9e0df327c4ad (linux-user, ppc: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit 6a847de9f011 (linux-user, s390x: remove syscall definitions for !TARGET_S390X)
24/38 Checking commit 54f036b32733 (linux-user, s390x: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit f1b32e0612eb (linux-user, sparc, sparc64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 95211fc87250 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl)
27/38 Checking commit 9585b9f23dee (linux-user, i386: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit a047c7eb4e5d (linux-user, x86_64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit b9ae2f7b8c15 (linux-user, mips: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 0948216dd07f (linux-user, mips64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit 3fc8443a1f92 (linux-user, scripts: add a script to update syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit 480aff5b8af6 (linux-user: update syscall.tbl from linux 0bf999f9c5e7)
33/38 Checking commit d4f3bcb3817a (linux-user,mips: move content of mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit 0e2de33421e5 (linux-user,mips: update syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit 6e455d83bfa0 (scripts: add a script to generate syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit 8c86b7e22eaf (linux-user, aarch64: sync syscall numbers with kernel v5.5)
37/38 Checking commit 2910e845696d (linux-user, nios2: sync syscall numbers with kernel v5.5)
38/38 Checking commit e0e5c4d41f17 (linux-user, openrisc: sync syscall numbers with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200316161550.336150-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: 20200316161550.336150-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
10fafb1 linux-user, openrisc: sync syscall numbers with kernel v5.5
6782f6a linux-user, nios2: sync syscall numbers with kernel v5.5
9f6200d linux-user, aarch64: sync syscall numbers with kernel v5.5
45ee667 scripts: add a script to generate syscall_nr.h
1f2ea4d linux-user,mips: update syscall-args-o32.c.inc
d23d2a1 linux-user,mips: move content of mips_syscall_args
f41ff3c linux-user: update syscall.tbl from linux 0bf999f9c5e7
19a0e30 linux-user, scripts: add a script to update syscall.tbl
4eec500 linux-user, mips64: add syscall table generation support
aeec810 linux-user, mips: add syscall table generation support
9815b8d linux-user, x86_64: add syscall table generation support
2695951 linux-user, i386: add syscall table generation support
1459c30 linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
4158bb5 linux-user, sparc, sparc64: add syscall table generation support
91ebd50 linux-user, s390x: add syscall table generation support
b456bac linux-user, s390x: remove syscall definitions for !TARGET_S390X
9a58453 linux-user, ppc: add syscall table generation support
01a0d3e linux-user, arm: add syscall table generation support
5c48386 linux-user, microblaze: add syscall table generation support
c908a6a linux-user, sh4: add syscall table generation support
4a37ce6 linux-user, xtensa: add syscall table generation support
e6f088c linux-user, m68k: add syscall table generation support
b3099a5 linux-user, hppa: add syscall table generation support
550b771 linux-user, alpha: add syscall table generation support
af30485 linux-user: introduce parameters to generate syscall_nr.h
136c2bf linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
b2dec49 linux-user: Support futex_time64
44d988e linux-user/syscall: Add support for clock_gettime64/clock_settime64
96402ae linux-user: Protect more syscalls
8b3e85d linux-user: Update TASK_UNMAPPED_BASE for aarch64
0cbf17e linux-user: fix socket() strace
91bd410 linux-user: do prlimit selectively
403d5bc linux-user: Add AT_EXECFN auxval
06b7595 linux-user: Flush out implementation of gettimeofday
4050585 linux-user: Add x86_64 vsyscall page to /proc/self/maps
1db8bf7 linux-user/i386: Emulate x86_64 vsyscalls
f47d45b linux-user/i386: Split out gen_signal
34bb353 target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit 34bb353a89ec (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit f47d45b3bace (linux-user/i386: Split out gen_signal)
3/38 Checking commit 1db8bf765b39 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit 405058564933 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
5/38 Checking commit 06b75956b14e (linux-user: Flush out implementation of gettimeofday)
6/38 Checking commit 403d5bca8b6d (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit 91bd41044ad3 (linux-user: do prlimit selectively)
8/38 Checking commit 0cbf17e17283 (linux-user: fix socket() strace)
9/38 Checking commit 8b3e85d562b1 (linux-user: Update TASK_UNMAPPED_BASE for aarch64)
10/38 Checking commit 96402ae791e6 (linux-user: Protect more syscalls)
11/38 Checking commit 44d988e75f99 (linux-user/syscall: Add support for clock_gettime64/clock_settime64)
12/38 Checking commit b2dec497276d (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit 136c2bf1d6c5 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit af304858050f (linux-user: introduce parameters to generate syscall_nr.h)
15/38 Checking commit 550b77128c2e (linux-user, alpha: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit b3099a5f69ea (linux-user, hppa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit e6f088c503bf (linux-user, m68k: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit 4a37ce61da27 (linux-user, xtensa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit c908a6ade856 (linux-user, sh4: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit 5c48386eb066 (linux-user, microblaze: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 01a0d3e7ba67 (linux-user, arm: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 9a5845309428 (linux-user, ppc: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit b456bac3f69e (linux-user, s390x: remove syscall definitions for !TARGET_S390X)
24/38 Checking commit 91ebd50eb411 (linux-user, s390x: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit 4158bb5c6c01 (linux-user, sparc, sparc64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 1459c30a1c94 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl)
27/38 Checking commit 2695951d66ff (linux-user, i386: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 9815b8d388bf (linux-user, x86_64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit aeec8106c76f (linux-user, mips: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 4eec50017ab5 (linux-user, mips64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit 19a0e30f46a8 (linux-user, scripts: add a script to update syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit f41ff3c5579b (linux-user: update syscall.tbl from linux 0bf999f9c5e7)
33/38 Checking commit d23d2a1599de (linux-user,mips: move content of mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit 1f2ea4d95fc4 (linux-user,mips: update syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit 45ee6674ac01 (scripts: add a script to generate syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit 9f6200d52184 (linux-user, aarch64: sync syscall numbers with kernel v5.5)
37/38 Checking commit 6782f6a378da (linux-user, nios2: sync syscall numbers with kernel v5.5)
38/38 Checking commit 10fafb17f794 (linux-user, openrisc: sync syscall numbers with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200316161550.336150-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/20200316161550.336150-1-laurent@vivier.eu/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/38] Linux user for 5.0 patches
Message-id: 20200316161550.336150-1-laurent@vivier.eu
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a5c430a linux-user, openrisc: sync syscall numbers with kernel v5.5
eb272b1 linux-user, nios2: sync syscall numbers with kernel v5.5
22c8c60 linux-user, aarch64: sync syscall numbers with kernel v5.5
ff2d7fb scripts: add a script to generate syscall_nr.h
e61c688 linux-user,mips: update syscall-args-o32.c.inc
2d3af3b linux-user,mips: move content of mips_syscall_args
b059ae6 linux-user: update syscall.tbl from linux 0bf999f9c5e7
e1673a3 linux-user, scripts: add a script to update syscall.tbl
66cb246 linux-user, mips64: add syscall table generation support
1a19648 linux-user, mips: add syscall table generation support
0735d9e linux-user, x86_64: add syscall table generation support
082a58f linux-user, i386: add syscall table generation support
3725dc8 linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl
c4e0a3a linux-user, sparc, sparc64: add syscall table generation support
b587fb3 linux-user, s390x: add syscall table generation support
b5216b5 linux-user, s390x: remove syscall definitions for !TARGET_S390X
8386d4c linux-user, ppc: add syscall table generation support
787b89e linux-user, arm: add syscall table generation support
f623fac linux-user, microblaze: add syscall table generation support
0257a88 linux-user, sh4: add syscall table generation support
172cbeb linux-user, xtensa: add syscall table generation support
5ec8555 linux-user, m68k: add syscall table generation support
0519335 linux-user, hppa: add syscall table generation support
586725d linux-user, alpha: add syscall table generation support
a3ebf49 linux-user: introduce parameters to generate syscall_nr.h
a129601 linux-user/riscv: Update the syscall_nr's to the 5.5 kernel
29571d4 linux-user: Support futex_time64
78be30d linux-user/syscall: Add support for clock_gettime64/clock_settime64
3781280 linux-user: Protect more syscalls
1e4fd4c linux-user: Update TASK_UNMAPPED_BASE for aarch64
ffe5816 linux-user: fix socket() strace
af7e366 linux-user: do prlimit selectively
de1e86d linux-user: Add AT_EXECFN auxval
0045e32 linux-user: Flush out implementation of gettimeofday
dcc5ae2 linux-user: Add x86_64 vsyscall page to /proc/self/maps
aca467b linux-user/i386: Emulate x86_64 vsyscalls
6828cf1 linux-user/i386: Split out gen_signal
e14979b target/i386: Renumber EXCP_SYSCALL

=== OUTPUT BEGIN ===
1/38 Checking commit e14979b2eea7 (target/i386: Renumber EXCP_SYSCALL)
2/38 Checking commit 6828cf104a6a (linux-user/i386: Split out gen_signal)
3/38 Checking commit aca467bf22c7 (linux-user/i386: Emulate x86_64 vsyscalls)
4/38 Checking commit dcc5ae296a75 (linux-user: Add x86_64 vsyscall page to /proc/self/maps)
5/38 Checking commit 0045e32d7be7 (linux-user: Flush out implementation of gettimeofday)
6/38 Checking commit de1e86dceed4 (linux-user: Add AT_EXECFN auxval)
7/38 Checking commit af7e3667c6cf (linux-user: do prlimit selectively)
8/38 Checking commit ffe5816ec43b (linux-user: fix socket() strace)
9/38 Checking commit 1e4fd4cc3de4 (linux-user: Update TASK_UNMAPPED_BASE for aarch64)
10/38 Checking commit 37812805e354 (linux-user: Protect more syscalls)
11/38 Checking commit 78be30d9711a (linux-user/syscall: Add support for clock_gettime64/clock_settime64)
12/38 Checking commit 29571d4f51fe (linux-user: Support futex_time64)
WARNING: architecture specific defines should be avoided
#26: FILE: linux-user/syscall.c:248:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#29: FILE: linux-user/syscall.c:251:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#40: FILE: linux-user/syscall.c:303:
+#if (defined(TARGET_NR_futex) && defined(__NR_futex)) || \

WARNING: architecture specific defines should be avoided
#46: FILE: linux-user/syscall.c:309:
+#if (defined(TARGET_NR_futex_time64) && defined(__NR_futex_teim64))

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
              ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                               ^

ERROR: space required after that ',' (ctx:OxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#47: FILE: linux-user/syscall.c:310:
+_syscall6(int,sys_futex_time64,int *,uaddr,int,op,int,val,
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                  ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                          ^

ERROR: space required after that ',' (ctx:OxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                       ^

ERROR: space required after that ',' (ctx:VxV)
#48: FILE: linux-user/syscall.c:311:
+          const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

WARNING: architecture specific defines should be avoided
#58: FILE: linux-user/syscall.c:776:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#62: FILE: linux-user/syscall.c:780:
+#if defined(__NR_futex_time64)

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                               ^

ERROR: space required after that ',' (ctx:OxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                     ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                           ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                               ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                  ^

ERROR: space required after that ',' (ctx:VxV)
#63: FILE: linux-user/syscall.c:781:
+safe_syscall6(int,futex_time64,int *,uaddr,int,op,int,val, \
                                                      ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                      ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                              ^

ERROR: space required after that ',' (ctx:OxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                    ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                           ^

ERROR: space required after that ',' (ctx:VxV)
#64: FILE: linux-user/syscall.c:782:
+              const struct timespec *,timeout,int *,uaddr2,int,val3)
                                                               ^

WARNING: architecture specific defines should be avoided
#87: FILE: linux-user/syscall.c:6930:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#93: FILE: linux-user/syscall.c:6936:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#99: FILE: linux-user/syscall.c:6942:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#112: FILE: linux-user/syscall.c:6955:
+#if defined(__NR_futex)

WARNING: architecture specific defines should be avoided
#117: FILE: linux-user/syscall.c:6960:
+#if defined(__NR_futex_time64)

WARNING: architecture specific defines should be avoided
#124: FILE: linux-user/syscall.c:6967:
+#if defined(__NR_futex)

WARNING: line over 80 characters
#171: FILE: linux-user/syscall.c:7030:
+static int do_futex_time64(target_ulong uaddr, int op, int val, target_ulong timeout,

WARNING: Block comments use a leading /* on a separate line
#177: FILE: linux-user/syscall.c:7036:
+    /* ??? We assume FUTEX_* constants are the same on both host

WARNING: Block comments use * on subsequent lines
#178: FILE: linux-user/syscall.c:7037:
+    /* ??? We assume FUTEX_* constants are the same on both host
+       and target.  */

WARNING: Block comments use a trailing */ on a separate line
#178: FILE: linux-user/syscall.c:7037:
+       and target.  */

WARNING: Block comments use a leading /* on a separate line
#202: FILE: linux-user/syscall.c:7061:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the

WARNING: Block comments use * on subsequent lines
#203: FILE: linux-user/syscall.c:7062:
+        /* For FUTEX_REQUEUE, FUTEX_CMP_REQUEUE, and FUTEX_WAKE_OP, the
+           TIMEOUT parameter is interpreted as a uint32_t by the kernel.

WARNING: Block comments use a trailing */ on a separate line
#206: FILE: linux-user/syscall.c:7065:
+           since it's not compared to guest memory.  */

total: 24 errors, 19 warnings, 212 lines checked

Patch 12/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/38 Checking commit a129601e0679 (linux-user/riscv: Update the syscall_nr's to the 5.5 kernel)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 898 lines checked

Patch 13/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/38 Checking commit a3ebf497a3cd (linux-user: introduce parameters to generate syscall_nr.h)
15/38 Checking commit 586725dced44 (linux-user, alpha: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 536 lines checked

Patch 15/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/38 Checking commit 05193353112d (linux-user, hppa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 491 lines checked

Patch 16/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/38 Checking commit 5ec8555440ac (linux-user, m68k: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 493 lines checked

Patch 17/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/38 Checking commit 172cbeb90a08 (linux-user, xtensa: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#47: 
new file mode 100644

total: 0 errors, 1 warnings, 464 lines checked

Patch 18/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/38 Checking commit 0257a884cf0d (linux-user, sh4: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 19/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/38 Checking commit f623facdcca6 (linux-user, microblaze: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 501 lines checked

Patch 20/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/38 Checking commit 787b89eb71bf (linux-user, arm: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 531 lines checked

Patch 21/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
22/38 Checking commit 8386d4cabadf (linux-user, ppc: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#74: 
new file mode 100644

total: 0 errors, 1 warnings, 608 lines checked

Patch 22/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/38 Checking commit b5216b513e16 (linux-user, s390x: remove syscall definitions for !TARGET_S390X)
24/38 Checking commit b587fb37cad9 (linux-user, s390x: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#49: 
new file mode 100644

total: 0 errors, 1 warnings, 498 lines checked

Patch 24/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/38 Checking commit c4e0a3af84d6 (linux-user, sparc, sparc64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 1072 lines checked

Patch 25/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/38 Checking commit 3725dc887c53 (linux-user, x86_64, i386: cleanup TARGET_NR_arch_prctl)
27/38 Checking commit 082a58f0d348 (linux-user, i386: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 497 lines checked

Patch 27/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/38 Checking commit 0735d9ec6fd8 (linux-user, x86_64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#48: 
new file mode 100644

total: 0 errors, 1 warnings, 455 lines checked

Patch 28/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
29/38 Checking commit 1a196486af12 (linux-user, mips: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#53: 
new file mode 100644

total: 0 errors, 1 warnings, 488 lines checked

Patch 29/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/38 Checking commit 66cb24669452 (linux-user, mips64: add syscall table generation support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 802 lines checked

Patch 30/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/38 Checking commit e1673a367170 (linux-user, scripts: add a script to update syscall.tbl)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 56 lines checked

Patch 31/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
32/38 Checking commit b059ae6bc332 (linux-user: update syscall.tbl from linux 0bf999f9c5e7)
33/38 Checking commit 2d3af3bad3cd (linux-user,mips: move content of mips_syscall_args)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#470: 
new file mode 100644

total: 0 errors, 1 warnings, 886 lines checked

Patch 33/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
34/38 Checking commit e61c6889354f (linux-user,mips: update syscall-args-o32.c.inc)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#908: 
new file mode 100755

total: 0 errors, 1 warnings, 938 lines checked

Patch 34/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
35/38 Checking commit ff2d7fb77e00 (scripts: add a script to generate syscall_nr.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100755

total: 0 errors, 1 warnings, 109 lines checked

Patch 35/38 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
36/38 Checking commit 22c8c60bc6d1 (linux-user, aarch64: sync syscall numbers with kernel v5.5)
37/38 Checking commit eb272b1cc2c1 (linux-user, nios2: sync syscall numbers with kernel v5.5)
38/38 Checking commit a5c430a0f6e0 (linux-user, openrisc: sync syscall numbers with kernel v5.5)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200316161550.336150-1-laurent@vivier.eu/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com