iotests: Fix intermittent 030 hang

[PATCH 0/3] iotests: Fix intermittent 030 hang

Kevin Wolf posted 3 patches 4 years, 1 month ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200313083617.8326-1-kwolf@redhat.com

Maintainers: Cleber Rosa <crosa@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>

python/qemu/machine.py        | 1 +
tests/qemu-iotests/iotests.py | 5 ++++-
2 files changed, 5 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH 0/3] iotests: Fix intermittent 030 hang

Posted by Kevin Wolf 4 years, 1 month ago

Peter ran into a 030 hang while testing a pull request. This turned out
to be two bugs in the test suite at once: First was the test failing
because a timeout was apparently too short, second was that the timeout
would actually cause the test to hang instead of failing. This series
should fix both.

Kevin Wolf (3):
  iotests.py: Enable faulthandler
  python/qemu: Kill QEMU process if 'quit' doesn't work
  iotests: Increase pause_wait() timeout

 python/qemu/machine.py        | 1 +
 tests/qemu-iotests/iotests.py | 5 ++++-
 2 files changed, 5 insertions(+), 1 deletion(-)

-- 
2.20.1

Re: [PATCH 0/3] iotests: Fix intermittent 030 hang

Posted by Philippe Mathieu-Daudé 4 years, 1 month ago

On 3/13/20 9:36 AM, Kevin Wolf wrote:
> Peter ran into a 030 hang while testing a pull request. This turned out
> to be two bugs in the test suite at once: First was the test failing
> because a timeout was apparently too short, second was that the timeout
> would actually cause the test to hang instead of failing. This series
> should fix both.
> 
> Kevin Wolf (3):
>    iotests.py: Enable faulthandler
>    python/qemu: Kill QEMU process if 'quit' doesn't work
>    iotests: Increase pause_wait() timeout
> 
>   python/qemu/machine.py        | 1 +
>   tests/qemu-iotests/iotests.py | 5 ++++-
>   2 files changed, 5 insertions(+), 1 deletion(-)
> 

Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH 0/3] iotests: Fix intermittent 030 hang

Posted by Peter Maydell 4 years, 1 month ago

On Fri, 13 Mar 2020 at 08:37, Kevin Wolf <kwolf@redhat.com> wrote:
>
> Peter ran into a 030 hang while testing a pull request. This turned out
> to be two bugs in the test suite at once: First was the test failing
> because a timeout was apparently too short, second was that the timeout
> would actually cause the test to hang instead of failing. This series
> should fix both.
>
> Kevin Wolf (3):
>   iotests.py: Enable faulthandler
>   python/qemu: Kill QEMU process if 'quit' doesn't work
>   iotests: Increase pause_wait() timeout
>
>  python/qemu/machine.py        | 1 +
>  tests/qemu-iotests/iotests.py | 5 ++++-
>  2 files changed, 5 insertions(+), 1 deletion(-)

Applied to master since I've been seeing this hang off-and-on.

thanks
-- PMM