configure: Fix configure error.

[PATCH] configure: Fix configure error.

Posted by Zhang Chen 4 years, 1 month ago

From: Zhang Chen <chen.zhang@intel.com>

When run the ./configure will always get this error:
Unknown option --exist

It caused by this patch:
commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
Author: Juan Quintela <quintela@redhat.com>
Date:   Tue Dec 17 21:15:24 2019 +0100

    configure: Enable test and libs for zstd

    Add it to several build systems to make testing good.

Signed-off-by: Zhang Chen <chen.zhang@intel.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 3c7470096f..305591f7e0 100755
--- a/configure
+++ b/configure
@@ -2475,7 +2475,7 @@ fi
 # zstd check
 
 if test "$zstd" != "no" ; then
-    if $pkg_config --exist libzstd ; then
+    if $pkg_config --exists libzstd ; then
         zstd_cflags="$($pkg_config --cflags libzstd)"
         zstd_libs="$($pkg_config --libs libzstd)"
         LIBS="$zstd_libs $LIBS"
-- 
2.17.1

Re: [PATCH] configure: Fix configure error.

Posted by Laurent Vivier 4 years, 1 month ago

Le 13/03/2020 à 07:55, Zhang Chen a écrit :
> From: Zhang Chen <chen.zhang@intel.com>
> 
> When run the ./configure will always get this error:
> Unknown option --exist
> 
> It caused by this patch:
> commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
> Author: Juan Quintela <quintela@redhat.com>
> Date:   Tue Dec 17 21:15:24 2019 +0100
> 
>     configure: Enable test and libs for zstd
> 
>     Add it to several build systems to make testing good.
> 
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 3c7470096f..305591f7e0 100755
> --- a/configure
> +++ b/configure
> @@ -2475,7 +2475,7 @@ fi
>  # zstd check
>  
>  if test "$zstd" != "no" ; then
> -    if $pkg_config --exist libzstd ; then
> +    if $pkg_config --exists libzstd ; then
>          zstd_cflags="$($pkg_config --cflags libzstd)"
>          zstd_libs="$($pkg_config --libs libzstd)"
>          LIBS="$zstd_libs $LIBS"
> 

Juan already sent a patch to fix that:

[PATCH v2] configure: Improve zstd test
https://patchew.org/QEMU/20200310111431.173151-1-quintela@redhat.com/

Thanks,
Laurent

RE: [PATCH] configure: Fix configure error.

Posted by Zhang, Chen 4 years, 1 month ago


> -----Original Message-----
> From: Laurent Vivier <laurent@vivier.eu>
> Sent: Friday, March 13, 2020 4:18 PM
> To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu-
> devel@nongnu.org>
> Cc: Zhang Chen <zhangckid@gmail.com>; Dr . David Alan Gilbert
> <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>
> Subject: Re: [PATCH] configure: Fix configure error.
> 
> Le 13/03/2020 à 07:55, Zhang Chen a écrit :
> > From: Zhang Chen <chen.zhang@intel.com>
> >
> > When run the ./configure will always get this error:
> > Unknown option --exist
> >
> > It caused by this patch:
> > commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
> > Author: Juan Quintela <quintela@redhat.com>
> > Date:   Tue Dec 17 21:15:24 2019 +0100
> >
> >     configure: Enable test and libs for zstd
> >
> >     Add it to several build systems to make testing good.
> >
> > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index 3c7470096f..305591f7e0 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2475,7 +2475,7 @@ fi
> >  # zstd check
> >
> >  if test "$zstd" != "no" ; then
> > -    if $pkg_config --exist libzstd ; then
> > +    if $pkg_config --exists libzstd ; then
> >          zstd_cflags="$($pkg_config --cflags libzstd)"
> >          zstd_libs="$($pkg_config --libs libzstd)"
> >          LIBS="$zstd_libs $LIBS"
> >
> 
> Juan already sent a patch to fix that:
> 
> [PATCH v2] configure: Improve zstd test
> https://patchew.org/QEMU/20200310111431.173151-1-
> quintela@redhat.com/

OK, Looks haven't merged to upstream.

Thanks
Zhang Chen

> 
> Thanks,
> Laurent

Re: [PATCH] configure: Fix configure error.

Posted by Dr. David Alan Gilbert 4 years, 1 month ago

* Zhang, Chen (chen.zhang@intel.com) wrote:
> 
> 
> > -----Original Message-----
> > From: Laurent Vivier <laurent@vivier.eu>
> > Sent: Friday, March 13, 2020 4:18 PM
> > To: Zhang, Chen <chen.zhang@intel.com>; qemu-dev <qemu-
> > devel@nongnu.org>
> > Cc: Zhang Chen <zhangckid@gmail.com>; Dr . David Alan Gilbert
> > <dgilbert@redhat.com>; Juan Quintela <quintela@redhat.com>
> > Subject: Re: [PATCH] configure: Fix configure error.
> > 
> > Le 13/03/2020 à 07:55, Zhang Chen a écrit :
> > > From: Zhang Chen <chen.zhang@intel.com>
> > >
> > > When run the ./configure will always get this error:
> > > Unknown option --exist
> > >
> > > It caused by this patch:
> > > commit 3a67848134d0c07da49033f9ed08bf0ddeec0c6d
> > > Author: Juan Quintela <quintela@redhat.com>
> > > Date:   Tue Dec 17 21:15:24 2019 +0100
> > >
> > >     configure: Enable test and libs for zstd
> > >
> > >     Add it to several build systems to make testing good.
> > >
> > > Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> > > ---
> > >  configure | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/configure b/configure
> > > index 3c7470096f..305591f7e0 100755
> > > --- a/configure
> > > +++ b/configure
> > > @@ -2475,7 +2475,7 @@ fi
> > >  # zstd check
> > >
> > >  if test "$zstd" != "no" ; then
> > > -    if $pkg_config --exist libzstd ; then
> > > +    if $pkg_config --exists libzstd ; then
> > >          zstd_cflags="$($pkg_config --cflags libzstd)"
> > >          zstd_libs="$($pkg_config --libs libzstd)"
> > >          LIBS="$zstd_libs $LIBS"
> > >
> > 
> > Juan already sent a patch to fix that:
> > 
> > [PATCH v2] configure: Improve zstd test
> > https://patchew.org/QEMU/20200310111431.173151-1-
> > quintela@redhat.com/
> 
> OK, Looks haven't merged to upstream.

I've built a pull with it in, testing it now.

Dave

> Thanks
> Zhang Chen
> 
> > 
> > Thanks,
> > Laurent
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK