[PATCH v3 00/16]: hw/i386/vmport: Bug fixes and improvements

Liran Alon posted 16 patches 5 years, 8 months ago
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200312165431.82118-1-liran.alon@oracle.com
Maintainers: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>
[PATCH v3 00/16]: hw/i386/vmport: Bug fixes and improvements
Posted by Liran Alon 5 years, 8 months ago
Hi,

This series aims to fix several bugs in VMPort and improve it by supporting
more VMPort commands and make command results more configurable to
user via QEMU command-line.

This functionality was proven to be useful to run various VMware VMs
when attempting to run them as-is on top of QEMU/KVM.

For more details, see commit messages.

Regards,
-Liran

v1->v2:
* Fix coding convention [Patchew Bot & MST].
* Create new header file for vmport.h [MST].
* Move KVM_APIC_BUS_FREQUENCY from linux-headers/asm-x86/kvm.h
  auto-generated header [MST]
* Elaborate more that vmx-version refers to the VMware userspace
  VMM in commit message. [MST]
* Use le32_to_cpu() on BIOS_UUID vmport command. [MST]
* Introduce VMPort compatability version property to maintain migration
  compatibility. [MST]

v2->v3:
- Repalce VMPort compatability version property with multiple boolean
  compatability properties. [MST]
- Prefix "vmx-*" properties with "vmware-vmx-*" to avoid confusion with
  Intel VT-x short name. Prefix suggested by MST. [MST]
- Remove VMX_Type enum and instead hard-code default vmware-vmx-type
  value and only reference open-vm-tools for rest of values. [MST]
- Add reference (link) to VMware open-vm-tools code. [MST]


Re: [PATCH v3 00/16]: hw/i386/vmport: Bug fixes and improvements
Posted by Paolo Bonzini 5 years, 5 months ago
On 12/03/20 17:54, Liran Alon wrote:
> Hi,
> 
> This series aims to fix several bugs in VMPort and improve it by supporting
> more VMPort commands and make command results more configurable to
> user via QEMU command-line.
> 
> This functionality was proven to be useful to run various VMware VMs
> when attempting to run them as-is on top of QEMU/KVM.
> 
> For more details, see commit messages.
> 
> Regards,
> -Liran
> 
> v1->v2:
> * Fix coding convention [Patchew Bot & MST].
> * Create new header file for vmport.h [MST].
> * Move KVM_APIC_BUS_FREQUENCY from linux-headers/asm-x86/kvm.h
>   auto-generated header [MST]
> * Elaborate more that vmx-version refers to the VMware userspace
>   VMM in commit message. [MST]
> * Use le32_to_cpu() on BIOS_UUID vmport command. [MST]
> * Introduce VMPort compatability version property to maintain migration
>   compatibility. [MST]
> 
> v2->v3:
> - Repalce VMPort compatability version property with multiple boolean
>   compatability properties. [MST]
> - Prefix "vmx-*" properties with "vmware-vmx-*" to avoid confusion with
>   Intel VT-x short name. Prefix suggested by MST. [MST]
> - Remove VMX_Type enum and instead hard-code default vmware-vmx-type
>   value and only reference open-vm-tools for rest of values. [MST]
> - Add reference (link) to VMware open-vm-tools code. [MST]
> 

I actually agree with Liran on most comments, so I just dropped the
GETTIME and GETTIMEFULL functionality and queued everything else.

Thanks,

Paolo