[PATCH v4 00/10] tests/vm: Add support for aarch64 VMs

Robert Foley posted 10 patches 5 years, 8 months ago
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test checkpatch passed
Test FreeBSD passed
Test asan passed
Failed in applying to current master (apply log)
There is a newer version of this series
configure                         |  25 +++
python/qemu/console_socket.py     | 162 +++++++++++++++++++
python/qemu/machine.py            |  23 ++-
tests/vm/Makefile.include         |  27 ++++
tests/vm/aarch64vm.py             | 100 ++++++++++++
tests/vm/basevm.py                | 253 ++++++++++++++++++++++++------
tests/vm/centos-8-aarch64.ks      |  51 ++++++
tests/vm/centos.aarch64           | 226 ++++++++++++++++++++++++++
tests/vm/conf_example_aarch64.yml |  51 ++++++
tests/vm/conf_example_x86.yml     |  50 ++++++
tests/vm/fedora                   |  17 +-
tests/vm/freebsd                  |  16 +-
tests/vm/netbsd                   |  19 +--
tests/vm/openbsd                  |  17 +-
tests/vm/ubuntu.aarch64           | 117 ++++++++++++++
15 files changed, 1072 insertions(+), 82 deletions(-)
create mode 100644 python/qemu/console_socket.py
create mode 100644 tests/vm/aarch64vm.py
create mode 100644 tests/vm/centos-8-aarch64.ks
create mode 100755 tests/vm/centos.aarch64
create mode 100644 tests/vm/conf_example_aarch64.yml
create mode 100644 tests/vm/conf_example_x86.yml
create mode 100755 tests/vm/ubuntu.aarch64
[PATCH v4 00/10] tests/vm: Add support for aarch64 VMs
Posted by Robert Foley 5 years, 8 months ago
This is version 4 of the patch series to 
add support for aarch64 VMs in the vm-build infrastructure.
 - Ubuntu 18.04 aarch64 VM
 - CentOS 8 aarch64 VM

V3: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg02805.html 

Changes in V4.
- Removed the target validation we had put into Makefile.include.
- Corrected a dependency on a later patch in gen_cloud_init_iso().
- Changed the consume console patch to make draining the console to a 
  buffer optional.  This fixes the acceptance test issue.

Robert Foley (10):
  tests/vm: Fix issues in gen_cloud_init_iso
  tests/vm: Add configuration to basevm.py
  tests/vm: Added configuration file support
  tests/vm: add --boot-console switch
  tests/vm: Add ability to select QEMU from current build.
  tests/vm: allow wait_ssh() to specify command
  tests/vm: Added a new script for ubuntu.aarch64.
  tests/vm: Added a new script for centos.aarch64.
  tests/vm: change scripts to use self._config
  tests/vm: Add workaround to consume console

 configure                         |  25 +++
 python/qemu/console_socket.py     | 162 +++++++++++++++++++
 python/qemu/machine.py            |  23 ++-
 tests/vm/Makefile.include         |  27 ++++
 tests/vm/aarch64vm.py             | 100 ++++++++++++
 tests/vm/basevm.py                | 253 ++++++++++++++++++++++++------
 tests/vm/centos-8-aarch64.ks      |  51 ++++++
 tests/vm/centos.aarch64           | 226 ++++++++++++++++++++++++++
 tests/vm/conf_example_aarch64.yml |  51 ++++++
 tests/vm/conf_example_x86.yml     |  50 ++++++
 tests/vm/fedora                   |  17 +-
 tests/vm/freebsd                  |  16 +-
 tests/vm/netbsd                   |  19 +--
 tests/vm/openbsd                  |  17 +-
 tests/vm/ubuntu.aarch64           | 117 ++++++++++++++
 15 files changed, 1072 insertions(+), 82 deletions(-)
 create mode 100644 python/qemu/console_socket.py
 create mode 100644 tests/vm/aarch64vm.py
 create mode 100644 tests/vm/centos-8-aarch64.ks
 create mode 100755 tests/vm/centos.aarch64
 create mode 100644 tests/vm/conf_example_aarch64.yml
 create mode 100644 tests/vm/conf_example_x86.yml
 create mode 100755 tests/vm/ubuntu.aarch64

-- 
2.17.1


Re: [PATCH v4 00/10] tests/vm: Add support for aarch64 VMs
Posted by Alex Bennée 5 years, 6 months ago
Robert Foley <robert.foley@linaro.org> writes:

> This is version 4 of the patch series to 
> add support for aarch64 VMs in the vm-build infrastructure.
>  - Ubuntu 18.04 aarch64 VM
>  - CentOS 8 aarch64 VM
>
> V3: https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg02805.html 
>
> Changes in V4.
> - Removed the target validation we had put into Makefile.include.
> - Corrected a dependency on a later patch in gen_cloud_init_iso().
> - Changed the consume console patch to make draining the console to a 
>   buffer optional.  This fixes the acceptance test issue.

Hi Robert,

Sorry I didn't get to this in the run up to 4.0. I've tried applying the
series to the current master but I ran into conflicts pretty early on. I
think the first patch conflicts with f01454ad17 because I had already
cherry picked some of the cleanups to gen_cloud_init_iso and then had to
fix it up. Skipping it caused the next patch to fail to apply so I
decided to back away from misapplying the series.

Would you be able to re-spin on current master please?

-- 
Alex Bennée

Re: [PATCH v4 00/10] tests/vm: Add support for aarch64 VMs
Posted by Robert Foley 5 years, 6 months ago
On Mon, 11 May 2020 at 05:21, Alex Bennée <alex.bennee@linaro.org> wrote:
> Robert Foley <robert.foley@linaro.org> writes:
>
> > This is version 4 of the patch series to
> > add support for aarch64 VMs in the vm-build infrastructure.
> >  - Ubuntu 18.04 aarch64 VM
> >  - CentOS 8 aarch64 VM
> Hi Robert,
>
> Sorry I didn't get to this in the run up to 4.0. I've tried applying the
> series to the current master but I ran into conflicts pretty early on. I
> think the first patch conflicts with f01454ad17 because I had already
> cherry picked some of the cleanups to gen_cloud_init_iso and then had to
> fix it up. Skipping it caused the next patch to fail to apply so I
> decided to back away from misapplying the series.
>
> Would you be able to re-spin on current master please?

Sure, I will respin.  There is a v5 out for this series from 4/30 with
some additional minor fixes, but I will update the series from the
current master with the change around removing BOOT_CONSOLE and
putting it under DEBUG=1.

Thanks & Regards,
-Rob