[v4] block-copy improvements: part I

[PATCH v4 0/9] block-copy improvements: part I

Vladimir Sementsov-Ogievskiy posted 9 patches 4 years, 1 month ago

Diff against v2 v3
Download series mbox

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200311103004.7649-1-vsementsov@virtuozzo.com

Maintainers: John Snow <jsnow@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>

include/block/block-copy.h    |  65 +-----
include/qemu/job.h            |  11 +-
include/qemu/progress_meter.h |  58 +++++
block/backup-top.c            |   6 +-
block/backup.c                |  38 ++--
block/block-copy.c            | 405 ++++++++++++++++++++++++++--------
blockjob.c                    |  16 +-
job-qmp.c                     |   4 +-
job.c                         |   6 +-
qemu-img.c                    |   6 +-
block/trace-events            |   1 +
11 files changed, 420 insertions(+), 196 deletions(-)
create mode 100644 include/qemu/progress_meter.h

Expand all Fold all

[PATCH v4 0/9] block-copy improvements: part I

Posted by Vladimir Sementsov-Ogievskiy 4 years, 1 month ago

v4:

01: add Max's r-b
02: rm ProgressResetCallbackFunc typedef
03-06: add Max's r-b
07: fix indentation
08: update in_flight_bytes in block_copy_inflight_req_shrink
    improve comment above block_copy() definition
09: add Andrey's and Max's r-b
    drop hunk fixing indentation (merged to 07)

Vladimir Sementsov-Ogievskiy (9):
  job: refactor progress to separate object
  block/block-copy: fix progress calculation
  block/block-copy: specialcase first copy_range request
  block/block-copy: use block_status
  block/block-copy: factor out find_conflicting_inflight_req
  block/block-copy: refactor interfaces to use bytes instead of end
  block/block-copy: rename start to offset in interfaces
  block/block-copy: reduce intersecting request lock
  block/block-copy: hide structure definitions

 include/block/block-copy.h    |  65 +-----
 include/qemu/job.h            |  11 +-
 include/qemu/progress_meter.h |  58 +++++
 block/backup-top.c            |   6 +-
 block/backup.c                |  38 ++--
 block/block-copy.c            | 405 ++++++++++++++++++++++++++--------
 blockjob.c                    |  16 +-
 job-qmp.c                     |   4 +-
 job.c                         |   6 +-
 qemu-img.c                    |   6 +-
 block/trace-events            |   1 +
 11 files changed, 420 insertions(+), 196 deletions(-)
 create mode 100644 include/qemu/progress_meter.h

-- 
2.21.0

Re: [PATCH v4 0/9] block-copy improvements: part I

Posted by Max Reitz 4 years, 1 month ago

On 11.03.20 11:29, Vladimir Sementsov-Ogievskiy wrote:
> v4:
> 
> 01: add Max's r-b
> 02: rm ProgressResetCallbackFunc typedef
> 03-06: add Max's r-b
> 07: fix indentation
> 08: update in_flight_bytes in block_copy_inflight_req_shrink
>     improve comment above block_copy() definition
> 09: add Andrey's and Max's r-b
>     drop hunk fixing indentation (merged to 07)
> 
> Vladimir Sementsov-Ogievskiy (9):
>   job: refactor progress to separate object
>   block/block-copy: fix progress calculation
>   block/block-copy: specialcase first copy_range request
>   block/block-copy: use block_status
>   block/block-copy: factor out find_conflicting_inflight_req
>   block/block-copy: refactor interfaces to use bytes instead of end
>   block/block-copy: rename start to offset in interfaces
>   block/block-copy: reduce intersecting request lock
>   block/block-copy: hide structure definitions

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max

Re: [PATCH v4 0/9] block-copy improvements: part I

Posted by Vladimir Sementsov-Ogievskiy 4 years, 1 month ago

11.03.2020 14:37, Max Reitz wrote:
> On 11.03.20 11:29, Vladimir Sementsov-Ogievskiy wrote:
>> v4:
>>
>> 01: add Max's r-b
>> 02: rm ProgressResetCallbackFunc typedef
>> 03-06: add Max's r-b
>> 07: fix indentation
>> 08: update in_flight_bytes in block_copy_inflight_req_shrink
>>      improve comment above block_copy() definition
>> 09: add Andrey's and Max's r-b
>>      drop hunk fixing indentation (merged to 07)
>>
>> Vladimir Sementsov-Ogievskiy (9):
>>    job: refactor progress to separate object
>>    block/block-copy: fix progress calculation
>>    block/block-copy: specialcase first copy_range request
>>    block/block-copy: use block_status
>>    block/block-copy: factor out find_conflicting_inflight_req
>>    block/block-copy: refactor interfaces to use bytes instead of end
>>    block/block-copy: rename start to offset in interfaces
>>    block/block-copy: reduce intersecting request lock
>>    block/block-copy: hide structure definitions
> 
> Thanks, applied to my block branch:
> 
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block
> 

Thanks you!


-- 
Best regards,
Vladimir