tests: Disable dbus-vmstate-test

[PATCH] tests: Disable dbus-vmstate-test

Posted by Peter Maydell 5 years, 8 months ago

The dbus-vmstate-test has been failing in some Patchew configs
since about the 6th March:

  dbus-daemon[9321]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry

  **
  ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
  cleaning up pid 9321
  ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
  make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
  make: *** Waiting for unfinished jobs....

It's not clear why this is happening (perhaps a recently revealed
race condition or a change in the patchew build environment?).

For the moment, disable this test so that patchew test runs are
useful and don't email the list with spurious failure mails.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 tests/qtest/Makefile.include | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include
index 383b0ab2171..5115f7897db 100644
--- a/tests/qtest/Makefile.include
+++ b/tests/qtest/Makefile.include
@@ -18,7 +18,8 @@ check-qtest-pci-$(CONFIG_IVSHMEM_DEVICE) += ivshmem-test
 DBUS_DAEMON := $(shell which dbus-daemon 2>/dev/null)
 ifneq ($(GDBUS_CODEGEN),)
 ifneq ($(DBUS_DAEMON),)
-check-qtest-pci-$(CONFIG_GIO) += dbus-vmstate-test
+# Temporarily disabled due to Patchew failures:
+#check-qtest-pci-$(CONFIG_GIO) += dbus-vmstate-test
 endif
 endif
 
-- 
2.20.1

Re: [PATCH] tests: Disable dbus-vmstate-test

Posted by Paolo Bonzini 5 years, 8 months ago

On 10/03/20 16:21, Peter Maydell wrote:
> 
>   dbus-daemon[9321]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
> 
>   **
>   ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   cleaning up pid 9321
>   ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
>   make: *** Waiting for unfinished jobs....
> 
> It's not clear why this is happening (perhaps a recently revealed
> race condition or a change in the patchew build environment?).
> 
> For the moment, disable this test so that patchew test runs are
> useful and don't email the list with spurious failure mails.

It has failed forever since it has been committed.  It only happens in
the Ubuntu configuration, and I had disabled it for a long time due to
this failure.  On March 6th I added it back to see if someone had fixed it.

Paolo

Re: [PATCH] tests: Disable dbus-vmstate-test

Posted by Marc-André Lureau 5 years, 8 months ago

Hi

On Tue, Mar 10, 2020 at 4:27 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 10/03/20 16:21, Peter Maydell wrote:
> >
> >   dbus-daemon[9321]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
> >
> >   **
> >   ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
> >   cleaning up pid 9321
> >   ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
> >   make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
> >   make: *** Waiting for unfinished jobs....
> >
> > It's not clear why this is happening (perhaps a recently revealed
> > race condition or a change in the patchew build environment?).
> >
> > For the moment, disable this test so that patchew test runs are
> > useful and don't email the list with spurious failure mails.

I tried to reproduce on a fresh ubuntu 19.10, with make
docker-test-debug@fedora there, and the dbus-vmstate test pass, as
well as the rest for the build.

Any help on how to reproduce appreciated.

-- 
Marc-André Lureau

Re: [PATCH] tests: Disable dbus-vmstate-test

Posted by Peter Maydell 5 years, 8 months ago

On Tue, 10 Mar 2020 at 15:21, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The dbus-vmstate-test has been failing in some Patchew configs
> since about the 6th March:
>
>   dbus-daemon[9321]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
>
>   **
>   ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   cleaning up pid 9321
>   ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
>   make: *** Waiting for unfinished jobs....
>
> It's not clear why this is happening (perhaps a recently revealed
> race condition or a change in the patchew build environment?).
>
> For the moment, disable this test so that patchew test runs are
> useful and don't email the list with spurious failure mails.

I've applied this to master to suppress the patchew emails.
(If people would prefer to turn the relevant patchew config
off again instead we can then revert this commit. AFAICT we
lose test coverage either way...)

thanks
-- PMM

Re: [PATCH] tests: Disable dbus-vmstate-test

Posted by Laurent Vivier 5 years, 8 months ago

On 10/03/2020 16:21, Peter Maydell wrote:
> The dbus-vmstate-test has been failing in some Patchew configs
> since about the 6th March:
> 
>   dbus-daemon[9321]: Could not get password database information for UID of current process: User "???" unknown or no memory to allocate password entry
> 
>   **
>   ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   cleaning up pid 9321
>   ERROR - Bail out! ERROR:/tmp/qemu-test/src/tests/qtest/dbus-vmstate-test.c:114:get_connection: assertion failed (err == NULL): The connection is closed (g-io-error-quark, 18)
>   make: *** [/tmp/qemu-test/src/tests/Makefile.include:632: check-qtest-x86_64] Error 1
>   make: *** Waiting for unfinished jobs....
> 
> It's not clear why this is happening (perhaps a recently revealed
> race condition or a change in the patchew build environment?).
> 
> For the moment, disable this test so that patchew test runs are
> useful and don't email the list with spurious failure mails.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  tests/qtest/Makefile.include | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/Makefile.include b/tests/qtest/Makefile.include
> index 383b0ab2171..5115f7897db 100644
> --- a/tests/qtest/Makefile.include
> +++ b/tests/qtest/Makefile.include
> @@ -18,7 +18,8 @@ check-qtest-pci-$(CONFIG_IVSHMEM_DEVICE) += ivshmem-test
>  DBUS_DAEMON := $(shell which dbus-daemon 2>/dev/null)
>  ifneq ($(GDBUS_CODEGEN),)
>  ifneq ($(DBUS_DAEMON),)
> -check-qtest-pci-$(CONFIG_GIO) += dbus-vmstate-test
> +# Temporarily disabled due to Patchew failures:
> +#check-qtest-pci-$(CONFIG_GIO) += dbus-vmstate-test
>  endif
>  endif
>  

Adding Marc-André.

The MAINTAINERS file has not been updated when the file has been moved
from tests/ to tests/qtest

Thanks,
Laurent