The "ibm,xive-lisn-ranges" defines ranges of interrupt numbers that
the guest can use to configure IPIs. It starts at 0 today but it could
change to some other offset. Make clear which IRQ range we are
exposing by using SPAPR_IRQ_IPI in the property definition.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/intc/spapr_xive.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
index 20c8155557d6..6608d7220a47 100644
--- a/hw/intc/spapr_xive.c
+++ b/hw/intc/spapr_xive.c
@@ -677,8 +677,8 @@ static void spapr_xive_dt(SpaprInterruptController *intc, uint32_t nr_servers,
uint64_t timas[2 * 2];
/* Interrupt number ranges for the IPIs */
uint32_t lisn_ranges[] = {
- cpu_to_be32(0),
- cpu_to_be32(nr_servers),
+ cpu_to_be32(SPAPR_IRQ_IPI),
+ cpu_to_be32(SPAPR_IRQ_IPI + nr_servers),
};
/*
* EQ size - the sizes of pages supported by the system 4K, 64K,
--
2.21.1
Patchew URL: https://patchew.org/QEMU/20200306123307.1348-1-clg@kaod.org/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #! /bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-mingw@fedora J=14 NETWORK=1 === TEST SCRIPT END === File: "/tmp/qemu-nsis\qemu-doc.html" -> no files found. Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] | /oname=outfile one_file_only) Error in script "/tmp/qemu-test/src/qemu.nsi" on line 180 -- aborting creation process make: *** [Makefile:1162: qemu-setup-4.2.50.exe] Error 1 Traceback (most recent call last): File "./tests/docker/docker.py", line 664, in <module> sys.exit(main()) --- raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=e8d2f52f3055473c9f743fadda5d5437', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-8iuwr53p/src/docker-src.2020-03-06-09.03.10.19648:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2. filter=--filter=label=com.qemu.instance.uuid=e8d2f52f3055473c9f743fadda5d5437 make[1]: *** [docker-run] Error 1 make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-8iuwr53p/src' make: *** [docker-run-test-mingw@fedora] Error 2 real 3m47.685s user 0m8.708s The full log is available at http://patchew.org/logs/20200306123307.1348-1-clg@kaod.org/testing.docker-mingw@fedora/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 6 Mar 2020 13:33:07 +0100 Cédric Le Goater <clg@kaod.org> wrote: > The "ibm,xive-lisn-ranges" defines ranges of interrupt numbers that > the guest can use to configure IPIs. It starts at 0 today but it could > change to some other offset. Make clear which IRQ range we are > exposing by using SPAPR_IRQ_IPI in the property definition. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> > --- Reviewed-by: Greg Kurz <groug@kaod.org> > hw/intc/spapr_xive.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c > index 20c8155557d6..6608d7220a47 100644 > --- a/hw/intc/spapr_xive.c > +++ b/hw/intc/spapr_xive.c > @@ -677,8 +677,8 @@ static void spapr_xive_dt(SpaprInterruptController *intc, uint32_t nr_servers, > uint64_t timas[2 * 2]; > /* Interrupt number ranges for the IPIs */ > uint32_t lisn_ranges[] = { > - cpu_to_be32(0), > - cpu_to_be32(nr_servers), > + cpu_to_be32(SPAPR_IRQ_IPI), > + cpu_to_be32(SPAPR_IRQ_IPI + nr_servers), > }; > /* > * EQ size - the sizes of pages supported by the system 4K, 64K,
On Fri, Mar 06, 2020 at 01:33:07PM +0100, Cédric Le Goater wrote: > The "ibm,xive-lisn-ranges" defines ranges of interrupt numbers that > the guest can use to configure IPIs. It starts at 0 today but it could > change to some other offset. Make clear which IRQ range we are > exposing by using SPAPR_IRQ_IPI in the property definition. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Applied to ppc-for-5.0, thanks., > --- > hw/intc/spapr_xive.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c > index 20c8155557d6..6608d7220a47 100644 > --- a/hw/intc/spapr_xive.c > +++ b/hw/intc/spapr_xive.c > @@ -677,8 +677,8 @@ static void spapr_xive_dt(SpaprInterruptController *intc, uint32_t nr_servers, > uint64_t timas[2 * 2]; > /* Interrupt number ranges for the IPIs */ > uint32_t lisn_ranges[] = { > - cpu_to_be32(0), > - cpu_to_be32(nr_servers), > + cpu_to_be32(SPAPR_IRQ_IPI), > + cpu_to_be32(SPAPR_IRQ_IPI + nr_servers), > }; > /* > * EQ size - the sizes of pages supported by the system 4K, 64K, -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
© 2016 - 2024 Red Hat, Inc.