hw/net: Make Net/CanBus can_receive() handlers return a boolean

[PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean

Philippe Mathieu-Daudé posted 6 patches 5 years, 8 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200305175651.4563-1-philmd@redhat.com

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test checkpatch passed

Test FreeBSD passed

Maintainers: Max Filippov <jcmvbkbc@gmail.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Cédric Le Goater" <clg@kaod.org>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Alistair Francis <alistair@alistair23.me>, Beniamino Galvani <b.galvani@gmail.com>, Peter Chubb <peter.chubb@nicta.com.au>, David Gibson <david@gibson.dropbear.id.au>, Andrew Jeffery <andrew@aj.id.au>, Jason Wang <jasowang@redhat.com>, Joel Stanley <joel@jms.id.au>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

hw/net/can/can_sja1000.h |  2 +-
hw/net/e1000e_core.h     |  2 +-
hw/net/i82596.h          |  2 +-
include/net/can_emu.h    |  2 +-
include/net/net.h        |  2 +-
hw/net/allwinner_emac.c  |  2 +-
hw/net/cadence_gem.c     |  8 ++++----
hw/net/can/can_sja1000.c |  8 ++++----
hw/net/dp8393x.c         |  8 +++-----
hw/net/e1000.c           |  2 +-
hw/net/e1000e.c          |  2 +-
hw/net/e1000e_core.c     |  2 +-
hw/net/ftgmac100.c       |  6 +++---
hw/net/i82596.c          | 10 +++++-----
hw/net/imx_fec.c         |  2 +-
hw/net/opencores_eth.c   |  5 ++---
hw/net/rtl8139.c         | 22 ++++++++++++----------
hw/net/smc91c111.c       | 10 +++++-----
hw/net/spapr_llan.c      |  4 ++--
hw/net/sungem.c          |  6 +++---
hw/net/sunhme.c          |  4 ++--
hw/net/virtio-net.c      | 10 +++++-----
hw/net/xilinx_ethlite.c  |  2 +-
net/can/can_socketcan.c  |  4 ++--
net/filter-buffer.c      |  2 +-
net/hub.c                |  6 +++---
26 files changed, 67 insertions(+), 68 deletions(-)

Expand all Fold all

[PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

The Net/CanBus can_receive() handlers return whether
the network device can or can not receive new data.
Make it obvious by returning a boolean type

Philippe Mathieu-Daudé (6):
  hw/net/e1000e_core: Let e1000e_can_receive() return a boolean
  hw/net/smc91c111: Let smc91c111_can_receive() return a boolean
  hw/net/rtl8139: Simplify if/else statement
  hw/net/rtl8139: Update coding style to make checkpatch.pl happy
  hw/net: Make NetCanReceive() return a boolean
  hw/net/can: Make CanBusClientInfo::can_receive() return a boolean

 hw/net/can/can_sja1000.h |  2 +-
 hw/net/e1000e_core.h     |  2 +-
 hw/net/i82596.h          |  2 +-
 include/net/can_emu.h    |  2 +-
 include/net/net.h        |  2 +-
 hw/net/allwinner_emac.c  |  2 +-
 hw/net/cadence_gem.c     |  8 ++++----
 hw/net/can/can_sja1000.c |  8 ++++----
 hw/net/dp8393x.c         |  8 +++-----
 hw/net/e1000.c           |  2 +-
 hw/net/e1000e.c          |  2 +-
 hw/net/e1000e_core.c     |  2 +-
 hw/net/ftgmac100.c       |  6 +++---
 hw/net/i82596.c          | 10 +++++-----
 hw/net/imx_fec.c         |  2 +-
 hw/net/opencores_eth.c   |  5 ++---
 hw/net/rtl8139.c         | 22 ++++++++++++----------
 hw/net/smc91c111.c       | 10 +++++-----
 hw/net/spapr_llan.c      |  4 ++--
 hw/net/sungem.c          |  6 +++---
 hw/net/sunhme.c          |  4 ++--
 hw/net/virtio-net.c      | 10 +++++-----
 hw/net/xilinx_ethlite.c  |  2 +-
 net/can/can_socketcan.c  |  4 ++--
 net/filter-buffer.c      |  2 +-
 net/hub.c                |  6 +++---
 26 files changed, 67 insertions(+), 68 deletions(-)

-- 
2.21.1

Re: [PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

Ping?

This series is fully reviewed.

On 3/5/20 6:56 PM, Philippe Mathieu-Daudé wrote:
> The Net/CanBus can_receive() handlers return whether
> the network device can or can not receive new data.
> Make it obvious by returning a boolean type
> 
> Philippe Mathieu-Daudé (6):
>    hw/net/e1000e_core: Let e1000e_can_receive() return a boolean
>    hw/net/smc91c111: Let smc91c111_can_receive() return a boolean
>    hw/net/rtl8139: Simplify if/else statement
>    hw/net/rtl8139: Update coding style to make checkpatch.pl happy
>    hw/net: Make NetCanReceive() return a boolean
>    hw/net/can: Make CanBusClientInfo::can_receive() return a boolean
> 
>   hw/net/can/can_sja1000.h |  2 +-
>   hw/net/e1000e_core.h     |  2 +-
>   hw/net/i82596.h          |  2 +-
>   include/net/can_emu.h    |  2 +-
>   include/net/net.h        |  2 +-
>   hw/net/allwinner_emac.c  |  2 +-
>   hw/net/cadence_gem.c     |  8 ++++----
>   hw/net/can/can_sja1000.c |  8 ++++----
>   hw/net/dp8393x.c         |  8 +++-----
>   hw/net/e1000.c           |  2 +-
>   hw/net/e1000e.c          |  2 +-
>   hw/net/e1000e_core.c     |  2 +-
>   hw/net/ftgmac100.c       |  6 +++---
>   hw/net/i82596.c          | 10 +++++-----
>   hw/net/imx_fec.c         |  2 +-
>   hw/net/opencores_eth.c   |  5 ++---
>   hw/net/rtl8139.c         | 22 ++++++++++++----------
>   hw/net/smc91c111.c       | 10 +++++-----
>   hw/net/spapr_llan.c      |  4 ++--
>   hw/net/sungem.c          |  6 +++---
>   hw/net/sunhme.c          |  4 ++--
>   hw/net/virtio-net.c      | 10 +++++-----
>   hw/net/xilinx_ethlite.c  |  2 +-
>   net/can/can_socketcan.c  |  4 ++--
>   net/filter-buffer.c      |  2 +-
>   net/hub.c                |  6 +++---
>   26 files changed, 67 insertions(+), 68 deletions(-)
>

Re: [PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean

Posted by Jason Wang 5 years, 8 months ago

On 2020/3/17 下午6:47, Philippe Mathieu-Daudé wrote:
> Ping?
>
> This series is fully reviewed. 


Sorry for the delay.

Applied.

Thanks