[PATCH v2 0/4] qcow2: Implement zstd cluster compression method

Denis Plotnikov posted 4 patches 5 years, 8 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
docs/interop/qcow2.txt           |  20 ++++
configure                        |  29 +++++
qapi/block-core.json             |  23 +++-
block/qcow2.h                    |  18 ++-
include/block/block_int.h        |   1 +
block/qcow2-threads.c            | 197 ++++++++++++++++++++++++++++---
block/qcow2.c                    | 116 ++++++++++++++++++
tests/qemu-iotests/031.out       |  14 +--
tests/qemu-iotests/036.out       |   4 +-
tests/qemu-iotests/049.out       | 102 ++++++++--------
tests/qemu-iotests/060.out       |   1 +
tests/qemu-iotests/061.out       |  34 +++---
tests/qemu-iotests/065           |  20 ++--
tests/qemu-iotests/080           |   2 +-
tests/qemu-iotests/144.out       |   4 +-
tests/qemu-iotests/182.out       |   2 +-
tests/qemu-iotests/242.out       |   5 +
tests/qemu-iotests/255.out       |   8 +-
tests/qemu-iotests/287           | 127 ++++++++++++++++++++
tests/qemu-iotests/287.out       |  43 +++++++
tests/qemu-iotests/common.filter |   3 +-
tests/qemu-iotests/group         |   1 +
22 files changed, 666 insertions(+), 108 deletions(-)
create mode 100755 tests/qemu-iotests/287
create mode 100644 tests/qemu-iotests/287.out
[PATCH v2 0/4] qcow2: Implement zstd cluster compression method
Posted by Denis Plotnikov 5 years, 8 months ago
v2:
  * rework compression type setting [Vladimir]
  * squash iotest changes to the compression type introduction patch [Vladimir, Eric]
  * fix zstd availability checking in zstd iotest [Vladimir]
  * remove unnecessry casting [Eric]
  * remove rudundant checks [Eric]
  * fix compressed cluster layout in qcow2 spec [Vladimir]
  * fix wording [Eric, Vladimir]
  * fix compression type filtering in iotests [Eric]

v1:
  the initial series

---
zstd comression method is faster than the only available zlib.
The series adds zstd to the methods available for clusters compression.

The implementation is done with respect to the recently added compression
type additional header to the qcow2 specification.

Denis Plotnikov (4):
  qcow2: introduce compression type feature
  qcow2: rework the cluster compression routine
  qcow2: add zstd cluster compression
  iotests: 287: add qcow2 compression type test

 docs/interop/qcow2.txt           |  20 ++++
 configure                        |  29 +++++
 qapi/block-core.json             |  23 +++-
 block/qcow2.h                    |  18 ++-
 include/block/block_int.h        |   1 +
 block/qcow2-threads.c            | 197 ++++++++++++++++++++++++++++---
 block/qcow2.c                    | 116 ++++++++++++++++++
 tests/qemu-iotests/031.out       |  14 +--
 tests/qemu-iotests/036.out       |   4 +-
 tests/qemu-iotests/049.out       | 102 ++++++++--------
 tests/qemu-iotests/060.out       |   1 +
 tests/qemu-iotests/061.out       |  34 +++---
 tests/qemu-iotests/065           |  20 ++--
 tests/qemu-iotests/080           |   2 +-
 tests/qemu-iotests/144.out       |   4 +-
 tests/qemu-iotests/182.out       |   2 +-
 tests/qemu-iotests/242.out       |   5 +
 tests/qemu-iotests/255.out       |   8 +-
 tests/qemu-iotests/287           | 127 ++++++++++++++++++++
 tests/qemu-iotests/287.out       |  43 +++++++
 tests/qemu-iotests/common.filter |   3 +-
 tests/qemu-iotests/group         |   1 +
 22 files changed, 666 insertions(+), 108 deletions(-)
 create mode 100755 tests/qemu-iotests/287
 create mode 100644 tests/qemu-iotests/287.out

-- 
2.17.0


Re: [PATCH v2 0/4] qcow2: Implement zstd cluster compression method
Posted by Vladimir Sementsov-Ogievskiy 5 years, 8 months ago
Doesn't apply to master, as zstd already exists in ./configure :) (for migration)


02.03.2020 11:21, Denis Plotnikov wrote:
> v2:
>    * rework compression type setting [Vladimir]
>    * squash iotest changes to the compression type introduction patch [Vladimir, Eric]
>    * fix zstd availability checking in zstd iotest [Vladimir]
>    * remove unnecessry casting [Eric]
>    * remove rudundant checks [Eric]
>    * fix compressed cluster layout in qcow2 spec [Vladimir]
>    * fix wording [Eric, Vladimir]
>    * fix compression type filtering in iotests [Eric]
> 
> v1:
>    the initial series
> 
> ---
> zstd comression method is faster than the only available zlib.
> The series adds zstd to the methods available for clusters compression.
> 
> The implementation is done with respect to the recently added compression
> type additional header to the qcow2 specification.
> 
> Denis Plotnikov (4):
>    qcow2: introduce compression type feature
>    qcow2: rework the cluster compression routine
>    qcow2: add zstd cluster compression
>    iotests: 287: add qcow2 compression type test
> 
>   docs/interop/qcow2.txt           |  20 ++++
>   configure                        |  29 +++++
>   qapi/block-core.json             |  23 +++-
>   block/qcow2.h                    |  18 ++-
>   include/block/block_int.h        |   1 +
>   block/qcow2-threads.c            | 197 ++++++++++++++++++++++++++++---
>   block/qcow2.c                    | 116 ++++++++++++++++++
>   tests/qemu-iotests/031.out       |  14 +--
>   tests/qemu-iotests/036.out       |   4 +-
>   tests/qemu-iotests/049.out       | 102 ++++++++--------
>   tests/qemu-iotests/060.out       |   1 +
>   tests/qemu-iotests/061.out       |  34 +++---
>   tests/qemu-iotests/065           |  20 ++--
>   tests/qemu-iotests/080           |   2 +-
>   tests/qemu-iotests/144.out       |   4 +-
>   tests/qemu-iotests/182.out       |   2 +-
>   tests/qemu-iotests/242.out       |   5 +
>   tests/qemu-iotests/255.out       |   8 +-
>   tests/qemu-iotests/287           | 127 ++++++++++++++++++++
>   tests/qemu-iotests/287.out       |  43 +++++++
>   tests/qemu-iotests/common.filter |   3 +-
>   tests/qemu-iotests/group         |   1 +
>   22 files changed, 666 insertions(+), 108 deletions(-)
>   create mode 100755 tests/qemu-iotests/287
>   create mode 100644 tests/qemu-iotests/287.out
> 


-- 
Best regards,
Vladimir

Re: [PATCH v2 0/4] qcow2: Implement zstd cluster compression method
Posted by Denis Plotnikov 5 years, 8 months ago

On 02.03.2020 11:51, Vladimir Sementsov-Ogievskiy wrote:
> Doesn't apply to master, as zstd already exists in ./configure :) (for 
> migration)
Mmmmm, will rebase it. Any other comments?
>
>
> 02.03.2020 11:21, Denis Plotnikov wrote:
>> v2:
>>    * rework compression type setting [Vladimir]
>>    * squash iotest changes to the compression type introduction patch 
>> [Vladimir, Eric]
>>    * fix zstd availability checking in zstd iotest [Vladimir]
>>    * remove unnecessry casting [Eric]
>>    * remove rudundant checks [Eric]
>>    * fix compressed cluster layout in qcow2 spec [Vladimir]
>>    * fix wording [Eric, Vladimir]
>>    * fix compression type filtering in iotests [Eric]
>>
>> v1:
>>    the initial series
>>
>> ---
>> zstd comression method is faster than the only available zlib.
>> The series adds zstd to the methods available for clusters compression.
>>
>> The implementation is done with respect to the recently added 
>> compression
>> type additional header to the qcow2 specification.
>>
>> Denis Plotnikov (4):
>>    qcow2: introduce compression type feature
>>    qcow2: rework the cluster compression routine
>>    qcow2: add zstd cluster compression
>>    iotests: 287: add qcow2 compression type test
>>
>>   docs/interop/qcow2.txt           |  20 ++++
>>   configure                        |  29 +++++
>>   qapi/block-core.json             |  23 +++-
>>   block/qcow2.h                    |  18 ++-
>>   include/block/block_int.h        |   1 +
>>   block/qcow2-threads.c            | 197 ++++++++++++++++++++++++++++---
>>   block/qcow2.c                    | 116 ++++++++++++++++++
>>   tests/qemu-iotests/031.out       |  14 +--
>>   tests/qemu-iotests/036.out       |   4 +-
>>   tests/qemu-iotests/049.out       | 102 ++++++++--------
>>   tests/qemu-iotests/060.out       |   1 +
>>   tests/qemu-iotests/061.out       |  34 +++---
>>   tests/qemu-iotests/065           |  20 ++--
>>   tests/qemu-iotests/080           |   2 +-
>>   tests/qemu-iotests/144.out       |   4 +-
>>   tests/qemu-iotests/182.out       |   2 +-
>>   tests/qemu-iotests/242.out       |   5 +
>>   tests/qemu-iotests/255.out       |   8 +-
>>   tests/qemu-iotests/287           | 127 ++++++++++++++++++++
>>   tests/qemu-iotests/287.out       |  43 +++++++
>>   tests/qemu-iotests/common.filter |   3 +-
>>   tests/qemu-iotests/group         |   1 +
>>   22 files changed, 666 insertions(+), 108 deletions(-)
>>   create mode 100755 tests/qemu-iotests/287
>>   create mode 100644 tests/qemu-iotests/287.out
>>
>
>