hw/arm/cubieboard: correct CPU type and add machine argument checks

[PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

Posted by Niek Linnenbank 5 years, 8 months ago

These patches change the Cubieboard machine definition to use the
correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9.

Additionally, add some sanity checks for the machine input
arguments in the initialization function.

Niek Linnenbank (4):
  hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine
    definition
  hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8
  hw/arm/cubieboard: restrict allowed RAM size to 512MiB and 1GiB
  hw/arm/cubieboard: report error when using unsupported -bios argument

 hw/arm/cubieboard.c | 29 ++++++++++++++++++++++++++---
 1 file changed, 26 insertions(+), 3 deletions(-)

-- 
2.17.1

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

Posted by Peter Maydell 5 years, 8 months ago

On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank <nieklinnenbank@gmail.com> wrote:
>
> These patches change the Cubieboard machine definition to use the
> correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9.
>
> Additionally, add some sanity checks for the machine input
> arguments in the initialization function.
>
> Niek Linnenbank (4):
>   hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine
>     definition
>   hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8
>   hw/arm/cubieboard: restrict allowed RAM size to 512MiB and 1GiB
>   hw/arm/cubieboard: report error when using unsupported -bios argument


Applied to target-arm.next, thanks. (I tweaked a couple of commit
messages as mentioned in replies to those patches.)

-- PMM

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

Posted by Niek Linnenbank 5 years, 8 months ago

Hi Peter, Philippe,

On Mon, Mar 2, 2020 at 5:06 PM Peter Maydell <peter.maydell@linaro.org>
wrote:

> On Thu, 27 Feb 2020 at 22:01, Niek Linnenbank <nieklinnenbank@gmail.com>
> wrote:
> >
> > These patches change the Cubieboard machine definition to use the
> > correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9.
> >
> > Additionally, add some sanity checks for the machine input
> > arguments in the initialization function.
> >
> > Niek Linnenbank (4):
> >   hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine
> >     definition
> >   hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8
> >   hw/arm/cubieboard: restrict allowed RAM size to 512MiB and 1GiB
> >   hw/arm/cubieboard: report error when using unsupported -bios argument
>
>
> Applied to target-arm.next, thanks. (I tweaked a couple of commit
> messages as mentioned in replies to those patches.)
>

Great, and thanks for your quick and detailed responses Peter.

And to be clear, these improvements came from the excellent reviews done by
Philippe on the Allwinner H3 patch series
which I submitted earlier. Since that series is quite big and will take
more time to complete, I thought it would be nice
to take a few of those improvements and meanwhile apply them to the other
similar boards as well.

Regards,
Niek

>
> -- PMM
>

-- 
Niek Linnenbank

Re: [PATCH v1 0/4] hw/arm/cubieboard: correct CPU type and add machine argument checks

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

On 2/27/20 11:01 PM, Niek Linnenbank wrote:
> These patches change the Cubieboard machine definition to use the
> correct CPU type, which is ARM Cortex-A8 instead of ARM Cortex-A9.
> 
> Additionally, add some sanity checks for the machine input
> arguments in the initialization function.
> 
> Niek Linnenbank (4):
>    hw/arm/cubieboard: use ARM Cortex-A8 as the default CPU in machine
>      definition
>    hw/arm/cubieboard: restrict allowed CPU type to ARM Cortex-A8
>    hw/arm/cubieboard: restrict allowed RAM size to 512MiB and 1GiB
>    hw/arm/cubieboard: report error when using unsupported -bios argument
> 
>   hw/arm/cubieboard.c | 29 ++++++++++++++++++++++++++---
>   1 file changed, 26 insertions(+), 3 deletions(-)
> 

Series:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>