virtiofsd: Fix xattr operations

[PATCH v4 0/2] virtiofsd: Fix xattr operations

Posted by Misono Tomohiro 5 years, 8 months ago

Currently xattr operations on virtiofs does not work properly in some case:
 - directory ... cannot set
 - special files (pipe) ... cause hang

This fixes these problems and now xfstests generic/062 passes on virtiofs
with -o xattr option (I tested with xfs).

v3 -> v4:
 - No logic change
 - Some code style fix/update comments and commit log as suggested by Vivek
 - CC qemu-devel ML too

Previous versions can be found in virtiofs ML:
 v3: https://www.redhat.com/archives/virtio-fs/2020-February/msg00032.html

Thanks,
Misono Tomohiro (2):
  virtiofsd: passthrough_ll: cleanup getxattr/listxattr
  virtiofsd: Fix xattr operations

 tools/virtiofsd/fuse_virtio.c    |  13 +++
 tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++---------------
 tools/virtiofsd/seccomp.c        |   6 ++
 3 files changed, 89 insertions(+), 69 deletions(-)

-- 
2.21.1

Re: [PATCH v4 0/2] virtiofsd: Fix xattr operations

Posted by Vivek Goyal 5 years, 8 months ago

On Thu, Feb 27, 2020 at 02:59:25PM +0900, Misono Tomohiro wrote:
> Currently xattr operations on virtiofs does not work properly in some case:
>  - directory ... cannot set
>  - special files (pipe) ... cause hang
> 
> This fixes these problems and now xfstests generic/062 passes on virtiofs
> with -o xattr option (I tested with xfs).
> 
> v3 -> v4:
>  - No logic change
>  - Some code style fix/update comments and commit log as suggested by Vivek
>  - CC qemu-devel ML too
> 
> Previous versions can be found in virtiofs ML:
>  v3: https://www.redhat.com/archives/virtio-fs/2020-February/msg00032.html
> 
> Thanks,
> Misono Tomohiro (2):
>   virtiofsd: passthrough_ll: cleanup getxattr/listxattr
>   virtiofsd: Fix xattr operations

Thanks Misono for this work. I am fine with this patch series.

Acked-by: Vivek Goyal <vgoyal@redhat.com>

Thanks
Vivek

> 
>  tools/virtiofsd/fuse_virtio.c    |  13 +++
>  tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++---------------
>  tools/virtiofsd/seccomp.c        |   6 ++
>  3 files changed, 89 insertions(+), 69 deletions(-)
> 
> -- 
> 2.21.1
>

Re: [Virtio-fs] [PATCH v4 0/2] virtiofsd: Fix xattr operations

Posted by Dr. David Alan Gilbert 5 years, 8 months ago

* Misono Tomohiro (misono.tomohiro@jp.fujitsu.com) wrote:
> Currently xattr operations on virtiofs does not work properly in some case:
>  - directory ... cannot set
>  - special files (pipe) ... cause hang
> 
> This fixes these problems and now xfstests generic/062 passes on virtiofs
> with -o xattr option (I tested with xfs).
> 
> v3 -> v4:
>  - No logic change
>  - Some code style fix/update comments and commit log as suggested by Vivek
>  - CC qemu-devel ML too
> 
> Previous versions can be found in virtiofs ML:
>  v3: https://www.redhat.com/archives/virtio-fs/2020-February/msg00032.html
> 
> Thanks,

Thanks,

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

and queued.

(I suspect there's some more cleanup involved in the error paths in
those functions; I'll have a look another time).

Dave

> Misono Tomohiro (2):
>   virtiofsd: passthrough_ll: cleanup getxattr/listxattr
>   virtiofsd: Fix xattr operations
> 
>  tools/virtiofsd/fuse_virtio.c    |  13 +++
>  tools/virtiofsd/passthrough_ll.c | 139 ++++++++++++++++---------------
>  tools/virtiofsd/seccomp.c        |   6 ++
>  3 files changed, 89 insertions(+), 69 deletions(-)
> 
> -- 
> 2.21.1
> 
> 
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK