qemu-doc.texi | 44 + configure | 11 +- default-configs/rx-softmmu.mak | 3 + qapi/machine.json | 2 +- include/disas/dis-asm.h | 5 + include/exec/poison.h | 1 + include/hw/char/renesas_sci.h | 45 + include/hw/intc/rx_icu.h | 56 + include/hw/registerfields.h | 32 +- include/hw/rx/rx.h | 7 + include/hw/rx/rx62n.h | 91 + include/hw/timer/renesas_cmt.h | 38 + include/hw/timer/renesas_tmr.h | 53 + include/qemu/bitops.h | 38 + include/sysemu/arch_init.h | 1 + target/rx/cpu-param.h | 31 + target/rx/cpu-qom.h | 42 + target/rx/cpu.h | 181 ++ target/rx/helper.h | 31 + target/rx/insns.decode | 621 ++++++ arch_init.c | 2 + hw/char/renesas_sci.c | 342 ++++ hw/intc/rx_icu.c | 379 ++++ hw/rx/rx-virt.c | 142 ++ hw/rx/rx62n.c | 247 +++ hw/timer/renesas_cmt.c | 278 +++ hw/timer/renesas_tmr.c | 458 +++++ target/rx/cpu.c | 218 +++ target/rx/disas.c | 1446 ++++++++++++++ target/rx/gdbstub.c | 112 ++ target/rx/helper.c | 149 ++ target/rx/op_helper.c | 470 +++++ target/rx/translate.c | 2432 ++++++++++++++++++++++++ tests/qtest/machine-none-test.c | 1 + MAINTAINERS | 19 + gdb-xml/rx-core.xml | 70 + hw/Kconfig | 1 + hw/char/Kconfig | 3 + hw/char/Makefile.objs | 1 + hw/intc/Kconfig | 3 + hw/intc/Makefile.objs | 1 + hw/rx/Kconfig | 14 + hw/rx/Makefile.objs | 2 + hw/timer/Kconfig | 6 + hw/timer/Makefile.objs | 3 + target/rx/Makefile.objs | 11 + tests/acceptance/boot_linux_console.py | 46 + 47 files changed, 8186 insertions(+), 3 deletions(-) create mode 100644 default-configs/rx-softmmu.mak create mode 100644 include/hw/char/renesas_sci.h create mode 100644 include/hw/intc/rx_icu.h create mode 100644 include/hw/rx/rx.h create mode 100644 include/hw/rx/rx62n.h create mode 100644 include/hw/timer/renesas_cmt.h create mode 100644 include/hw/timer/renesas_tmr.h create mode 100644 target/rx/cpu-param.h create mode 100644 target/rx/cpu-qom.h create mode 100644 target/rx/cpu.h create mode 100644 target/rx/helper.h create mode 100644 target/rx/insns.decode create mode 100644 hw/char/renesas_sci.c create mode 100644 hw/intc/rx_icu.c create mode 100644 hw/rx/rx-virt.c create mode 100644 hw/rx/rx62n.c create mode 100644 hw/timer/renesas_cmt.c create mode 100644 hw/timer/renesas_tmr.c create mode 100644 target/rx/cpu.c create mode 100644 target/rx/disas.c create mode 100644 target/rx/gdbstub.c create mode 100644 target/rx/helper.c create mode 100644 target/rx/op_helper.c create mode 100644 target/rx/translate.c create mode 100644 gdb-xml/rx-core.xml create mode 100644 hw/rx/Kconfig create mode 100644 hw/rx/Makefile.objs create mode 100644 target/rx/Makefile.objs
Hello.
This patch series is added Renesas RX target emulation.
Changes for v30.
Follow master changes.
Fix checkpatch error.
Changes for v29.
Add target description XML. It required gdb-9.1.
Follow git master changes.
Changes for v28.
Allow -m option.
With this option, 16 Mbytes or more can be specified.
Add example for qemu-doc.
Fix build error on latest master.
Changes for v27.
Added RX section to qemu-doc.
Rebase for master
Changes for v26.
Rebase for 5.0
Update machine.json for 5.0
Changes for v25.
Update commit message.
Squashed qapi/machine.json changes.
Changes for v24.
Add note for qapi/machine.json.
Added Acked-by for 6/22.
git rebase master.
Changes for v23.
Follow master changes.
Changes for v22.
Added some include.
Changes for v21.
rebase latest master.
Remove unneeded hmp_info_tlb.
Chanegs for v20.
Reorderd patches.
Squashed v19 changes.
Changes for v19.
Follow tcg changes.
Cleanup cpu.c.
simplify rx_cpu_class_by_name and rx_load_image move to rx-virt.
My git repository is bellow.
git://git.pf.osdn.net/gitroot/y/ys/ysato/qemu.git tags/rx-20200223
Testing binaries bellow.
u-boot
Download - https://osdn.net/users/ysato/pf/qemu/dl/u-boot.bin.gz
starting
$ gzip -d u-boot.bin.gz
$ qemu-system-rx -bios u-boot.bin
linux and pico-root (only sash)
Download - https://osdn.net/users/ysato/pf/qemu/dl/zImage (kernel)
https://osdn.net/users/ysato/pf/qemu/dl/rx-virt.dtb (DeviceTree)
starting
$ qemu-system-rx -kernel zImage -dtb rx-virt.dtb -append "earlycon"
Philippe Mathieu-Daudé (3):
hw/registerfields.h: Add 8bit and 16bit register macros
hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
BootLinuxConsoleTest: Test the RX-Virt machine
Richard Henderson (7):
target/rx: Disassemble rx_index_addr into a string
target/rx: Replace operand with prt_ldmi in disassembler
target/rx: Use prt_ldmi for XCHG_mr disassembly
target/rx: Emit all disassembly in one prt()
target/rx: Collect all bytes during disassembly
target/rx: Dump bytes for each insn during disassembly
hw/rx: Honor -accel qtest
Yoshinori Sato (12):
MAINTAINERS: Add RX
qemu/bitops.h: Add extract8 and extract16
target/rx: TCG translation
target/rx: TCG helper
target/rx: CPU definition
target/rx: RX disassembler
hw/intc: RX62N interrupt controller (ICUa)
hw/timer: RX62N internal timer modules
hw/char: RX62N serial communication interface (SCI)
hw/rx: RX Target hardware definition
Add rx-softmmu
qemu-doc.texi: Add RX section.
qemu-doc.texi | 44 +
configure | 11 +-
default-configs/rx-softmmu.mak | 3 +
qapi/machine.json | 2 +-
include/disas/dis-asm.h | 5 +
include/exec/poison.h | 1 +
include/hw/char/renesas_sci.h | 45 +
include/hw/intc/rx_icu.h | 56 +
include/hw/registerfields.h | 32 +-
include/hw/rx/rx.h | 7 +
include/hw/rx/rx62n.h | 91 +
include/hw/timer/renesas_cmt.h | 38 +
include/hw/timer/renesas_tmr.h | 53 +
include/qemu/bitops.h | 38 +
include/sysemu/arch_init.h | 1 +
target/rx/cpu-param.h | 31 +
target/rx/cpu-qom.h | 42 +
target/rx/cpu.h | 181 ++
target/rx/helper.h | 31 +
target/rx/insns.decode | 621 ++++++
arch_init.c | 2 +
hw/char/renesas_sci.c | 342 ++++
hw/intc/rx_icu.c | 379 ++++
hw/rx/rx-virt.c | 142 ++
hw/rx/rx62n.c | 247 +++
hw/timer/renesas_cmt.c | 278 +++
hw/timer/renesas_tmr.c | 458 +++++
target/rx/cpu.c | 218 +++
target/rx/disas.c | 1446 ++++++++++++++
target/rx/gdbstub.c | 112 ++
target/rx/helper.c | 149 ++
target/rx/op_helper.c | 470 +++++
target/rx/translate.c | 2432 ++++++++++++++++++++++++
tests/qtest/machine-none-test.c | 1 +
MAINTAINERS | 19 +
gdb-xml/rx-core.xml | 70 +
hw/Kconfig | 1 +
hw/char/Kconfig | 3 +
hw/char/Makefile.objs | 1 +
hw/intc/Kconfig | 3 +
hw/intc/Makefile.objs | 1 +
hw/rx/Kconfig | 14 +
hw/rx/Makefile.objs | 2 +
hw/timer/Kconfig | 6 +
hw/timer/Makefile.objs | 3 +
target/rx/Makefile.objs | 11 +
tests/acceptance/boot_linux_console.py | 46 +
47 files changed, 8186 insertions(+), 3 deletions(-)
create mode 100644 default-configs/rx-softmmu.mak
create mode 100644 include/hw/char/renesas_sci.h
create mode 100644 include/hw/intc/rx_icu.h
create mode 100644 include/hw/rx/rx.h
create mode 100644 include/hw/rx/rx62n.h
create mode 100644 include/hw/timer/renesas_cmt.h
create mode 100644 include/hw/timer/renesas_tmr.h
create mode 100644 target/rx/cpu-param.h
create mode 100644 target/rx/cpu-qom.h
create mode 100644 target/rx/cpu.h
create mode 100644 target/rx/helper.h
create mode 100644 target/rx/insns.decode
create mode 100644 hw/char/renesas_sci.c
create mode 100644 hw/intc/rx_icu.c
create mode 100644 hw/rx/rx-virt.c
create mode 100644 hw/rx/rx62n.c
create mode 100644 hw/timer/renesas_cmt.c
create mode 100644 hw/timer/renesas_tmr.c
create mode 100644 target/rx/cpu.c
create mode 100644 target/rx/disas.c
create mode 100644 target/rx/gdbstub.c
create mode 100644 target/rx/helper.c
create mode 100644 target/rx/op_helper.c
create mode 100644 target/rx/translate.c
create mode 100644 gdb-xml/rx-core.xml
create mode 100644 hw/rx/Kconfig
create mode 100644 hw/rx/Makefile.objs
create mode 100644 target/rx/Makefile.objs
--
2.20.1
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
98aae80 qemu-doc.texi: Add RX section.
c084aad BootLinuxConsoleTest: Test the RX-Virt machine
d38442f Add rx-softmmu
b518869 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
3649961 hw/rx: Honor -accel qtest
a354c0e hw/rx: RX Target hardware definition
279d917 hw/char: RX62N serial communication interface (SCI)
47f494d hw/timer: RX62N internal timer modules
f92e9ad hw/intc: RX62N interrupt controller (ICUa)
08a2021 target/rx: Dump bytes for each insn during disassembly
18cbc61 target/rx: Collect all bytes during disassembly
accb127 target/rx: Emit all disassembly in one prt()
7819841 target/rx: Use prt_ldmi for XCHG_mr disassembly
d2a8b8d target/rx: Replace operand with prt_ldmi in disassembler
5281766 target/rx: Disassemble rx_index_addr into a string
1c44ec2 target/rx: RX disassembler
28cd499 target/rx: CPU definition
7128a45 target/rx: TCG helper
a6df174 target/rx: TCG translation
bed06eb hw/registerfields.h: Add 8bit and 16bit register macros
862b2a3 qemu/bitops.h: Add extract8 and extract16
aa57148 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit aa5714805044 (MAINTAINERS: Add RX)
2/22 Checking commit 862b2a3f68b6 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit bed06eb00edb (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit a6df17471dbc (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 7128a45b6a9b (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 28cd4994482f (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 1c44ec22dd4a (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 5281766b6573 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit d2a8b8d65cbe (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 7819841c2e13 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit accb127df60f (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 18cbc6142921 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 08a20215da87 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit f92e9adb3005 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 47f494d3393d (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 279d91729697 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit a354c0e0a816 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 3649961b949a (hw/rx: Honor -accel qtest)
19/22 Checking commit b518869e57de (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit d38442f1d1da (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit c084aad40172 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 98aae803957c (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
d173993 qemu-doc.texi: Add RX section.
08d3f31 BootLinuxConsoleTest: Test the RX-Virt machine
140c2a9 Add rx-softmmu
b91da7c hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
a8a29a0 hw/rx: Honor -accel qtest
383596a hw/rx: RX Target hardware definition
dfecadf hw/char: RX62N serial communication interface (SCI)
72c1fb6 hw/timer: RX62N internal timer modules
6ef5b99 hw/intc: RX62N interrupt controller (ICUa)
7c9df96 target/rx: Dump bytes for each insn during disassembly
57a95b5 target/rx: Collect all bytes during disassembly
4c578dc target/rx: Emit all disassembly in one prt()
7c52762 target/rx: Use prt_ldmi for XCHG_mr disassembly
dabd7b8 target/rx: Replace operand with prt_ldmi in disassembler
cc845e0 target/rx: Disassemble rx_index_addr into a string
29fd721 target/rx: RX disassembler
c63fd90 target/rx: CPU definition
564ac35 target/rx: TCG helper
a7d0555 target/rx: TCG translation
edf076e hw/registerfields.h: Add 8bit and 16bit register macros
cdac152 qemu/bitops.h: Add extract8 and extract16
515473d MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 515473d095ae (MAINTAINERS: Add RX)
2/22 Checking commit cdac152ea185 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit edf076e770e6 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit a7d0555170f7 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 564ac3576864 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit c63fd90cc1dd (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 29fd721eed0f (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit cc845e0092bf (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit dabd7b8f7abb (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 7c52762b41d2 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 4c578dc81272 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 57a95b515b8c (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 7c9df9686b25 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 6ef5b990e770 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 72c1fb69d09a (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit dfecadfc4ad6 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 383596a8226b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit a8a29a0484fd (hw/rx: Honor -accel qtest)
19/22 Checking commit b91da7ceda20 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 140c2a98b6d7 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 08d3f317aa66 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit d1739933451f (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
e61bc34 qemu-doc.texi: Add RX section.
51c47be BootLinuxConsoleTest: Test the RX-Virt machine
081293e Add rx-softmmu
ecc34cc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
8dd4bc3 hw/rx: Honor -accel qtest
c71def2 hw/rx: RX Target hardware definition
2688648 hw/char: RX62N serial communication interface (SCI)
e46e80e hw/timer: RX62N internal timer modules
a3bafbd hw/intc: RX62N interrupt controller (ICUa)
b5f8f99 target/rx: Dump bytes for each insn during disassembly
4baf95c target/rx: Collect all bytes during disassembly
493d694 target/rx: Emit all disassembly in one prt()
fb79793 target/rx: Use prt_ldmi for XCHG_mr disassembly
83895a6 target/rx: Replace operand with prt_ldmi in disassembler
57c13f4 target/rx: Disassemble rx_index_addr into a string
eac7966 target/rx: RX disassembler
4507bfa target/rx: CPU definition
70baa9c target/rx: TCG helper
9b4cfd9 target/rx: TCG translation
45b9c13 hw/registerfields.h: Add 8bit and 16bit register macros
def1cbc qemu/bitops.h: Add extract8 and extract16
99e018a MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 99e018a6891a (MAINTAINERS: Add RX)
2/22 Checking commit def1cbc185ff (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 45b9c136bce4 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 9b4cfd96470c (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 70baa9c25adc (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 4507bfa603c1 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit eac796699693 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 57c13f4d87e8 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 83895a61feaa (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit fb797930f7c0 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 493d69462444 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 4baf95c2aa5f (target/rx: Collect all bytes during disassembly)
13/22 Checking commit b5f8f9908936 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit a3bafbd9ad4c (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit e46e80e33e2a (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 26886486083f (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit c71def207626 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 8dd4bc3d4b00 (hw/rx: Honor -accel qtest)
19/22 Checking commit ecc34cca2b28 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 081293e170a6 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 51c47bedb046 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit e61bc346bacf (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
6792035 qemu-doc.texi: Add RX section.
e9b9c53 BootLinuxConsoleTest: Test the RX-Virt machine
e69f0fe Add rx-softmmu
543492d hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
790f86f hw/rx: Honor -accel qtest
f4de752 hw/rx: RX Target hardware definition
e56b953 hw/char: RX62N serial communication interface (SCI)
ca7613a hw/timer: RX62N internal timer modules
94ac051 hw/intc: RX62N interrupt controller (ICUa)
349328c target/rx: Dump bytes for each insn during disassembly
2a29d79 target/rx: Collect all bytes during disassembly
aa9b8f9 target/rx: Emit all disassembly in one prt()
b5eb1f9 target/rx: Use prt_ldmi for XCHG_mr disassembly
78a163c target/rx: Replace operand with prt_ldmi in disassembler
8e2cb45 target/rx: Disassemble rx_index_addr into a string
edb0e05 target/rx: RX disassembler
f6c4506 target/rx: CPU definition
fb85bb5 target/rx: TCG helper
96a6161 target/rx: TCG translation
19228d9 hw/registerfields.h: Add 8bit and 16bit register macros
ebb09d9 qemu/bitops.h: Add extract8 and extract16
5e82c32 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 5e82c320d820 (MAINTAINERS: Add RX)
2/22 Checking commit ebb09d904065 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 19228d9dd8a0 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 96a616132ea1 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit fb85bb5bd6e4 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit f6c450601f6a (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit edb0e05bcbbe (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 8e2cb450947e (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 78a163c7973e (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit b5eb1f90ab15 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit aa9b8f91a8ce (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 2a29d797f728 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 349328c9b06e (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 94ac051460e0 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit ca7613aae2da (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit e56b953fbd80 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit f4de752661bb (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 790f86ff179a (hw/rx: Honor -accel qtest)
19/22 Checking commit 543492d100fd (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit e69f0fe3d566 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit e9b9c53e73d5 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 67920354d2c2 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
433172d qemu-doc.texi: Add RX section.
c0c0863 BootLinuxConsoleTest: Test the RX-Virt machine
5dbb5d7 Add rx-softmmu
8bb88da hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
cf49ce3 hw/rx: Honor -accel qtest
32a72b7 hw/rx: RX Target hardware definition
eec292e hw/char: RX62N serial communication interface (SCI)
91c1557 hw/timer: RX62N internal timer modules
33e1d07 hw/intc: RX62N interrupt controller (ICUa)
ab11fd0 target/rx: Dump bytes for each insn during disassembly
6299441 target/rx: Collect all bytes during disassembly
d3c39ed target/rx: Emit all disassembly in one prt()
1f9bc5c target/rx: Use prt_ldmi for XCHG_mr disassembly
1665693 target/rx: Replace operand with prt_ldmi in disassembler
23259ca target/rx: Disassemble rx_index_addr into a string
779d660 target/rx: RX disassembler
4b81352 target/rx: CPU definition
8bc073b target/rx: TCG helper
f4c1c7b target/rx: TCG translation
cc41d5a hw/registerfields.h: Add 8bit and 16bit register macros
24fee16 qemu/bitops.h: Add extract8 and extract16
2848107 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 2848107d5e5a (MAINTAINERS: Add RX)
2/22 Checking commit 24fee169ad38 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit cc41d5a4ab76 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit f4c1c7b7c6a6 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 8bc073b2f5ff (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit 4b8135204261 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 779d66082061 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 23259ca25efd (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 166569349e2b (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 1f9bc5c6a4b9 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit d3c39ed17740 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit 629944121f05 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit ab11fd0114db (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 33e1d077739a (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 91c1557b1025 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit eec292e10649 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 32a72b70bf4c (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit cf49ce325d60 (hw/rx: Honor -accel qtest)
19/22 Checking commit 8bb88daa7a4f (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit 5dbb5d789697 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit c0c0863e799d (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 433172d9188b (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
207fda1 qemu-doc.texi: Add RX section.
1d2f2ed BootLinuxConsoleTest: Test the RX-Virt machine
de2e11e Add rx-softmmu
534f2cc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
5ced9d2 hw/rx: Honor -accel qtest
63f4519 hw/rx: RX Target hardware definition
95ec5ac hw/char: RX62N serial communication interface (SCI)
f087bf6 hw/timer: RX62N internal timer modules
9c1d3ea hw/intc: RX62N interrupt controller (ICUa)
3064ee8 target/rx: Dump bytes for each insn during disassembly
d95bde1 target/rx: Collect all bytes during disassembly
4cf6a3b target/rx: Emit all disassembly in one prt()
256823f target/rx: Use prt_ldmi for XCHG_mr disassembly
67672ed target/rx: Replace operand with prt_ldmi in disassembler
dc31fb3 target/rx: Disassemble rx_index_addr into a string
01690ad target/rx: RX disassembler
f30ec96 target/rx: CPU definition
d2d394c target/rx: TCG helper
35f89fa target/rx: TCG translation
0306f20 hw/registerfields.h: Add 8bit and 16bit register macros
8750517 qemu/bitops.h: Add extract8 and extract16
8e03a10 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 8e03a1004db2 (MAINTAINERS: Add RX)
2/22 Checking commit 875051703f0c (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit 0306f201fabd (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 35f89fa2be21 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit d2d394c6b3fa (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit f30ec963e940 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 01690adab631 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit dc31fb3d7505 (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit 67672edb237b (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 256823f4a9c3 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit 4cf6a3b12d30 (target/rx: Emit all disassembly in one prt())
12/22 Checking commit d95bde1169a7 (target/rx: Collect all bytes during disassembly)
13/22 Checking commit 3064ee8af26b (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit 9c1d3ea50c50 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit f087bf6f0a35 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit 95ec5acdf76b (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 63f45194b77b (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit 5ced9d2932a6 (hw/rx: Honor -accel qtest)
19/22 Checking commit 534f2cc37de4 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit de2e11e8dc10 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit 1d2f2ed13686 (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 207fda1ae52a (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200223065102.61652-1-ysato@users.sourceforge.jp/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH v31 00/22] Add RX archtecture support
Message-id: 20200223065102.61652-1-ysato@users.sourceforge.jp
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200223065102.61652-1-ysato@users.sourceforge.jp -> patchew/20200223065102.61652-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
79472fc qemu-doc.texi: Add RX section.
bd371ff BootLinuxConsoleTest: Test the RX-Virt machine
c75b5f4 Add rx-softmmu
bf2e2bc hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
b7dfe3b hw/rx: Honor -accel qtest
339fc1d hw/rx: RX Target hardware definition
c128024 hw/char: RX62N serial communication interface (SCI)
25d3642 hw/timer: RX62N internal timer modules
e5bcfcc hw/intc: RX62N interrupt controller (ICUa)
f3ed420 target/rx: Dump bytes for each insn during disassembly
d91d5de target/rx: Collect all bytes during disassembly
af1f29d target/rx: Emit all disassembly in one prt()
139d128 target/rx: Use prt_ldmi for XCHG_mr disassembly
ce57f2b target/rx: Replace operand with prt_ldmi in disassembler
6b42450 target/rx: Disassemble rx_index_addr into a string
2c0ad18 target/rx: RX disassembler
d9a2091 target/rx: CPU definition
40b7889 target/rx: TCG helper
66a8864 target/rx: TCG translation
baa046c hw/registerfields.h: Add 8bit and 16bit register macros
937a129 qemu/bitops.h: Add extract8 and extract16
223e016 MAINTAINERS: Add RX
=== OUTPUT BEGIN ===
1/22 Checking commit 223e0168cb67 (MAINTAINERS: Add RX)
2/22 Checking commit 937a12933240 (qemu/bitops.h: Add extract8 and extract16)
3/22 Checking commit baa046c7e9c4 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value in concatenation (.) or string at ./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) };
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr) \
+ enum { A_ ## reg = (addr) }; \
+ enum { R_ ## reg = (addr) / 2 };
total: 2 errors, 0 warnings, 56 lines checked
Patch 3/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/22 Checking commit 66a88645bcf3 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20:
new file mode 100644
total: 0 errors, 1 warnings, 3065 lines checked
Patch 4/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/22 Checking commit 40b78890b8cc (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21:
new file mode 100644
total: 0 errors, 1 warnings, 650 lines checked
Patch 5/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/22 Checking commit d9a209123c2b (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22:
new file mode 100644
total: 0 errors, 1 warnings, 659 lines checked
Patch 6/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/22 Checking commit 2c0ad1854322 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38:
new file mode 100644
total: 0 errors, 1 warnings, 1497 lines checked
Patch 7/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/22 Checking commit 6b424507906f (target/rx: Disassemble rx_index_addr into a string)
9/22 Checking commit ce57f2b3ff96 (target/rx: Replace operand with prt_ldmi in disassembler)
10/22 Checking commit 139d1286a3fe (target/rx: Use prt_ldmi for XCHG_mr disassembly)
11/22 Checking commit af1f29d9b29c (target/rx: Emit all disassembly in one prt())
12/22 Checking commit d91d5de6744b (target/rx: Collect all bytes during disassembly)
13/22 Checking commit f3ed4200ae02 (target/rx: Dump bytes for each insn during disassembly)
14/22 Checking commit e5bcfcc3ea20 (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40:
new file mode 100644
total: 0 errors, 1 warnings, 445 lines checked
Patch 14/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/22 Checking commit 25d3642bdd5a (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50:
new file mode 100644
total: 0 errors, 1 warnings, 845 lines checked
Patch 15/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/22 Checking commit c1280246f9e0 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
total: 0 errors, 1 warnings, 400 lines checked
Patch 16/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/22 Checking commit 339fc1d42cac (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#146: FILE: hw/rx/rx-virt.c:91:
+ /* The kernel image is loaded into
WARNING: Block comments use * on subsequent lines
#147: FILE: hw/rx/rx-virt.c:92:
+ /* The kernel image is loaded into
+ the latter half of the SDRAM space. */
WARNING: Block comments use a trailing */ on a separate line
#147: FILE: hw/rx/rx-virt.c:92:
+ the latter half of the SDRAM space. */
total: 0 errors, 4 warnings, 493 lines checked
Patch 17/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/22 Checking commit b7dfe3b524b2 (hw/rx: Honor -accel qtest)
19/22 Checking commit bf2e2bce3a3a (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/22 Checking commit c75b5f408eb8 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#69:
new file mode 100644
total: 0 errors, 1 warnings, 76 lines checked
Patch 20/22 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/22 Checking commit bd371ff24b6a (BootLinuxConsoleTest: Test the RX-Virt machine)
22/22 Checking commit 79472fc6b647 (qemu-doc.texi: Add RX section.)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200223065102.61652-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.