hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()

[PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()

Philippe Mathieu-Daudé posted 1 patch 4 years, 1 month ago

Download mbox

Test docker-quick@centos7 failed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200221162011.26383-1-philmd@redhat.com

Maintainers: Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Aleksandar Markovic <amarkovic@wavecomp.com>

hw/mips/mips_int.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()

Posted by Philippe Mathieu-Daudé 4 years, 1 month ago

Since commit d8ed887bdc, the cpu_mips_irq_request handler takes
a pointer to MIPSCPU in its opaque argument.  Directly pass the
cpu pointer.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/mips/mips_int.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
index 863ed45659..796730b11d 100644
--- a/hw/mips/mips_int.c
+++ b/hw/mips/mips_int.c
@@ -77,7 +77,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
     qemu_irq *qi;
     int i;
 
-    qi = qemu_allocate_irqs(cpu_mips_irq_request, env_archcpu(env), 8);
+    qi = qemu_allocate_irqs(cpu_mips_irq_request, cpu, 8);
     for (i = 0; i < 8; i++) {
         env->irq[i] = qi[i];
     }
-- 
2.21.1

Re: [PATCH] hw/mips/mips_int: Simplify cpu_mips_irq_init_cpu()

Posted by Aleksandar Markovic 4 years, 1 month ago

On Friday, February 21, 2020, Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:

> Since commit d8ed887bdc, the cpu_mips_irq_request handler takes
> a pointer to MIPSCPU in its opaque argument.  Directly pass the
> cpu pointer.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---


Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>

Applied to the next MIPS queue.


>  hw/mips/mips_int.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index 863ed45659..796730b11d 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -77,7 +77,7 @@ void cpu_mips_irq_init_cpu(MIPSCPU *cpu)
>      qemu_irq *qi;
>      int i;
>
> -    qi = qemu_allocate_irqs(cpu_mips_irq_request, env_archcpu(env), 8);
> +    qi = qemu_allocate_irqs(cpu_mips_irq_request, cpu, 8);
>      for (i = 0; i < 8; i++) {
>          env->irq[i] = qi[i];
>      }
> --
> 2.21.1
>
>
>