hw: More dma_memory_read/write() API cleanup

[PATCH 0/3] hw: More dma_memory_read/write() API cleanup

Philippe Mathieu-Daudé posted 3 patches 4 years, 1 month ago

Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200221132550.22156-1-philmd@redhat.com

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Jason Wang <jasowang@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Fam Zheng <fam@euphon.net>

hw/net/pcnet.h                 |  4 ++--
include/hw/scsi/esp.h          |  2 +-
include/hw/sparc/sparc32_dma.h |  6 ++----
hw/dma/sparc32_dma.c           |  8 ++++----
hw/net/pcnet-pci.c             |  5 +++--
hw/net/pcnet.c                 | 16 ++++++++--------
hw/scsi/esp-pci.c              |  6 +++---
7 files changed, 23 insertions(+), 24 deletions(-)

Expand all Fold all

[PATCH 0/3] hw: More dma_memory_read/write() API cleanup

Posted by Philippe Mathieu-Daudé 4 years, 1 month ago

Following up "global exec/memory/dma APIs cleanup"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html

Few more cleanups in PCNET & SCSI ESP devices.

Philippe Mathieu-Daudé (3):
  hw/dma/sparc32_dma: Make espdma_memory_[read/write] static
  hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and
    size_t
  hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean

 hw/net/pcnet.h                 |  4 ++--
 include/hw/scsi/esp.h          |  2 +-
 include/hw/sparc/sparc32_dma.h |  6 ++----
 hw/dma/sparc32_dma.c           |  8 ++++----
 hw/net/pcnet-pci.c             |  5 +++--
 hw/net/pcnet.c                 | 16 ++++++++--------
 hw/scsi/esp-pci.c              |  6 +++---
 7 files changed, 23 insertions(+), 24 deletions(-)

-- 
2.21.1

Re: [PATCH 0/3] hw: More dma_memory_read/write() API cleanup

Posted by Mark Cave-Ayland 4 years, 1 month ago

On 21/02/2020 13:25, Philippe Mathieu-Daudé wrote:

> Following up "global exec/memory/dma APIs cleanup"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html
> 
> Few more cleanups in PCNET & SCSI ESP devices.
> 
> Philippe Mathieu-Daudé (3):
>   hw/dma/sparc32_dma: Make espdma_memory_[read/write] static
>   hw/scsi/esp: Let ESPDMAMemoryReadWriteFunc take void pointer and
>     size_t
>   hw/net/pcnet: Let phys_mem_read/write take void pointer and boolean
> 
>  hw/net/pcnet.h                 |  4 ++--
>  include/hw/scsi/esp.h          |  2 +-
>  include/hw/sparc/sparc32_dma.h |  6 ++----
>  hw/dma/sparc32_dma.c           |  8 ++++----
>  hw/net/pcnet-pci.c             |  5 +++--
>  hw/net/pcnet.c                 | 16 ++++++++--------
>  hw/scsi/esp-pci.c              |  6 +++---
>  7 files changed, 23 insertions(+), 24 deletions(-)

LGTM.

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>


ATB,

Mark.

Re: [PATCH 0/3] hw: More dma_memory_read/write() API cleanup

Posted by Paolo Bonzini 4 years, 1 month ago

On 21/02/20 14:25, Philippe Mathieu-Daudé wrote:
> Following up "global exec/memory/dma APIs cleanup"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg681475.html
> 
> Few more cleanups in PCNET & SCSI ESP devices.

Can you send a pull request for everything?

Paolo