xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd

[PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd

Posted by Francisco Iglesias 5 years, 8 months ago

From: Francisco Iglesias <francisco.iglesias@xilinx.com>

Correct the number of dummy cycles required by the FAST_READ_4 command (to
be eight, one dummy byte).

Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
Suggested-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
---
 hw/ssi/xilinx_spips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
index 6c9ef59779..c57850a505 100644
--- a/hw/ssi/xilinx_spips.c
+++ b/hw/ssi/xilinx_spips.c
@@ -576,11 +576,11 @@ static int xilinx_spips_num_dummies(XilinxQSPIPS *qs, uint8_t command)
     case FAST_READ:
     case DOR:
     case QOR:
+    case FAST_READ_4:
     case DOR_4:
     case QOR_4:
         return 1;
     case DIOR:
-    case FAST_READ_4:
     case DIOR_4:
         return 2;
     case QIOR:
-- 
2.11.0

Re: [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd

Posted by Edgar E. Iglesias 5 years, 9 months ago

On Tue, Feb 18, 2020 at 12:33:50PM +0100, Francisco Iglesias wrote:
> From: Francisco Iglesias <francisco.iglesias@xilinx.com>
> 
> Correct the number of dummy cycles required by the FAST_READ_4 command (to
> be eight, one dummy byte).
> 
> Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
> Suggested-by: Cédric Le Goater <clg@kaod.org>
> Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> ---
>  hw/ssi/xilinx_spips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c
> index 6c9ef59779..c57850a505 100644
> --- a/hw/ssi/xilinx_spips.c
> +++ b/hw/ssi/xilinx_spips.c
> @@ -576,11 +576,11 @@ static int xilinx_spips_num_dummies(XilinxQSPIPS *qs, uint8_t command)
>      case FAST_READ:
>      case DOR:
>      case QOR:
> +    case FAST_READ_4:
>      case DOR_4:
>      case QOR_4:
>          return 1;
>      case DIOR:
> -    case FAST_READ_4:
>      case DIOR_4:
>          return 2;
>      case QIOR:
> -- 
> 2.11.0
>

Re: [PATCH] xilinx_spips: Correct the number of dummy cycles for the FAST_READ_4 cmd

Posted by Peter Maydell 5 years, 8 months ago

On Wed, 19 Feb 2020 at 01:12, Edgar E. Iglesias
<edgar.iglesias@xilinx.com> wrote:
>
> On Tue, Feb 18, 2020 at 12:33:50PM +0100, Francisco Iglesias wrote:
> > From: Francisco Iglesias <francisco.iglesias@xilinx.com>
> >
> > Correct the number of dummy cycles required by the FAST_READ_4 command (to
> > be eight, one dummy byte).
> >
> > Fixes: ef06ca3946 ("xilinx_spips: Add support for RX discard and RX drain")
> > Suggested-by: Cédric Le Goater <clg@kaod.org>
> > Signed-off-by: Francisco Iglesias <frasse.iglesias@gmail.com>
>
> Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



Applied to target-arm.next, thanks.

-- PMM