[v1] trivial: Detect and remove superfluous semicolons in C code

[PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Philippe Mathieu-Daudé posted 13 patches 5 years, 8 months ago

Diff against v1 v1
Download mbox

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Alistair Francis <alistair@alistair23.me>, Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>, Thomas Huth <huth@tuxfamily.org>, Aarushi Mehta <mehta.aaru20@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Yuval Shaia <yuval.shaia.ml@gmail.com>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Julia Suvorova <jusual@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Juan Quintela <quintela@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

Expand all Fold all

[PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

Fixes: 6663a0a3376
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Stefano Garzarella <sgarzare@redhat.com>
---
 block/io_uring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/io_uring.c b/block/io_uring.c
index 56892fd1ab..a3142ca989 100644
--- a/block/io_uring.c
+++ b/block/io_uring.c
@@ -187,7 +187,7 @@ static void luring_process_completions(LuringState *s)
                     ret = 0;
                 }
             } else {
-                ret = -ENOSPC;;
+                ret = -ENOSPC;
             }
         }
 end:
-- 
2.21.1

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Posted by Dr. David Alan Gilbert 5 years, 8 months ago

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Stefano Garzarella <sgarzare@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  block/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/io_uring.c b/block/io_uring.c
> index 56892fd1ab..a3142ca989 100644
> --- a/block/io_uring.c
> +++ b/block/io_uring.c
> @@ -187,7 +187,7 @@ static void luring_process_completions(LuringState *s)
>                      ret = 0;
>                  }
>              } else {
> -                ret = -ENOSPC;;
> +                ret = -ENOSPC;
>              }
>          }
>  end:
> -- 
> 2.21.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Posted by Stefano Garzarella 5 years, 8 months ago

On Tue, Feb 18, 2020 at 10:43:53AM +0100, Philippe Mathieu-Daudé wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: Stefano Garzarella <sgarzare@redhat.com>
> ---
>  block/io_uring.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Thanks,
Stefano

> 
> diff --git a/block/io_uring.c b/block/io_uring.c
> index 56892fd1ab..a3142ca989 100644
> --- a/block/io_uring.c
> +++ b/block/io_uring.c
> @@ -187,7 +187,7 @@ static void luring_process_completions(LuringState *s)
>                      ret = 0;
>                  }
>              } else {
> -                ret = -ENOSPC;;
> +                ret = -ENOSPC;
>              }
>          }
>  end:
> -- 
> 2.21.1
>

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Posted by Juan Quintela 5 years, 8 months ago

Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Re: [PATCH RESEND 04/13] block/io_uring: Remove superfluous semicolon

Posted by Kevin Wolf 5 years, 8 months ago

Am 18.02.2020 um 10:43 hat Philippe Mathieu-Daudé geschrieben:
> Fixes: 6663a0a3376
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, applied patches 3 and 4 to the block branch.

Kevin