[v1] trivial: Detect and remove superfluous semicolons in C code

[PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Philippe Mathieu-Daudé posted 13 patches 5 years, 8 months ago

Diff against v1 v1
Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200218094402.26625-1-philmd@redhat.com

Maintainers: Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Alistair Francis <alistair@alistair23.me>, Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>, Thomas Huth <huth@tuxfamily.org>, Aarushi Mehta <mehta.aaru20@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Yuval Shaia <yuval.shaia.ml@gmail.com>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Julia Suvorova <jusual@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Alex Williamson <alex.williamson@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Juan Quintela <quintela@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

audio/alsaaudio.c           | 4 ++--
block.c                     | 4 ++--
block/io_uring.c            | 2 +-
contrib/rdmacm-mux/main.c   | 2 +-
hw/arm/xlnx-versal-virt.c   | 2 +-
hw/m68k/next-cube.c         | 2 +-
hw/scsi/esp.c               | 2 +-
hw/vfio/display.c           | 2 +-
migration/multifd.c         | 2 +-
target/i386/whpx-all.c      | 2 +-
tests/qtest/libqos/qgraph.c | 4 ++--
ui/input-barrier.c          | 2 +-
scripts/checkpatch.pl       | 5 +++++
13 files changed, 20 insertions(+), 15 deletions(-)

Expand all Fold all

[PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Posted by Philippe Mathieu-Daudé 5 years, 8 months ago

Luc noticed a superfluous trailing semicolon:
https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html

Prevent that by modifying checkpatch.pl and clean the codebase.

Philippe Mathieu-Daudé (13):
  scripts/checkpatch.pl: Detect superfluous semicolon in C code
  audio/alsaaudio: Remove superfluous semicolons
  block: Remove superfluous semicolons
  block/io_uring: Remove superfluous semicolon
  hw/arm/xlnx-versal: Remove superfluous semicolon
  hw/m68k/next-cube: Remove superfluous semicolon
  hw/scsi/esp: Remove superfluous semicolon
  hw/vfio/display: Remove superfluous semicolon
  migration/multifd: Remove superfluous semicolon
  ui/input-barrier: Remove superfluous semicolon
  target/i386/whpx: Remove superfluous semicolon
  tests/qtest/libqos/qgraph: Remove superfluous semicolons
  contrib/rdmacm-mux: Remove superfluous semicolon

 audio/alsaaudio.c           | 4 ++--
 block.c                     | 4 ++--
 block/io_uring.c            | 2 +-
 contrib/rdmacm-mux/main.c   | 2 +-
 hw/arm/xlnx-versal-virt.c   | 2 +-
 hw/m68k/next-cube.c         | 2 +-
 hw/scsi/esp.c               | 2 +-
 hw/vfio/display.c           | 2 +-
 migration/multifd.c         | 2 +-
 target/i386/whpx-all.c      | 2 +-
 tests/qtest/libqos/qgraph.c | 4 ++--
 ui/input-barrier.c          | 2 +-
 scripts/checkpatch.pl       | 5 +++++
 13 files changed, 20 insertions(+), 15 deletions(-)

-- 
2.21.1

Re: [PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Posted by Paolo Bonzini 5 years, 8 months ago

On 18/02/20 10:43, Philippe Mathieu-Daudé wrote:
> Luc noticed a superfluous trailing semicolon:
> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
> 
> Prevent that by modifying checkpatch.pl and clean the codebase.
> 
> Philippe Mathieu-Daudé (13):
>   scripts/checkpatch.pl: Detect superfluous semicolon in C code
>   audio/alsaaudio: Remove superfluous semicolons
>   block: Remove superfluous semicolons
>   block/io_uring: Remove superfluous semicolon
>   hw/arm/xlnx-versal: Remove superfluous semicolon
>   hw/m68k/next-cube: Remove superfluous semicolon
>   hw/scsi/esp: Remove superfluous semicolon
>   hw/vfio/display: Remove superfluous semicolon
>   migration/multifd: Remove superfluous semicolon
>   ui/input-barrier: Remove superfluous semicolon
>   target/i386/whpx: Remove superfluous semicolon
>   tests/qtest/libqos/qgraph: Remove superfluous semicolons
>   contrib/rdmacm-mux: Remove superfluous semicolon
> 
>  audio/alsaaudio.c           | 4 ++--
>  block.c                     | 4 ++--
>  block/io_uring.c            | 2 +-
>  contrib/rdmacm-mux/main.c   | 2 +-
>  hw/arm/xlnx-versal-virt.c   | 2 +-
>  hw/m68k/next-cube.c         | 2 +-
>  hw/scsi/esp.c               | 2 +-
>  hw/vfio/display.c           | 2 +-
>  migration/multifd.c         | 2 +-
>  target/i386/whpx-all.c      | 2 +-
>  tests/qtest/libqos/qgraph.c | 4 ++--
>  ui/input-barrier.c          | 2 +-
>  scripts/checkpatch.pl       | 5 +++++
>  13 files changed, 20 insertions(+), 15 deletions(-)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Laurent, can you queue this in qemu-trivial?

Re: [PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Posted by Laurent Vivier 5 years, 8 months ago

Le 18/02/2020 à 18:04, Paolo Bonzini a écrit :
> On 18/02/20 10:43, Philippe Mathieu-Daudé wrote:
>> Luc noticed a superfluous trailing semicolon:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
>>
>> Prevent that by modifying checkpatch.pl and clean the codebase.
>>
>> Philippe Mathieu-Daudé (13):
>>   scripts/checkpatch.pl: Detect superfluous semicolon in C code
>>   audio/alsaaudio: Remove superfluous semicolons
>>   block: Remove superfluous semicolons
>>   block/io_uring: Remove superfluous semicolon
>>   hw/arm/xlnx-versal: Remove superfluous semicolon
>>   hw/m68k/next-cube: Remove superfluous semicolon
>>   hw/scsi/esp: Remove superfluous semicolon
>>   hw/vfio/display: Remove superfluous semicolon
>>   migration/multifd: Remove superfluous semicolon
>>   ui/input-barrier: Remove superfluous semicolon
>>   target/i386/whpx: Remove superfluous semicolon
>>   tests/qtest/libqos/qgraph: Remove superfluous semicolons
>>   contrib/rdmacm-mux: Remove superfluous semicolon
>>
>>  audio/alsaaudio.c           | 4 ++--
>>  block.c                     | 4 ++--
>>  block/io_uring.c            | 2 +-
>>  contrib/rdmacm-mux/main.c   | 2 +-
>>  hw/arm/xlnx-versal-virt.c   | 2 +-
>>  hw/m68k/next-cube.c         | 2 +-
>>  hw/scsi/esp.c               | 2 +-
>>  hw/vfio/display.c           | 2 +-
>>  migration/multifd.c         | 2 +-
>>  target/i386/whpx-all.c      | 2 +-
>>  tests/qtest/libqos/qgraph.c | 4 ++--
>>  ui/input-barrier.c          | 2 +-
>>  scripts/checkpatch.pl       | 5 +++++
>>  13 files changed, 20 insertions(+), 15 deletions(-)
>>
> 
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Laurent, can you queue this in qemu-trivial?
> 

Queued, except patches 3, 4 (taken by Kevin) and 9 (by Juan)

Thanks,
Laurent

Re: [PATCH RESEND 00/13] trivial: Detect and remove superfluous semicolons in C code

Posted by Laurent Vivier 5 years, 8 months ago

On 18/02/2020 18:04, Paolo Bonzini wrote:
> On 18/02/20 10:43, Philippe Mathieu-Daudé wrote:
>> Luc noticed a superfluous trailing semicolon:
>> https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg04593.html
>>
>> Prevent that by modifying checkpatch.pl and clean the codebase.
>>
>> Philippe Mathieu-Daudé (13):
>>   scripts/checkpatch.pl: Detect superfluous semicolon in C code
>>   audio/alsaaudio: Remove superfluous semicolons
>>   block: Remove superfluous semicolons
>>   block/io_uring: Remove superfluous semicolon
>>   hw/arm/xlnx-versal: Remove superfluous semicolon
>>   hw/m68k/next-cube: Remove superfluous semicolon
>>   hw/scsi/esp: Remove superfluous semicolon
>>   hw/vfio/display: Remove superfluous semicolon
>>   migration/multifd: Remove superfluous semicolon
>>   ui/input-barrier: Remove superfluous semicolon
>>   target/i386/whpx: Remove superfluous semicolon
>>   tests/qtest/libqos/qgraph: Remove superfluous semicolons
>>   contrib/rdmacm-mux: Remove superfluous semicolon
>>
>>  audio/alsaaudio.c           | 4 ++--
>>  block.c                     | 4 ++--
>>  block/io_uring.c            | 2 +-
>>  contrib/rdmacm-mux/main.c   | 2 +-
>>  hw/arm/xlnx-versal-virt.c   | 2 +-
>>  hw/m68k/next-cube.c         | 2 +-
>>  hw/scsi/esp.c               | 2 +-
>>  hw/vfio/display.c           | 2 +-
>>  migration/multifd.c         | 2 +-
>>  target/i386/whpx-all.c      | 2 +-
>>  tests/qtest/libqos/qgraph.c | 4 ++--
>>  ui/input-barrier.c          | 2 +-
>>  scripts/checkpatch.pl       | 5 +++++
>>  13 files changed, 20 insertions(+), 15 deletions(-)
>>
> 
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Laurent, can you queue this in qemu-trivial?
> 
Yes, I will.

Thanks,
Laurent