[PATCH v2 13/22] qemu-iotests/199: drop extra constraints

Vladimir Sementsov-Ogievskiy posted 22 patches 5 years, 11 months ago
There is a newer version of this series
[PATCH v2 13/22] qemu-iotests/199: drop extra constraints
Posted by Vladimir Sementsov-Ogievskiy 5 years, 11 months ago
We don't need any specific format constraints here. Still keep qcow2
for two reasons:
1. No extra calls of format-unrelated test
2. Add some check around persistent bitmap in future (require qcow2)

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 tests/qemu-iotests/199 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/199
index de9ba8d94c..dda918450a 100755
--- a/tests/qemu-iotests/199
+++ b/tests/qemu-iotests/199
@@ -116,5 +116,4 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
 
 
 if __name__ == '__main__':
-    iotests.main(supported_fmts=['qcow2'], supported_cache_modes=['none'],
-                 supported_protocols=['file'])
+    iotests.main(supported_fmts=['qcow2'])
-- 
2.21.0


Re: [PATCH v2 13/22] qemu-iotests/199: drop extra constraints
Posted by Andrey Shinkevich 5 years, 11 months ago

On 17/02/2020 18:02, Vladimir Sementsov-Ogievskiy wrote:
> We don't need any specific format constraints here. Still keep qcow2
> for two reasons:
> 1. No extra calls of format-unrelated test
> 2. Add some check around persistent bitmap in future (require qcow2)
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>   tests/qemu-iotests/199 | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/199 b/tests/qemu-iotests/199
> index de9ba8d94c..dda918450a 100755
> --- a/tests/qemu-iotests/199
> +++ b/tests/qemu-iotests/199
> @@ -116,5 +116,4 @@ class TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
>   
>   
>   if __name__ == '__main__':
> -    iotests.main(supported_fmts=['qcow2'], supported_cache_modes=['none'],
> -                 supported_protocols=['file'])
> +    iotests.main(supported_fmts=['qcow2'])
> 

Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
-- 
With the best regards,
Andrey Shinkevich