[v2] configure: Avoid compiling system tools on user build by default

[PATCH v2] configure: Avoid compiling system tools on user build by default

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

From: Philippe Mathieu-Daudé <f4bug@amsat.org>

User-mode does not need the sytem tools. Do not build them by
default if user specified --disable-system.

This disables building the following binary on a user-only build:

- elf2dmp
- qemu-edid
- qemu-ga
- qemu-img
- qemu-io
- qemu-nbd
- ivshmem-client
- ivshmem-server

The qemu-user binary is not affected by this change.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
v2:
- use simpler if/else statement (therefore not adding Richard R-b)
- improved description (Aleksandar)
---
 configure | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 16f94cd96b..d1877a60f5 100755
--- a/configure
+++ b/configure
@@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
 guest_agent_msi=""
 vss_win32_sdk=""
 win_sdk="no"
-want_tools="yes"
+want_tools=""
 libiscsi=""
 libnfs=""
 coroutine=""
@@ -2199,6 +2199,16 @@ else
     echo big/little test failed
 fi
 
+##########################################
+# system tools
+if test -z "$want_tools"; then
+    if test "$softmmu" = "no"; then
+        want_tools=no
+    else
+        want_tools=yes
+    fi
+fi
+
 ##########################################
 # cocoa implies not SDL or GTK
 # (the cocoa UI code currently assumes it is always the active UI
-- 
2.21.1

Re: [PATCH v2] configure: Avoid compiling system tools on user build by default

Posted by Laurent Vivier 5 years, 9 months ago

Le 17/02/2020 à 10:59, Philippe Mathieu-Daudé a écrit :
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> User-mode does not need the sytem tools. Do not build them by
> default if user specified --disable-system.
> 
> This disables building the following binary on a user-only build:
> 
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
> 
> The qemu-user binary is not affected by this change.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
>  configure | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 16f94cd96b..d1877a60f5 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
>  guest_agent_msi=""
>  vss_win32_sdk=""
>  win_sdk="no"
> -want_tools="yes"
> +want_tools=""
>  libiscsi=""
>  libnfs=""
>  coroutine=""
> @@ -2199,6 +2199,16 @@ else
>      echo big/little test failed
>  fi
>  
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> +    if test "$softmmu" = "no"; then
> +        want_tools=no
> +    else
> +        want_tools=yes
> +    fi
> +fi
> +
>  ##########################################
>  # cocoa implies not SDL or GTK
>  # (the cocoa UI code currently assumes it is always the active UI
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH v2] configure: Avoid compiling system tools on user build by default

Posted by Aleksandar Markovic 5 years, 9 months ago

11:00 AM Pon, 17.02.2020. Philippe Mathieu-Daudé <philmd@redhat.com> је
написао/ла:
>
> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> User-mode does not need the sytem tools.

system

> Do not build them by
> default if user specified --disable-system.

specifies

>
> This disables building the following binary on a user-only build:

binaries

>
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
>
> The qemu-user binary is not affected by this change.

binaries are

>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
>  configure | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 16f94cd96b..d1877a60f5 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
>  guest_agent_msi=""
>  vss_win32_sdk=""
>  win_sdk="no"
> -want_tools="yes"
> +want_tools=""
>  libiscsi=""
>  libnfs=""
>  coroutine=""
> @@ -2199,6 +2199,16 @@ else
>      echo big/little test failed
>  fi
>
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> +    if test "$softmmu" = "no"; then
> +        want_tools=no
> +    else
> +        want_tools=yes
> +    fi
> +fi
> +
>  ##########################################
>  # cocoa implies not SDL or GTK
>  # (the cocoa UI code currently assumes it is always the active UI
> --
> 2.21.1
>