Fix warning reported by Clang static code analyzer:

    CC      tools/virtiofsd/passthrough_ll.o
  tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read
      saverr = ENOMEM;
      ^        ~~~~~~

Fixes: 7c6b66027
Reported-by: Clang Static Analyzer
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tools/virtiofsd/passthrough_ll.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
index c635fc8820..e9e71d5fc2 100644
--- a/tools/virtiofsd/passthrough_ll.c
+++ b/tools/virtiofsd/passthrough_ll.c
@@ -1080,8 +1080,6 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t parent,
         return;
     }
 
-    saverr = ENOMEM;
-
     saverr = lo_change_cred(req, &old);
     if (saverr) {
         goto out;
-- 
2.21.1

* Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
> Fix warning reported by Clang static code analyzer:
> 
>     CC      tools/virtiofsd/passthrough_ll.o
>   tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read
>       saverr = ENOMEM;
>       ^        ~~~~~~
> 
> Fixes: 7c6b66027
> Reported-by: Clang Static Analyzer
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Thanks, you might want to snd that to the upstream libfuse
(different context); it looks like it's the same there.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Dave

> ---
>  tools/virtiofsd/passthrough_ll.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c
> index c635fc8820..e9e71d5fc2 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -1080,8 +1080,6 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t parent,
>          return;
>      }
>  
> -    saverr = ENOMEM;
> -
>      saverr = lo_change_cred(req, &old);
>      if (saverr) {
>          goto out;
> -- 
> 2.21.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

On 2/17/20 12:37 PM, Dr. David Alan Gilbert wrote:
> * Philippe Mathieu-Daudé (philmd@redhat.com) wrote:
>> Fix warning reported by Clang static code analyzer:
>>
>>      CC      tools/virtiofsd/passthrough_ll.o
>>    tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' is never read
>>        saverr = ENOMEM;
>>        ^        ~~~~~~
>>
>> Fixes: 7c6b66027
>> Reported-by: Clang Static Analyzer
>> Reviewed-by: Ján Tomko <jtomko@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> Thanks, you might want to snd that to the upstream libfuse
> (different context); it looks like it's the same there.

Done: https://github.com/libfuse/libfuse/pull/501

> 
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

Thanks!