[PATCH v2 00/19] testing and plugin updates

Alex Bennée posted 19 patches 3 days ago
Test docker-quick@centos7 passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200213225109.13120-1-alex.bennee@linaro.org
Maintainers: Cornelia Huck <cohuck@redhat.com>
docs/devel/tcg-plugins.rst                | 13 +++++-
include/qemu/bitops.h                     | 38 ++++++++++++++++
target/riscv/instmap.h                    |  8 ++--
plugins/core.c                            |  1 +
target/riscv/translate.c                  | 40 +++++++++--------
tcg/tcg-op.c                              | 23 ++++++++--
tests/plugin/bb.c                         |  6 +--
tests/plugin/howvec.c                     | 26 +++++++----
tests/plugin/insn.c                       |  3 +-
tests/rcutorture.c                        | 55 +++++++++++++++++------
tests/tcg/aarch64/pauth-4.c               | 54 +++++++++++++++-------
trace/control.c                           | 11 +++--
.travis.yml                               | 23 +++++++---
tests/qemu-iotests/214                    |  4 +-
tests/tcg/Makefile.target                 |  4 +-
tests/tcg/aarch64/Makefile.softmmu-target |  2 +
tests/tcg/configure.sh                    |  2 +-
17 files changed, 225 insertions(+), 88 deletions(-)

[PATCH v2 00/19] testing and plugin updates

Posted by Alex Bennée 3 days ago
Hi,

I've ended up combining my accumulated testing fixes with the plugin
fixes as there is some cross-over between the two. On the testing side
I still haven't seen rcutorture trip up on my branches but the final
patch that light re-factors it needs to be reviewed. I've also added
some fixes for pauth - both ensuring they compiler and tweaking
pauth-4 to take into account the occasional authentication clashes.

Plugin wise I have cleaned up the riscv parser to use extract16 where
appropriate. We also managed to diagnose a bug in the address passing
of the memory instrumentation which only showed up under alpha. The
relevant patches have been Cc'ed to qemu-stable.

The following patches need review:

  tests/tcg: take into account expected clashes pauth-4
  tests/tcg: fix typo in configure.sh test for v8.3
  tcg: save vaddr temp for plugin usage
  tests/tcg: give debug builds a little bit longer
  tracing: only allow -trace to override -D if set
  tests/iotests: be a little more forgiving on the size test
  travis.yml: single-thread build-tcg stages
  travis.yml: Fix Travis YAML configuration warnings
  tests/rcutorture: mild documenting refactor of update thread
  tests/tcg: include a skip runner for pauth3 with plugins

Alex Bennée (13):
  tests/tcg: include a skip runner for pauth3 with plugins
  tests/rcutorture: update usage hint
  tests/rcutorture: better document locking of stats
  tests/rcutorture: mild documenting refactor of update thread
  travis.yml: single-thread build-tcg stages
  tests/iotests: be a little more forgiving on the size test
  tracing: only allow -trace to override -D if set
  docs/devel: document query handle lifetimes
  target/riscv: progressively load the instruction during decode
  tests/plugins: make howvec clean-up after itself.
  tests/tcg: give debug builds a little bit longer
  tests/tcg: fix typo in configure.sh test for v8.3
  tests/tcg: take into account expected clashes pauth-4

Chen Qun (1):
  tests/plugin: prevent uninitialized warning

Emilio G. Cota (1):
  plugins/core: add missing break in cb_to_tcg_flags

Richard Henderson (1):
  tcg: save vaddr temp for plugin usage

Thomas Huth (1):
  travis.yml: Test the s390-ccw build, too

Wainer dos Santos Moschetta (1):
  travis.yml: Fix Travis YAML configuration warnings

Yoshinori Sato (1):
  qemu/bitops.h: Add extract8 and extract16

 docs/devel/tcg-plugins.rst                | 13 +++++-
 include/qemu/bitops.h                     | 38 ++++++++++++++++
 target/riscv/instmap.h                    |  8 ++--
 plugins/core.c                            |  1 +
 target/riscv/translate.c                  | 40 +++++++++--------
 tcg/tcg-op.c                              | 23 ++++++++--
 tests/plugin/bb.c                         |  6 +--
 tests/plugin/howvec.c                     | 26 +++++++----
 tests/plugin/insn.c                       |  3 +-
 tests/rcutorture.c                        | 55 +++++++++++++++++------
 tests/tcg/aarch64/pauth-4.c               | 54 +++++++++++++++-------
 trace/control.c                           | 11 +++--
 .travis.yml                               | 23 +++++++---
 tests/qemu-iotests/214                    |  4 +-
 tests/tcg/Makefile.target                 |  4 +-
 tests/tcg/aarch64/Makefile.softmmu-target |  2 +
 tests/tcg/configure.sh                    |  2 +-
 17 files changed, 225 insertions(+), 88 deletions(-)

-- 
2.20.1


Re: [PATCH v2 00/19] testing and plugin updates

Posted by no-reply@patchew.org 3 days ago
Patchew URL: https://patchew.org/QEMU/20200213225109.13120-1-alex.bennee@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH  v2 00/19] testing and plugin updates
Message-id: 20200213225109.13120-1-alex.bennee@linaro.org
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20200213225109.13120-1-alex.bennee@linaro.org -> patchew/20200213225109.13120-1-alex.bennee@linaro.org
Switched to a new branch 'test'
3109a26 tests/tcg: take into account expected clashes pauth-4
bd088da tests/tcg: fix typo in configure.sh test for v8.3
45e0661 tcg: save vaddr temp for plugin usage
465e545 tests/tcg: give debug builds a little bit longer
1dc357e tests/plugins: make howvec clean-up after itself.
fcb8562 target/riscv: progressively load the instruction during decode
2e6734c qemu/bitops.h: Add extract8 and extract16
21ff7e3 tests/plugin: prevent uninitialized warning
81f2039 plugins/core: add missing break in cb_to_tcg_flags
80651cf docs/devel: document query handle lifetimes
9dc3d6d tracing: only allow -trace to override -D if set
eb2e0ad tests/iotests: be a little more forgiving on the size test
4d90ee2 travis.yml: single-thread build-tcg stages
3425df2 travis.yml: Fix Travis YAML configuration warnings
49b5310 travis.yml: Test the s390-ccw build, too
4ef30b9 tests/rcutorture: mild documenting refactor of update thread
23905a1 tests/rcutorture: better document locking of stats
c3a20fc tests/rcutorture: update usage hint
e31233b tests/tcg: include a skip runner for pauth3 with plugins

=== OUTPUT BEGIN ===
1/19 Checking commit e31233ba5677 (tests/tcg: include a skip runner for pauth3 with plugins)
2/19 Checking commit c3a20fc36238 (tests/rcutorture: update usage hint)
3/19 Checking commit 23905a1b8851 (tests/rcutorture: better document locking of stats)
4/19 Checking commit 4ef30b9250b9 (tests/rcutorture: mild documenting refactor of update thread)
5/19 Checking commit 49b53100439e (travis.yml: Test the s390-ccw build, too)
6/19 Checking commit 3425df244fcd (travis.yml: Fix Travis YAML configuration warnings)
7/19 Checking commit 4d90ee26396b (travis.yml: single-thread build-tcg stages)
8/19 Checking commit eb2e0addbf96 (tests/iotests: be a little more forgiving on the size test)
9/19 Checking commit 9dc3d6d877be (tracing: only allow -trace to override -D if set)
10/19 Checking commit 80651cf4dd6a (docs/devel: document query handle lifetimes)
11/19 Checking commit 81f203940a48 (plugins/core: add missing break in cb_to_tcg_flags)
12/19 Checking commit 21ff7e396207 (tests/plugin: prevent uninitialized warning)
13/19 Checking commit 2e6734c5b2b1 (qemu/bitops.h: Add extract8 and extract16)
14/19 Checking commit fcb85625f96a (target/riscv: progressively load the instruction during decode)
15/19 Checking commit 1dc357e99457 (tests/plugins: make howvec clean-up after itself.)
16/19 Checking commit 465e5454070a (tests/tcg: give debug builds a little bit longer)
17/19 Checking commit 45e066189d4e (tcg: save vaddr temp for plugin usage)
18/19 Checking commit bd088dac07cc (tests/tcg: fix typo in configure.sh test for v8.3)
19/19 Checking commit 3109a268d5ae (tests/tcg: take into account expected clashes pauth-4)
WARNING: Block comments use a leading /* on a separate line
#60: FILE: tests/tcg/aarch64/pauth-4.c:25:
+            : /* out */ "=r"(x), "=r"(y)

WARNING: Block comments use a leading /* on a separate line
#61: FILE: tests/tcg/aarch64/pauth-4.c:26:
+            : /* in */ [in] "r" (in)

ERROR: space prohibited before open square bracket '['
#61: FILE: tests/tcg/aarch64/pauth-4.c:26:
+            : /* in */ [in] "r" (in)

WARNING: Block comments use a leading /* on a separate line
#62: FILE: tests/tcg/aarch64/pauth-4.c:27:
+            : /* clobbers */);

total: 1 errors, 3 warnings, 62 lines checked

Patch 19/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200213225109.13120-1-alex.bennee@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com