[v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

[PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

The www.helenos.org server is slow and downloading the Leon3 binary
takes too long [*]. Do not include this test in the default suite.

Similarly to commit 471c97a69b:

  Currently the Avocado framework does not distinct the time spent
  downloading assets vs. the time spent running a test. With big
  assets (like a full VM image) the tests likely fail.

  This is a limitation known by the Avocado team.
  Until this issue get fixed, do not run this tests automatically.

  Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
  environment variable.

[*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198

Reported-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Add missing staged hunk...
---
 tests/acceptance/machine_sparc_leon3.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
index f77e210ccb..27e4717a51 100644
--- a/tests/acceptance/machine_sparc_leon3.py
+++ b/tests/acceptance/machine_sparc_leon3.py
@@ -5,6 +5,9 @@
 # This work is licensed under the terms of the GNU GPL, version 2 or
 # later. See the COPYING file in the top-level directory.
 
+import os
+
+from avocado import skipUnless
 from avocado_qemu import Test
 from avocado_qemu import wait_for_console_pattern
 
@@ -13,6 +16,7 @@ class Leon3Machine(Test):
 
     timeout = 60
 
+    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
     def test_leon3_helenos_uimage(self):
         """
         :avocado: tags=arch:sparc
-- 
2.21.1

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

Posted by Wainer dos Santos Moschetta 5 years, 9 months ago

On 2/12/20 6:36 PM, Philippe Mathieu-Daudé wrote:
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
>
> Similarly to commit 471c97a69b:
>
>    Currently the Avocado framework does not distinct the time spent
>    downloading assets vs. the time spent running a test. With big
>    assets (like a full VM image) the tests likely fail.
>
>    This is a limitation known by the Avocado team.
>    Until this issue get fixed, do not run this tests automatically.
>
>    Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
>    environment variable.
>
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
>   tests/acceptance/machine_sparc_leon3.py | 4 ++++
>   1 file changed, 4 insertions(+)

LGTM.

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>


>
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
>   # This work is licensed under the terms of the GNU GPL, version 2 or
>   # later. See the COPYING file in the top-level directory.
>   
> +import os
> +
> +from avocado import skipUnless
>   from avocado_qemu import Test
>   from avocado_qemu import wait_for_console_pattern
>   
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>   
>       timeout = 60
>   
> +    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>       def test_leon3_helenos_uimage(self):
>           """
>           :avocado: tags=arch:sparc

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

Posted by KONRAD Frederic 5 years, 9 months ago


Le 2/12/20 à 9:36 PM, Philippe Mathieu-Daudé a écrit :
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
> 
> Similarly to commit 471c97a69b:
> 
>    Currently the Avocado framework does not distinct the time spent
>    downloading assets vs. the time spent running a test. With big
>    assets (like a full VM image) the tests likely fail.
> 
>    This is a limitation known by the Avocado team.
>    Until this issue get fixed, do not run this tests automatically.
> 
>    Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
>    environment variable.
> 
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
> 
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
>   tests/acceptance/machine_sparc_leon3.py | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
>   # This work is licensed under the terms of the GNU GPL, version 2 or
>   # later. See the COPYING file in the top-level directory.
>   
> +import os
> +
> +from avocado import skipUnless
>   from avocado_qemu import Test
>   from avocado_qemu import wait_for_console_pattern
>   
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>   
>       timeout = 60
>   
> +    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>       def test_leon3_helenos_uimage(self):
>           """
>           :avocado: tags=arch:sparc
> 

Reviewed-by: KONRAD Frederic <frederic.konrad@adacore.com>

Thanks Philippe!

Re: [PATCH v2] tests/acceptance/machine_sparc_leon3: Do not run HelenOS test by default

Posted by Philippe Mathieu-Daudé 5 years, 7 months ago

I just noticed I forgot to Cc Eduardo when posting this :S

Eduardo, do you want me to prepare a pullreq for rc1 with this patch and 
Oksana other fix?

On 2/12/20 9:36 PM, Philippe Mathieu-Daudé wrote:
> The www.helenos.org server is slow and downloading the Leon3 binary
> takes too long [*]. Do not include this test in the default suite.
> 
> Similarly to commit 471c97a69b:
> 
>    Currently the Avocado framework does not distinct the time spent
>    downloading assets vs. the time spent running a test. With big
>    assets (like a full VM image) the tests likely fail.
> 
>    This is a limitation known by the Avocado team.
>    Until this issue get fixed, do not run this tests automatically.
> 
>    Tests can still be run setting the AVOCADO_TIMEOUT_EXPECTED
>    environment variable.
> 
> [*] https://travis-ci.org/stsquad/qemu/jobs/649599880#L4198
> 
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Add missing staged hunk...
> ---
>   tests/acceptance/machine_sparc_leon3.py | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/acceptance/machine_sparc_leon3.py b/tests/acceptance/machine_sparc_leon3.py
> index f77e210ccb..27e4717a51 100644
> --- a/tests/acceptance/machine_sparc_leon3.py
> +++ b/tests/acceptance/machine_sparc_leon3.py
> @@ -5,6 +5,9 @@
>   # This work is licensed under the terms of the GNU GPL, version 2 or
>   # later. See the COPYING file in the top-level directory.
>   
> +import os
> +
> +from avocado import skipUnless
>   from avocado_qemu import Test
>   from avocado_qemu import wait_for_console_pattern
>   
> @@ -13,6 +16,7 @@ class Leon3Machine(Test):
>   
>       timeout = 60
>   
> +    @skipUnless(os.getenv('AVOCADO_TIMEOUT_EXPECTED'), 'Test might timeout')
>       def test_leon3_helenos_uimage(self):
>           """
>           :avocado: tags=arch:sparc
>