Improve virtio_check_params test

[PATCH v1 0/2] Improve virtio_check_params test

Posted by Denis Plotnikov 5 years, 9 months ago

* fixed failing on non-existed machine type removal
* the test refactored to add more parameters to check

Gereral questions left:
   How to restric test for using:
   1. on a set of target OS-es
   2. on a set target architectures
  

Denis Plotnikov (2):
  tests/acceptance/virtio_check_params: remove excluded machine types
    carefully
  tests/acceptance/virtio_check_params: prepare to check different
    params

 tests/acceptance/virtio_check_params.py | 52 ++++++++++++++++---------
 1 file changed, 33 insertions(+), 19 deletions(-)

-- 
2.17.0

Re: [PATCH v1 0/2] Improve virtio_check_params test

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

Hi Denis,

On 2/11/20 3:25 PM, Denis Plotnikov wrote:
> * fixed failing on non-existed machine type removal
> * the test refactored to add more parameters to check
> 
> Gereral questions left:
>     How to restric test for using:
>     1. on a set of target OS-es
>     2. on a set target architectures
>    
> 
> Denis Plotnikov (2):
>    tests/acceptance/virtio_check_params: remove excluded machine types
>      carefully
>    tests/acceptance/virtio_check_params: prepare to check different
>      params
> 
>   tests/acceptance/virtio_check_params.py | 52 ++++++++++++++++---------
>   1 file changed, 33 insertions(+), 19 deletions(-)
> 

Have you noticed my other series suggested by Cornelia?

It runs your test on S390X and PPC:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675092.html
https://www.mail-archive.com/qemu-devel@nongnu.org/msg675095.html

Re: [PATCH v1 0/2] Improve virtio_check_params test

Posted by Denis Plotnikov 5 years, 9 months ago


On 11.02.2020 17:37, Philippe Mathieu-Daudé wrote:
> Hi Denis,
>
> On 2/11/20 3:25 PM, Denis Plotnikov wrote:
>> * fixed failing on non-existed machine type removal
>> * the test refactored to add more parameters to check
>>
>> Gereral questions left:
>>     How to restric test for using:
>>     1. on a set of target OS-es
>>     2. on a set target architectures
>>
>> Denis Plotnikov (2):
>>    tests/acceptance/virtio_check_params: remove excluded machine types
>>      carefully
>>    tests/acceptance/virtio_check_params: prepare to check different
>>      params
>>
>>   tests/acceptance/virtio_check_params.py | 52 ++++++++++++++++---------
>>   1 file changed, 33 insertions(+), 19 deletions(-)
>>
>
> Have you noticed my other series suggested by Cornelia?
>
> It runs your test on S390X and PPC:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675092.html
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg675095.html
>
> Hi, Philippe
Seems that I've missed them. I just made patches upon the fresh master.
Can I get a git tree which has those patches applied? Or should I wait 
while the patches landed to qemu master and the rebase on them?

Denis