[v4] Make MachineClass::is_default boolean, refuse multiple default machines

[PATCH v4 0/3] Make MachineClass::is_default boolean, refuse multiple default machines

Philippe Mathieu-Daudé posted 3 patches 5 years, 9 months ago

Diff against v3
Download series mbox

Test docker-quick@centos7 passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200207161948.15972-1-philmd@redhat.com

Maintainers: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Chris Wulff <crwulff@gmail.com>, Alistair Francis <Alistair.Francis@wdc.com>, Marek Vasut <marex@denx.de>, Anthony Green <green@moxielogic.com>, David Hildenbrand <david@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Magnus Damm <magnus.damm@gmail.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Laurent Vivier <laurent@vivier.eu>, Helge Deller <deller@gmx.de>, Stafford Horne <shorne@gmail.com>, "Philippe Mathieu-Daudé" <philmd@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Michael Walle <michael@walle.cc>, Christian Borntraeger <borntraeger@de.ibm.com>, Sagar Karandikar <sagark@eecs.berkeley.edu>, Thomas Huth <huth@tuxfamily.org>, Aurelien Jarno <aurelien@aurel32.net>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, "Michael S. Tsirkin" <mst@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Artyom Tarasenko <atar4qemu@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Jia Liu <proljc@gmail.com>

include/hw/boards.h                      |  4 +++-
hw/alpha/dp264.c                         |  2 +-
hw/cris/axis_dev88.c                     |  2 +-
hw/hppa/machine.c                        |  2 +-
hw/i386/pc_piix.c                        | 10 +++++-----
hw/lm32/lm32_boards.c                    |  3 +--
hw/lm32/milkymist.c                      |  1 -
hw/m68k/mcf5208.c                        |  2 +-
hw/m68k/q800.c                           |  1 -
hw/microblaze/petalogix_ml605_mmu.c      |  1 -
hw/microblaze/petalogix_s3adsp1800_mmu.c |  2 +-
hw/mips/mips_malta.c                     |  2 +-
hw/moxie/moxiesim.c                      |  2 +-
hw/nios2/10m50_devboard.c                |  2 +-
hw/openrisc/openrisc_sim.c               |  2 +-
hw/ppc/mac_oldworld.c                    |  2 +-
hw/ppc/spapr.c                           |  2 +-
hw/riscv/spike.c                         |  2 +-
hw/s390x/s390-virtio-ccw.c               |  2 +-
hw/sh4/shix.c                            |  2 +-
hw/sparc/sun4m.c                         |  2 +-
hw/sparc64/sun4u.c                       |  2 +-
hw/tricore/tricore_testboard.c           |  1 -
hw/unicore32/puv3.c                      |  2 +-
vl.c                                     |  6 ++++--
25 files changed, 30 insertions(+), 31 deletions(-)

Expand all Fold all

[PATCH v4 0/3] Make MachineClass::is_default boolean, refuse multiple default machines

Posted by Philippe Mathieu-Daudé 5 years, 9 months ago

Cleanup after reviewing "ppc: function to setup latest class options":
https://www.mail-archive.com/qemu-devel@nongnu.org/msg677709.html

Since v3:
- addressed Laurent & Michael comments

Philippe Mathieu-Daudé (3):
  hw: Do not initialize MachineClass::is_default to 0
  hw: Make MachineClass::is_default a boolean type
  vl: Abort if multiple machines are registered as default

 include/hw/boards.h                      |  4 +++-
 hw/alpha/dp264.c                         |  2 +-
 hw/cris/axis_dev88.c                     |  2 +-
 hw/hppa/machine.c                        |  2 +-
 hw/i386/pc_piix.c                        | 10 +++++-----
 hw/lm32/lm32_boards.c                    |  3 +--
 hw/lm32/milkymist.c                      |  1 -
 hw/m68k/mcf5208.c                        |  2 +-
 hw/m68k/q800.c                           |  1 -
 hw/microblaze/petalogix_ml605_mmu.c      |  1 -
 hw/microblaze/petalogix_s3adsp1800_mmu.c |  2 +-
 hw/mips/mips_malta.c                     |  2 +-
 hw/moxie/moxiesim.c                      |  2 +-
 hw/nios2/10m50_devboard.c                |  2 +-
 hw/openrisc/openrisc_sim.c               |  2 +-
 hw/ppc/mac_oldworld.c                    |  2 +-
 hw/ppc/spapr.c                           |  2 +-
 hw/riscv/spike.c                         |  2 +-
 hw/s390x/s390-virtio-ccw.c               |  2 +-
 hw/sh4/shix.c                            |  2 +-
 hw/sparc/sun4m.c                         |  2 +-
 hw/sparc64/sun4u.c                       |  2 +-
 hw/tricore/tricore_testboard.c           |  1 -
 hw/unicore32/puv3.c                      |  2 +-
 vl.c                                     |  6 ++++--
 25 files changed, 30 insertions(+), 31 deletions(-)

-- 
2.21.1

Re: [PATCH v4 0/3] Make MachineClass::is_default boolean, refuse multiple default machines

Posted by Eduardo Habkost 5 years, 9 months ago

On Fri, Feb 07, 2020 at 05:19:45PM +0100, Philippe Mathieu-Daudé wrote:
> Cleanup after reviewing "ppc: function to setup latest class options":
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg677709.html
> 
> Since v3:
> - addressed Laurent & Michael comments

Queued, thanks!

-- 
Eduardo