[PATCH] aspeed/i2c:fix uninitialized variable warning

kuhn.chenqun@huawei.com posted 1 patch 4 years, 3 months ago
Test docker-quick@centos7 passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200206040753.42252-1-kuhn.chenqun@huawei.com
Maintainers: Andrew Jeffery <andrew@aj.id.au>, Peter Maydell <peter.maydell@linaro.org>, "Cédric Le Goater" <clg@kaod.org>, Joel Stanley <joel@jms.id.au>
hw/i2c/aspeed_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] aspeed/i2c:fix uninitialized variable warning
Posted by kuhn.chenqun@huawei.com 4 years, 3 months ago
From: Chen Qun <kuhn.chenqun@huawei.com>

Fix warning:
hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’:
glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be
used uninitialized in this function [-Wmaybe-uninitialized]
   g_free (*pp);
   ^~~~~~~~~~~~
hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared here
     g_autofree char *cmd_flags;
                      ^~~~~~~~~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
---
 hw/i2c/aspeed_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
index 9cda968501..fb973a983d 100644
--- a/hw/i2c/aspeed_i2c.c
+++ b/hw/i2c/aspeed_i2c.c
@@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus)
 
 static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus)
 {
-    g_autofree char *cmd_flags;
+    g_autofree char *cmd_flags = NULL;
     uint32_t count;
 
     if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {
-- 
2.23.0



Re: [PATCH] aspeed/i2c:fix uninitialized variable warning
Posted by Thomas Huth 4 years, 3 months ago
On 06/02/2020 05.07, kuhn.chenqun@huawei.com wrote:
> From: Chen Qun <kuhn.chenqun@huawei.com>
> 
> Fix warning:
> hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’:
> glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>    g_free (*pp);
>    ^~~~~~~~~~~~
> hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared here
>      g_autofree char *cmd_flags;
>                       ^~~~~~~~~
> 
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
> ---
>  hw/i2c/aspeed_i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
> index 9cda968501..fb973a983d 100644
> --- a/hw/i2c/aspeed_i2c.c
> +++ b/hw/i2c/aspeed_i2c.c
> @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus)
>  
>  static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus)
>  {
> -    g_autofree char *cmd_flags;
> +    g_autofree char *cmd_flags = NULL;
>      uint32_t count;
>  
>      if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {
> 

Thanks. Looks like the same patch that has been reported already here:

https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04492.html

Could someone please pick this up (e.g. qemu-trivial?)?

 Thomas


Re: [PATCH] aspeed/i2c:fix uninitialized variable warning
Posted by Laurent Vivier 4 years, 3 months ago
Le 06/02/2020 à 09:21, Thomas Huth a écrit :
> On 06/02/2020 05.07, kuhn.chenqun@huawei.com wrote:
>> From: Chen Qun <kuhn.chenqun@huawei.com>
>>
>> Fix warning:
>> hw/i2c/aspeed_i2c.c: In function ‘aspeed_i2c_bus_write’:
>> glib/glib-autocleanups.h:28:3: warning: ‘cmd_flags’ may be
>> used uninitialized in this function [-Wmaybe-uninitialized]
>>    g_free (*pp);
>>    ^~~~~~~~~~~~
>> hw/i2c/aspeed_i2c.c:403:22: note: ‘cmd_flags’ was declared here
>>      g_autofree char *cmd_flags;
>>                       ^~~~~~~~~
>>
>> Reported-by: Euler Robot <euler.robot@huawei.com>
>> Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
>> ---
>>  hw/i2c/aspeed_i2c.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2c.c
>> index 9cda968501..fb973a983d 100644
>> --- a/hw/i2c/aspeed_i2c.c
>> +++ b/hw/i2c/aspeed_i2c.c
>> @@ -400,7 +400,7 @@ static bool aspeed_i2c_check_sram(AspeedI2CBus *bus)
>>  
>>  static void aspeed_i2c_bus_cmd_dump(AspeedI2CBus *bus)
>>  {
>> -    g_autofree char *cmd_flags;
>> +    g_autofree char *cmd_flags = NULL;
>>      uint32_t count;
>>  
>>      if (bus->cmd & (I2CD_RX_BUFF_ENABLE | I2CD_RX_BUFF_ENABLE)) {
>>
> 
> Thanks. Looks like the same patch that has been reported already here:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04492.html
> 
> Could someone please pick this up (e.g. qemu-trivial?)?

I will add the patch from Miroslav in my coming pull request.

Thanks,
Laurent