[PATCH] make all Python scripts executable

Paolo Bonzini posted 1 patch 4 years, 3 months ago
Test docker-quick@centos7 passed
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200204160237.16889-1-pbonzini@redhat.com
scripts/minikconf.py   | 0
scripts/signrom.py     | 0
tests/qemu-iotests/222 | 0
tests/qemu-iotests/245 | 0
4 files changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 scripts/minikconf.py
mode change 100644 => 100755 scripts/signrom.py
mode change 100644 => 100755 tests/qemu-iotests/222
mode change 100644 => 100755 tests/qemu-iotests/245
[PATCH] make all Python scripts executable
Posted by Paolo Bonzini 4 years, 3 months ago
Scripts that have a Python shebang are meant to be executed directly from the
shell; give them 755 permissions.

Based-on: <20200204160028.16211-1-pbonzini@redhat.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/minikconf.py   | 0
 scripts/signrom.py     | 0
 tests/qemu-iotests/222 | 0
 tests/qemu-iotests/245 | 0
 4 files changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 scripts/minikconf.py
 mode change 100644 => 100755 scripts/signrom.py
 mode change 100644 => 100755 tests/qemu-iotests/222
 mode change 100644 => 100755 tests/qemu-iotests/245

diff --git a/scripts/minikconf.py b/scripts/minikconf.py
old mode 100644
new mode 100755
diff --git a/scripts/signrom.py b/scripts/signrom.py
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
old mode 100644
new mode 100755
diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
old mode 100644
new mode 100755
-- 
2.21.0


Re: [PATCH] make all Python scripts executable
Posted by Philippe Mathieu-Daudé 4 years, 3 months ago
On 2/4/20 5:02 PM, Paolo Bonzini wrote:
> Scripts that have a Python shebang are meant to be executed directly from the
> shell; give them 755 permissions.

Ah I should have done the chmod in my "Explicit usage of Python 3 
(scripts with __main__)" patches, but I would have missed 
scripts/signrom.py and tests/qemu-iotests/222.

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

> Based-on: <20200204160028.16211-1-pbonzini@redhat.com>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   scripts/minikconf.py   | 0
>   scripts/signrom.py     | 0
>   tests/qemu-iotests/222 | 0
>   tests/qemu-iotests/245 | 0
>   4 files changed, 0 insertions(+), 0 deletions(-)
>   mode change 100644 => 100755 scripts/minikconf.py
>   mode change 100644 => 100755 scripts/signrom.py
>   mode change 100644 => 100755 tests/qemu-iotests/222
>   mode change 100644 => 100755 tests/qemu-iotests/245
> 
> diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> old mode 100644
> new mode 100755
> diff --git a/scripts/signrom.py b/scripts/signrom.py
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/222 b/tests/qemu-iotests/222
> old mode 100644
> new mode 100755
> diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245
> old mode 100644
> new mode 100755
> 

Thanks, patch applied to my python-next tree:
https://gitlab.com/philmd/qemu/commits/python-next