Makefile: Fix typo in dependency list for interop manpages

[PATCH] Makefile: Fix typo in dependency list for interop manpages

Peter Maydell posted 1 patch 6 years ago

Download mbox

Test docker-quick@centos7 failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test checkpatch failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/20200203154232.10648-1-peter.maydell@linaro.org

Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH] Makefile: Fix typo in dependency list for interop manpages

Posted by Peter Maydell 6 years ago

Fix a typo in the dependency list for the manpages built from the
'interop' manual, which meant we were accidentally not including
the .hx file in the dependency list.

Fixes: e13c59fa4414215500e6
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Oops...
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 1f37523b528..588a2993d93 100644
--- a/Makefile
+++ b/Makefile
@@ -1052,7 +1052,7 @@ $(MANUAL_BUILDDIR)/system/index.html: $(call manual-deps,system)
 
 $(call define-manpage-rule,interop,\
        qemu-ga.8 qemu-img.1 qemu-nbd.8 qemu-trace-stap.1 virtfs-proxy-helper.1,\
-       $(SRC_PATH/qemu-img-cmds.hx))
+       $(SRC_PATH)/qemu-img-cmds.hx)
 
 $(call define-manpage-rule,system,qemu-block-drivers.7)
 
-- 
2.20.1

Re: [PATCH] Makefile: Fix typo in dependency list for interop manpages

Posted by Philippe Mathieu-Daudé 6 years ago

On 2/3/20 4:42 PM, Peter Maydell wrote:
> Fix a typo in the dependency list for the manpages built from the
> 'interop' manual, which meant we were accidentally not including
> the .hx file in the dependency list.
> 
> Fixes: e13c59fa4414215500e6
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Oops...
> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 1f37523b528..588a2993d93 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1052,7 +1052,7 @@ $(MANUAL_BUILDDIR)/system/index.html: $(call manual-deps,system)
>   
>   $(call define-manpage-rule,interop,\
>          qemu-ga.8 qemu-img.1 qemu-nbd.8 qemu-trace-stap.1 virtfs-proxy-helper.1,\
> -       $(SRC_PATH/qemu-img-cmds.hx))
> +       $(SRC_PATH)/qemu-img-cmds.hx)
>   
>   $(call define-manpage-rule,system,qemu-block-drivers.7)
>   
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>