When we added bdrv_has_zero_init_truncate(), we chose to blindly
return 0 if a backing file was present, because we knew of the corner
case where a backing layer larger than the current layer might leak
the tail of the backing layer into the resized region. But as this
setup is rare, it penalizes the more common case of a backing layer
smaller than the current layer.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
block.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index 296845040e59..d132662f3103 100644
--- a/block.c
+++ b/block.c
@@ -5112,9 +5112,19 @@ int bdrv_has_zero_init_truncate(BlockDriverState *bs)
return 0;
}
+ /*
+ * If the current layer is smaller than the backing layer,
+ * truncation may expose backing data; treat failure to query size
+ * in the same manner. Otherwise, we can trust the driver.
+ */
+
if (bs->backing) {
- /* Depends on the backing image length, but better safe than sorry */
- return 0;
+ int64_t back = bdrv_getlength(bs->backing->bs);
+ int64_t curr = bdrv_getlength(bs);
+
+ if (back < 0 || curr < back) {
+ return 0;
+ }
}
if (bs->drv->bdrv_has_zero_init_truncate) {
return bs->drv->bdrv_has_zero_init_truncate(bs);
--
2.24.1