[v2] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86

[PATCH v2 02/29] accel/accel: Make TYPE_ACCEL abstract

Posted by Philippe Mathieu-Daudé 6 years ago

There is no generic acceleration, we have to use specific
implementations. Make the base class abstract.

Fixes: b14a0b7469f
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 accel/accel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/accel/accel.c b/accel/accel.c
index cb555e3b06..a0169b4e69 100644
--- a/accel/accel.c
+++ b/accel/accel.c
@@ -33,6 +33,7 @@
 static const TypeInfo accel_type = {
     .name = TYPE_ACCEL,
     .parent = TYPE_OBJECT,
+    .abstract = true,
     .class_size = sizeof(AccelClass),
     .instance_size = sizeof(AccelState),
 };
-- 
2.21.1

Re: [PATCH v2 02/29] accel/accel: Make TYPE_ACCEL abstract

Posted by Philippe Mathieu-Daudé 6 years ago

Since this file isn't covered in MAINTAINERS, manually Cc'ing Paolo.

On 1/29/20 10:23 PM, Philippe Mathieu-Daudé wrote:
> There is no generic acceleration, we have to use specific
> implementations. Make the base class abstract.
> 
> Fixes: b14a0b7469f
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   accel/accel.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/accel/accel.c b/accel/accel.c
> index cb555e3b06..a0169b4e69 100644
> --- a/accel/accel.c
> +++ b/accel/accel.c
> @@ -33,6 +33,7 @@
>   static const TypeInfo accel_type = {
>       .name = TYPE_ACCEL,
>       .parent = TYPE_OBJECT,
> +    .abstract = true,
>       .class_size = sizeof(AccelClass),
>       .instance_size = sizeof(AccelState),
>   };
>

Re: [PATCH v2 02/29] accel/accel: Make TYPE_ACCEL abstract

Posted by Cornelia Huck 6 years ago

On Wed, 29 Jan 2020 22:23:18 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> There is no generic acceleration, we have to use specific
> implementations. Make the base class abstract.
> 
> Fixes: b14a0b7469f

Fixes: b14a0b7469fa ("accel: Use QOM classes for accel types")

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  accel/accel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/accel/accel.c b/accel/accel.c
> index cb555e3b06..a0169b4e69 100644
> --- a/accel/accel.c
> +++ b/accel/accel.c
> @@ -33,6 +33,7 @@
>  static const TypeInfo accel_type = {
>      .name = TYPE_ACCEL,
>      .parent = TYPE_OBJECT,
> +    .abstract = true,
>      .class_size = sizeof(AccelClass),
>      .instance_size = sizeof(AccelState),
>  };

Reviewed-by: Cornelia Huck <cohuck@redhat.com>