[v2] tests/acceptance/virtio_seg_max_adjust: Restrict it to Linux/X86

[PATCH v2 26/29] tests/acceptance/boot_linux_console: Do not use VGA on Clipper machine

Posted by Philippe Mathieu-Daudé 6 years ago

As we only read the serial console, we don't need to force a
VGA display. This fixes when running a binary built with
--without-default-devices:

  ERROR: qemu-system-alpha: standard VGA not available

We also need the '-nodefaults' argument to avoid:

  ERROR: qemu-system-alpha: Unsupported NIC model: e1000

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 tests/acceptance/boot_linux_console.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index e40b84651b..7d6065828c 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -519,7 +519,7 @@ class BootLinuxConsole(Test):
 
         self.vm.set_console()
         kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyS0'
-        self.vm.add_args('-vga', 'std',
+        self.vm.add_args('-nodefaults',
                          '-kernel', uncompressed_kernel,
                          '-append', kernel_command_line)
         self.vm.launch()
-- 
2.21.1

Re: [PATCH v2 26/29] tests/acceptance/boot_linux_console: Do not use VGA on Clipper machine

Posted by Thomas Huth 6 years ago

On 29/01/2020 22.23, Philippe Mathieu-Daudé wrote:
> As we only read the serial console, we don't need to force a
> VGA display. This fixes when running a binary built with
> --without-default-devices:
> 
>   ERROR: qemu-system-alpha: standard VGA not available
> 
> We also need the '-nodefaults' argument to avoid:
> 
>   ERROR: qemu-system-alpha: Unsupported NIC model: e1000
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  tests/acceptance/boot_linux_console.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index e40b84651b..7d6065828c 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -519,7 +519,7 @@ class BootLinuxConsole(Test):
>  
>          self.vm.set_console()
>          kernel_command_line = self.KERNEL_COMMON_COMMAND_LINE + 'console=ttyS0'
> -        self.vm.add_args('-vga', 'std',
> +        self.vm.add_args('-nodefaults',
>                           '-kernel', uncompressed_kernel,
>                           '-append', kernel_command_line)
>          self.vm.launch()

Reviewed-by: Thomas Huth <thuth@redhat.com>